From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E3CD3A872B; Wed, 4 Mar 2026 11:16:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772622972; cv=none; b=k8Nc2KJCkdNtpydNZMxjyMrVG7YIadb+SP0T6B8G8AjU2EQ4b/wb8jBC0pD5Mtb/z9Sf5yDc9TETq80vX58y/ukyKjBoxnX+/pVHg/gzH0ZOYY9vYx7FjpV3k2B7C9e7l6/E6jFX4ZYHr9XTOoJrxM0037NaZSE7suUHrrYzUrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772622972; c=relaxed/simple; bh=i9TS72F0QK9frAqCtJcV/biHy156LHuWzCr0OTOqBNM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lA33aXNbK7l0kC1uQlvJjBtTOR4RjMEYp7sYth4H0TBYjXKVej2wH+g1pEmJSkjeS2KR9YltbtHJnr5n3dm+Sg8oY7YQ0lqhTC43YWX1KNqJzy6ruaVhLEHwSJWyD6odYHsRoxdGhjq2MWiyU+Sy2uUvaQR6ObAqhCD+6IetPzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vHN9zEDN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vHN9zEDN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2515FC19423; Wed, 4 Mar 2026 11:16:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772622972; bh=i9TS72F0QK9frAqCtJcV/biHy156LHuWzCr0OTOqBNM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vHN9zEDNt7+WOMHucjTPyo7b15dFRVUfJwvaG78Lo9orbHKn0kMhU7K3OMsTkF1lW v5p9bryngzYHjvD8hSXTPS+klIr4RT/CzimqHNyIBdPgj0zKKQkwTTZ/vZnYkCDnSS ocO2gXeMZfYCIJWyXjiWaYm6P+29uBY3PGjy6EPvp1CkvYCUSanjvuXJZN0FejFyf/ rPMXrATfQUF6nRInROhow06r+BhLeH3AMK/VjENx8PFmNT8uPYMriqfI+MfjNjc9ke wDu5ic4CMd21PmN3FMvBIE4KO6m/9zqfg5W91ZUH4QGPU9tfT5DyYGh5g/jd2NjbXb KKduMr5TfXLOg== Date: Wed, 4 Mar 2026 11:16:07 +0000 From: Simon Horman To: Jian Zhang Cc: Samuel Mendoza-Jonas , Paul Fertser , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: ncsi: fix skb leak in error paths Message-ID: <20260304111607.GH71509@kernel.org> References: <20260302054629.1347119-1-zhangjian.3032@bytedance.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260302054629.1347119-1-zhangjian.3032@bytedance.com> On Mon, Mar 02, 2026 at 01:46:29PM +0800, Jian Zhang wrote: > Early return paths in NCSI RX and AEN handlers fail to release > the received skb, resulting in a memory leak. > > Specifically, ncsi_aen_handler() returns on invalid AEN packets > without consuming the skb. Similarly, ncsi_rcv_rsp() exits early > when failing to resolve the NCSI device, response handler, or > request, leaving the skb unfreed. > > Signed-off-by: Jian Zhang As fixes for Networking code these should have fixes tags. I think the following are appropriate. Fixes: 7a82ecf4cfb8 ("net/ncsi: NCSI AEN packet handler") Fixes: 138635cc27c9 ("net/ncsi: NCSI response packet handler") As they seem to be commits from the same patch-set, included in the same release - v4.8-rc1, I think we can keep this as a single patch. If you agree then it shouldn't be necessary to post a new version because of this, as patchwork should pick up the tags above. But for future reference, assuming these are backporting candidates, it's best to CC stable on bugfixes for net. Overall, this looks good to me. Reviewed-by: Simon Horman