From: Florian Westphal <fw@strlen.de>
To: <netdev@vger.kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
<netfilter-devel@vger.kernel.org>,
pablo@netfilter.org
Subject: [PATCH net-next 09/14] netfilter: nfnetlink_queue: remove locking in nfqnl_get_sk_secctx
Date: Wed, 4 Mar 2026 12:49:16 +0100 [thread overview]
Message-ID: <20260304114921.31042-10-fw@strlen.de> (raw)
In-Reply-To: <20260304114921.31042-1-fw@strlen.de>
We don't need the cb lock here.
Also, if skb was NULL we'd have crashed already.
Signed-off-by: Florian Westphal <fw@strlen.de>
---
net/netfilter/nfnetlink_queue.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
index 27300d3663da..5379d8ff39c0 100644
--- a/net/netfilter/nfnetlink_queue.c
+++ b/net/netfilter/nfnetlink_queue.c
@@ -592,15 +592,8 @@ static int nfqnl_get_sk_secctx(struct sk_buff *skb, struct lsm_context *ctx)
{
int seclen = 0;
#if IS_ENABLED(CONFIG_NETWORK_SECMARK)
-
- if (!skb || !sk_fullsock(skb->sk))
- return 0;
-
- read_lock_bh(&skb->sk->sk_callback_lock);
-
if (skb->secmark)
seclen = security_secid_to_secctx(skb->secmark, ctx);
- read_unlock_bh(&skb->sk->sk_callback_lock);
#endif
return seclen;
}
--
2.52.0
next prev parent reply other threads:[~2026-03-04 11:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 11:49 [PATCH net-next 00/14] netfilter: updates for net-next Florian Westphal
2026-03-04 11:49 ` [PATCH net-next 01/14] ipv6: export fib6_lookup for nft_fib_ipv6 Florian Westphal
2026-03-05 10:51 ` patchwork-bot+netdevbpf
2026-03-04 11:49 ` [PATCH net-next 02/14] ipv6: make ipv6_anycast_destination logic usable without dst_entry Florian Westphal
2026-03-04 11:49 ` [PATCH net-next 03/14] netfilter: nft_fib_ipv6: switch to fib6_lookup Florian Westphal
2026-03-04 11:49 ` [PATCH net-next 04/14] netfilter: nf_log_syslog: no longer acquire sk_callback_lock in nf_log_dump_sk_uid_gid() Florian Westphal
2026-03-04 11:49 ` [PATCH net-next 05/14] netfilter: xt_owner: no longer acquire sk_callback_lock in mt_owner() Florian Westphal
2026-03-04 11:49 ` [PATCH net-next 06/14] netfilter: nft_meta: no longer acquire sk_callback_lock in nft_meta_get_eval_skugid() Florian Westphal
2026-03-04 11:49 ` [PATCH net-next 07/14] netfilter: nfnetlink_log: no longer acquire sk_callback_lock Florian Westphal
2026-03-04 11:49 ` [PATCH net-next 08/14] netfilter: nfnetlink_queue: " Florian Westphal
2026-03-04 11:49 ` Florian Westphal [this message]
2026-03-04 11:49 ` [PATCH net-next 10/14] rculist_bl: add hlist_bl_for_each_entry_continue_rcu Florian Westphal
2026-03-04 11:49 ` [PATCH net-next 11/14] ipvs: add resizable hash tables Florian Westphal
2026-03-04 11:49 ` [PATCH net-next 12/14] ipvs: use resizable hash table for services Florian Westphal
2026-03-04 11:49 ` [PATCH net-next 13/14] ipvs: switch to per-net connection table Florian Westphal
2026-03-04 11:49 ` [PATCH net-next 14/14] ipvs: use more keys for connection hashing Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260304114921.31042-10-fw@strlen.de \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox