public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@openvpn.net>
To: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Cc: Antonio Quartulli <antonio@openvpn.net>,
	Simon Horman <horms@kernel.org>,
	Donald Hunter <donald.hunter@gmail.com>,
	Ralf Lici <ralf@mandelbit.com>
Subject: [PATCH net-next] tools: ynl: add uns-admin-perm to genetlink
Date: Wed,  4 Mar 2026 15:10:09 +0100	[thread overview]
Message-ID: <20260304141020.23270-1-antonio@openvpn.net> (raw)

GENL_UNS_ADMIN_PERM may be required by protocols using
the `genetlink` family, however, this flag is currently
only allowed in `genetlink-legacy`.

Add it to the list of possible values in genetlink.yaml too.

Cc: Simon Horman <horms@kernel.org>
Cc: Donald Hunter <donald.hunter@gmail.com>
Link: https://github.com/OpenVPN/ovpn-net-next/issues/33
Suggested-by: Ralf Lici <ralf@mandelbit.com>
Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
---

As described in the linked GH issue, we hit an issue with OpenVPN
running in a user namespace that was unable to send netlink
messages to the ovpn kernel module.

After checking how other modules handles this, we saw that we
required the uns-admin-perm cmd-flag. However, this flag is allowed
only for genetlink-legacy protocols, which ovpn is not.

I don't see a clear reason why genetlink shouldn't have this flag too,
hence I am proposing this patch.


 Documentation/netlink/genetlink.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/netlink/genetlink.yaml b/Documentation/netlink/genetlink.yaml
index b020a537d8ac..a1194d5d93fc 100644
--- a/Documentation/netlink/genetlink.yaml
+++ b/Documentation/netlink/genetlink.yaml
@@ -262,7 +262,7 @@ properties:
               description: Command flags.
               type: array
               items:
-                enum: [ admin-perm ]
+                enum: [ admin-perm, uns-admin-perm ]
             dont-validate:
               description: Kernel attribute validation flags.
               type: array
-- 
2.52.0


             reply	other threads:[~2026-03-04 14:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04 14:10 Antonio Quartulli [this message]
2026-03-05 11:36 ` [PATCH net-next] tools: ynl: add uns-admin-perm to genetlink Donald Hunter
2026-03-05 15:04   ` Jakub Kicinski
2026-03-06  3:32 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260304141020.23270-1-antonio@openvpn.net \
    --to=antonio@openvpn.net \
    --cc=donald.hunter@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ralf@mandelbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox