From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A6AF3B5823; Wed, 4 Mar 2026 14:54:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772636100; cv=none; b=ouA6Eky1ki2Z0Wv81y6QhwFYN392pvf6qjVkHQHQGtx7GHvUOQUaWS5vsDZtNnRRvG0QV14Bt+C3VIZd1hSRZDBajna+3cdJOL5UL0dUDk5SSkNb8ZmsKlxhJrTFPhjvpGo6UMhyIbafSGumMzmgakImeXJ/te2Ysxc/HRMYo9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772636100; c=relaxed/simple; bh=kVpjUlCB79NcHi43+sAsJmu129Vqr6rue4vNA1KfbBw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FpW0zqxAcq4KT3oEArV8n1XH2QVVF7KhojBLMFRTdTcO+dalu3zfmD9Igmt62GryloJmDLfQRoMOR9XKtxGLnzqs6BEQtD4dogapluzHsfzCsrys9pE7DABLjuUJz4l8VEbQdPd0vPuxdvA3KgDod8fZeCCXWFRiGA8SglFYpwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=JHJ6f+jo; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="JHJ6f+jo" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id DE5F81A2C7A; Wed, 4 Mar 2026 14:54:54 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B02F95FF5C; Wed, 4 Mar 2026 14:54:54 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A6F2310368FE0; Wed, 4 Mar 2026 15:54:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1772636093; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding; bh=9sBAQrCmRD8j1TWCHlkHTxK3VANHEzIA//wEBClITyQ=; b=JHJ6f+joPugiRNIRI74L6xC/2SwuHGNi42LYRae4y0fK5cPncEv66n9txf41myOfRn/tzE j8NXEl2TX6k4Jc5UgM+ZxpJMA/BW3LnFUfkDyktPPGUlKF9dYV8ieHanw0UQi1OBZOFve3 t0YZQIOWgkfwuOvGJnLP+S+wXYxaAhSa8oQ8J6NmJyJr6ZhHHAnFyCyHdXaSgpm6OeSWVd +Mdl2r/8J3XXEIT/Mknk1WGlBx6+vutKQAdQSe6sMXTLr5O8cVN4q5/Tly2hRMHabtkP+b 1zrCkDUoEnqi9Tf7gDB482a/lQ/xYGcwkPHd7GCIwE5DKersf6jNLhygZ5NA3g== From: Maxime Chevallier To: davem@davemloft.net, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , Heiner Kallweit Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?q?K=C3=B6ry=20Maincent?= , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Oleksij Rempel , =?UTF-8?q?Nicol=C3=B2=20Veronese?= , Simon Horman , mwojtas@chromium.org, Romain Gantois , Daniel Golle , Dimitri Fedrau Subject: [PATCH net-next v6 00/10] net: phy_port: SFP modules representation and phy_port listing Date: Wed, 4 Mar 2026 15:54:31 +0100 Message-ID: <20260304145444.442334-1-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hello everyone, Here's V6 of the second phy_port series, this time bringing support for more phy_port use especially for SFP, as well as the begining of a ethnl uAPI. V6 is shorter than V5, as some of the patches were applied already for 7.0 (thanks !). The changes in v6 are some comments to better explain (to the AI reviewers) when the SFP module port is cleaned, but there's also a small cleanup for the port topology handling in there (also after AI review). It builds on the recent addition of phy_port representation to enable listing the front-facing ports of an interface. For now, we don't control these ports, we merely list their presence and their capabilities. As the most common use-case of multi-port interfaces is combo-ports that provide both RJ45 and SFP connectors on a single MAC, there's a lot of SFP stuff in this series. This series is in 2 main parts. The first one aims at representing the SFP cages and modules using phy_port, as combo-ports with RJ45 + SFP are by far the most common cases for multi-connector setups. The second part is the netlink interface to list those ports, now that most use-cases are covered. Let's see what we can do with some examples of the new ethtool API : - Get MII interfaces supported by an empty SFP cage : # ethtool --show-ports eth3 Port for eth3: Port id: 1 Vacant: yes Supported MII interfaces : sgmii, 1000base-x, 2500base-x Port type: sfp - Get Combo-ports supported modes, on each port : # ethtool --show-ports eth1 Port for eth1: Port id: 1 Vacant: no Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 10000baseT/Full 2500baseT/Full 5000baseT/Full Port type: mdi Port for eth1: Port id: 2 Vacant: yes Supported MII interfaces : 10gbase-r Port type: sfp - Get Achievable linkmodes on a SFP module (combo port with a DAC in the SFP cage) # ethtool --show-ports eth1 Port for eth1: Port id: 1 Vacant: no Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 10000baseT/Full 2500baseT/Full 5000baseT/Full Port type: mdi Port for eth1: Port id: 2 Vacant: no Supported MII interfaces : 10gbase-r Port type: sfp Port for eth1: Port id: 3 Vacant: no Supported link modes: 10000baseCR/Full Port type: mdi Note that here, we have 3 ports : - The Copper port - The SFP Cage itself, marked as 'occupied' - The SFP module This series builds on top of phy_port and phy_link_topology to allow tracking the ports of an interface. We maintain a list of supported linkmodes/interfaces on each port, which allows for fine-grained reporting of each port's capability. What this series doesn't do : - We don't support selecting which port is active. This is the next step. - We only support PHY-driven combo ports. The end-goal of this whole journey that started with phy_link_topology is to get support for MII muxes, such as the one we have on the Turris Omnia. This will eventually be upstreamed as well. If you want to play around with it, here's [1] the patched ethtool that I've been using to produce the outputs above. Thanks ! Maxime [1] : https://github.com/minimaxwell/ethtool/tree/mc/ethtool_port Changelog : Changes in V6: - Added some comments in th mod_port cleanup - changed some kmalloc to kmalloc_obj - Removed some phy_link_topo_del_port that wasn't needed Changes in V5: V5: https://lore.kernel.org/r/20260205092317.755906-1-maxime.chevallier@bootlin.com - Fixed a check on a potentially un-initialized pointer, reported by Simon - Fixed a documentation formatting issue - Remove a stray pr_info - Rebased on net-next Changes in V4: V4 : https://lore.kernel.org/netdev/20260203172839.548524-1-maxime.chevallier@bootlin.com/ - Add a cleanup patch for the of port parsing - Added a match to sync the port's linkmodes with the PHY's for OF ports - Added RTNL assert in the port_get topo helper - nullify the bus port for phylink support - Fix some typos Changes in V3: V3: https://lore.kernel.org/netdev/20260201151249.642015-1-maxime.chevallier@bootlin.com/ - Remove the sfp bus ops for nophy, and use .module_start() as suggested by Russell - Added missing cleanup for the topology, as per AI review - Fixed a few typos as per Romain's review - Changed "occupied" to "vacant" as per Romain's review - Added missing checks for null ports, per AI review Changes in V2: V2: https://lore.kernel.org/netdev/20260128204526.170927-1-maxime.chevallier@bootlin.com/ - Fix the cleanup path of phy_link_topo_add_phy, as per AI review - Fix the cleanup path of phy_sfp_probe, as per AI review - Fix the call-site of the disconnect_nophy sfp bus ops, per AI review - Fix the netdev-less case uin phylink, per AI review - Fix the prototype of phy_link_topo_get_port for the stubs - Dropped patch 11. It ended-up breaking 'allnoconfig', so instead we built a phy_interface_names array in net/ethtool/netlink.c - Fix an ethool-netlink spec discrepancy with the type of an attribute - Fix the size computation in the netlink port API - Fix the cleanup path in the netlink port API V1: https://lore.kernel.org/netdev/20260127134202.8208-1-maxime.chevallier@bootlin.com/ Maxime Chevallier (10): net: phy: phy_link_topology: Add a helper for opportunistic alloc net: phy: phy_link_topology: Track ports in phy_link_topology net: phylink: Register a phy_port for MAC-driven SFP busses net: phy: Create SFP phy_port before registering upstream net: phy: Represent PHY-less SFP modules with phy_port net: phylink: Represent PHY-less SFP modules with phy_port net: phy: phy_port: Store information about a MII port's vacant state net: phy: phy_link_topology: Add a helper to retrieve ports netlink: specs: Add ethernet port listing with ethtool net: ethtool: Introduce ethtool command to list ports Documentation/netlink/specs/ethtool.yaml | 50 +++ Documentation/networking/ethtool-netlink.rst | 35 ++ MAINTAINERS | 1 + drivers/net/phy/phy-caps.h | 2 + drivers/net/phy/phy_caps.c | 26 ++ drivers/net/phy/phy_device.c | 146 ++++++- drivers/net/phy/phy_link_topology.c | 82 +++- drivers/net/phy/phylink.c | 125 ++++++ include/linux/phy.h | 6 + include/linux/phy_link_topology.h | 39 ++ include/linux/phy_port.h | 6 + .../uapi/linux/ethtool_netlink_generated.h | 19 + net/core/dev.c | 1 + net/ethtool/Makefile | 2 +- net/ethtool/netlink.c | 26 ++ net/ethtool/netlink.h | 8 + net/ethtool/port.c | 376 ++++++++++++++++++ 17 files changed, 923 insertions(+), 27 deletions(-) create mode 100644 net/ethtool/port.c -- 2.49.0