From: Jakub Kicinski <kuba@kernel.org>
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: netdev@vger.kernel.org, horms@kernel.org, pabeni@redhat.com,
edumazet@google.com, dsahern@kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next v3] ipv4: validate IPV4_DEVCONF attributes properly
Date: Wed, 4 Mar 2026 18:07:25 -0800 [thread overview]
Message-ID: <20260304180725.717a3f0d@kernel.org> (raw)
In-Reply-To: <20260303124038.5886-1-fmancera@suse.de>
On Tue, 3 Mar 2026 13:40:38 +0100 Fernando Fernandez Mancera wrote:
> + [IPV4_DEVCONF_MEDIUM_ID] = { .type = NLA_S32, .min = -1 },
Don't we have to set validation type for this to take effect?
Why not use NLA_POLICY_MIN() ?
> + [IPV4_DEVCONF_ARP_ACCEPT] = NLA_POLICY_RANGE(NLA_U32, 0, 1),
This one should accept 2 as well?
--
pw-bot: cr
prev parent reply other threads:[~2026-03-05 2:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 12:40 [PATCH net-next v3] ipv4: validate IPV4_DEVCONF attributes properly Fernando Fernandez Mancera
2026-03-05 2:07 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260304180725.717a3f0d@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fmancera@suse.de \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox