From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 562EC1B983F; Thu, 5 Mar 2026 03:01:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772679718; cv=none; b=gVQrU7keCQc2XMSMbjoJQsBFHPifqFPiUAEWFh0NI0Jky/yJWhk99uQyUGXMvTZ6Hmi5kW/Oq/SwGiO1NqyPW2VWIFEpA7Euz1RNLiFiaHZFSgO1Pj6oz33Sb2MJ9drIctN8yqHVaDCvkJkMuQMnrVfoGAYytyZK6pXys9p1cQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772679718; c=relaxed/simple; bh=g/xB4YsTbYh0ccsdun8rgPCLY72J9n6v5AetsTKKLRI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZV3NRWWAtKyfEjHJ7HUJ6j5QIiBZoy4IROHXBaKy2KZbUb2RbtCcpdnWCgbSFI412vfhqiwntRJ44CjA6f69tBgmXZ9WumnXh980j8i2fP0fuQDeqITdkNYfqXzLmXsAmGErIIKzrI+KKIi2uJdTQYyHMBBXgLvwD56lpy9GCn4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WB6p7voS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WB6p7voS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DDDEC4CEF7; Thu, 5 Mar 2026 03:01:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772679717; bh=g/xB4YsTbYh0ccsdun8rgPCLY72J9n6v5AetsTKKLRI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WB6p7voSleUADKS6z22jdQc4R+TffsXzkMM3RdtjGhMJwXfx2X11eaBqz6ewPjE/5 hWpfyKea3LgKHC+Yy7xacQc5sgDpurhiXrHcE+wX3lGno4punIxgHWmPh78zWK6IPl 63bJqE0jh5ayJLmTxQbY4pK+aC8u1wYSNcV30i4/4sVVRJBASEIvYzpozihonqn3RV a59p1YcwhTGeQfbz8wcVzYXegAwtBKI/S/iLuDG+ucuf68SMD+EOQSwgpMZGfSLx4D pLeVOhZx4dEjFrPWBDIN/i+O4o/+dATR7nnplTebBITebhSgs106PJcp4ASubZ0WOO qItJxaZGCY/oA== Date: Wed, 4 Mar 2026 19:01:56 -0800 From: Jakub Kicinski To: Chintan Vankar Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Siddharth Vadapalli , Michael Walle , Nishanth Menon , Vadim Fedorenko , Vignesh Raghavendra , Matthias Schiffer , "MD Danish Anwar" , Vishnu Singh , , Subject: Re: [PATCH net] net: ethernet: ti: am65-cpsw-nuss: Fix rx_filter value for PTP support Message-ID: <20260304190156.319df897@kernel.org> In-Reply-To: <20260303075819.3246032-1-c-vankar@ti.com> References: <20260303075819.3246032-1-c-vankar@ti.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 3 Mar 2026 13:28:19 +0530 Chintan Vankar wrote: > @@ -1888,8 +1894,8 @@ static int am65_cpsw_nuss_hwtstamp_get(struct net_device *ndev, > cfg->flags = 0; > cfg->tx_type = port->tx_ts_enabled ? > HWTSTAMP_TX_ON : HWTSTAMP_TX_OFF; > - cfg->rx_filter = port->rx_ts_enabled ? HWTSTAMP_FILTER_PTP_V2_EVENT | > - HWTSTAMP_FILTER_PTP_V1_L4_EVENT : HWTSTAMP_FILTER_NONE; > + cfg->rx_filter = port->rx_ts_enabled ? > + port->rx_ts_filter : HWTSTAMP_FILTER_NONE; HWTSTAMP_FILTER_NONE == 0 a lot of code depends on that so you can just assign port->rx_ts_filter > > return 0; > } > diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.h b/drivers/net/ethernet/ti/am65-cpsw-nuss.h > index 917c37e4e89b..595123c155db 100644 > --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.h > +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.h > @@ -53,6 +53,7 @@ struct am65_cpsw_port { > struct am65_cpsw_slave_data slave; > bool tx_ts_enabled; > bool rx_ts_enabled; > + int rx_ts_filter; given none == 0 you can just turn rx_ts_enabled from a bool into an enum hwtstamp_rx_filters and maybe rename it? no need to have two members in the struct for rx -- pw-bot: cr