[PATCH net-next 0/2] smc-sysctl formatting and missing entries

[PATCH net-next 0/2] smc-sysctl formatting and missing entries

[sawara04.o]

From: Kyoji Ogasawara <sawara04.o@gmail.com>

Hi,

this series updates SMC sysctl documentation in two small steps.

- patch 1 fixes indentation in the smcr_buf_type section
- patch 2 documents missing sysctl parameters limit_smc_hs and hs_ctrl,
  including values/defaults and hs_ctrl usage notes

No code or runtime behavior is changed.

Thanks,
Kyoji

Kyoji Ogasawara (2):
  net/smc: fix indentation in smcr_buf_type section
  net/smc: Add documentation for limit_smc_hs and hs_ctrl

 Documentation/networking/smc-sysctl.rst | 40 ++++++++++++++++++++-----
 1 file changed, 32 insertions(+), 8 deletions(-)

-- 
2.43.0

[PATCH net-next 1/2] net/smc: fix indentation in smcr_buf_type section

[sawara04.o]

From: Kyoji Ogasawara <sawara04.o@gmail.com>

smcr_buf_type section used inconsistent indentation compared
with the rest of this document.

Signed-off-by: Kyoji Ogasawara <sawara04.o@gmail.com>
---
 Documentation/networking/smc-sysctl.rst | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/Documentation/networking/smc-sysctl.rst b/Documentation/networking/smc-sysctl.rst
index 904a910f198e..17b8314c0e5e 100644
--- a/Documentation/networking/smc-sysctl.rst
+++ b/Documentation/networking/smc-sysctl.rst
@@ -23,17 +23,17 @@ autocorking_size - INTEGER
 	Default: 64K
 
 smcr_buf_type - INTEGER
-        Controls which type of sndbufs and RMBs to use in later newly created
-        SMC-R link group. Only for SMC-R.
+	Controls which type of sndbufs and RMBs to use in later newly created
+	SMC-R link group. Only for SMC-R.
 
-        Default: 0 (physically contiguous sndbufs and RMBs)
+	Default: 0 (physically contiguous sndbufs and RMBs)
 
-        Possible values:
+	Possible values:
 
-        - 0 - Use physically contiguous buffers
-        - 1 - Use virtually contiguous buffers
-        - 2 - Mixed use of the two types. Try physically contiguous buffers first.
-          If not available, use virtually contiguous buffers then.
+	- 0 - Use physically contiguous buffers
+	- 1 - Use virtually contiguous buffers
+	- 2 - Mixed use of the two types. Try physically contiguous buffers first.
+	  If not available, use virtually contiguous buffers then.
 
 smcr_testlink_time - INTEGER
 	How frequently SMC-R link sends out TEST_LINK LLC messages to confirm
-- 
2.43.0

[PATCH net-next 2/2] net/smc: Add documentation for limit_smc_hs and hs_ctrl

[sawara04.o]

From: Kyoji Ogasawara <sawara04.o@gmail.com>

Document missing SMC sysctl parameters limit_smc_hs and hs_ctrl

Signed-off-by: Kyoji Ogasawara <sawara04.o@gmail.com>
---
 Documentation/networking/smc-sysctl.rst | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/Documentation/networking/smc-sysctl.rst b/Documentation/networking/smc-sysctl.rst
index 17b8314c0e5e..67c2bdc533d7 100644
--- a/Documentation/networking/smc-sysctl.rst
+++ b/Documentation/networking/smc-sysctl.rst
@@ -111,3 +111,27 @@ smcr_max_recv_wr - INTEGER
 	like before having this control.
 
 	Default: 48
+
+limit_smc_hs - INTEGER
+	Whether to limit SMC handshake for newly created sockets.
+
+	When enabled, SMC listen path applies handshake limitation based on
+	handshake worker congestion and queued SMC handshake load.
+
+	Possible values:
+
+	- 0 - Disable handshake limitation
+	- 1 - Enable handshake limitation
+
+	Default: 0 (disable)
+
+hs_ctrl - STRING
+	Select the SMC handshake control profile by name.
+
+	The selected profile controls whether SMC options are advertised
+	during TCP SYN/SYN-ACK handshake.
+
+	Only available when CONFIG_SMC_HS_CTRL_BPF is enabled.
+	Write an empty string to clear the current profile.
+
+	Default: empty string
\ No newline at end of file
-- 
2.43.0

Re: [PATCH net-next 2/2] net/smc: Add documentation for limit_smc_hs and hs_ctrl

[D. Wythe]

On Thu, Mar 05, 2026 at 06:22:24PM +0900, sawara04.o@gmail.com wrote:
> From: Kyoji Ogasawara <sawara04.o@gmail.com>
> 
> Document missing SMC sysctl parameters limit_smc_hs and hs_ctrl
> 
> Signed-off-by: Kyoji Ogasawara <sawara04.o@gmail.com>
> ---
>  Documentation/networking/smc-sysctl.rst | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/Documentation/networking/smc-sysctl.rst b/Documentation/networking/smc-sysctl.rst
> index 17b8314c0e5e..67c2bdc533d7 100644
> --- a/Documentation/networking/smc-sysctl.rst
> +++ b/Documentation/networking/smc-sysctl.rst
> @@ -111,3 +111,27 @@ smcr_max_recv_wr - INTEGER
>  	like before having this control.
>  
>  	Default: 48
> +
> +limit_smc_hs - INTEGER
> +	Whether to limit SMC handshake for newly created sockets.
> +
> +	When enabled, SMC listen path applies handshake limitation based on
> +	handshake worker congestion and queued SMC handshake load.
> +
> +	Possible values:
> +
> +	- 0 - Disable handshake limitation
> +	- 1 - Enable handshake limitation
> +
> +	Default: 0 (disable)
> +
> +hs_ctrl - STRING
> +	Select the SMC handshake control profile by name.
> +
> +	The selected profile controls whether SMC options are advertised
> +	during TCP SYN/SYN-ACK handshake.
> +
> +	Only available when CONFIG_SMC_HS_CTRL_BPF is enabled.
> +	Write an empty string to clear the current profile.

It would be better to clarify that this string refers to the name of a
BPF struct_ops (type smc_hs_ctrl) implemented by the user.

> +
> +	Default: empty string
> \ No newline at end of file
> -- 
> 2.43.0
> 

Re: [PATCH net-next 2/2] net/smc: Add documentation for limit_smc_hs and hs_ctrl

[Kyoji Ogasawara]

> > +hs_ctrl - STRING
> > +     Select the SMC handshake control profile by name.
> > +
> > +     The selected profile controls whether SMC options are advertised
> > +     during TCP SYN/SYN-ACK handshake.
> > +
> > +     Only available when CONFIG_SMC_HS_CTRL_BPF is enabled.
> > +     Write an empty string to clear the current profile.
>
> It would be better to clarify that this string refers to the name of a
> BPF struct_ops (type smc_hs_ctrl) implemented by the user.
>

Thanks for the suggestion.
I updated the hs_ctrl description to clarify that the string is the
name of a user-implemented BPF struct_ops instance of type
smc_hs_ctrl.
Does this address your comment?

```
 hs_ctrl - STRING
        Select the SMC handshake control profile by name.

+       This string refers to the name of a user-implemented
+       BPF struct_ops instance of type smc_hs_ctrl.
+
        The selected profile controls whether SMC options are advertised
        during TCP SYN/SYN-ACK handshake.

        Only available when CONFIG_SMC_HS_CTRL_BPF is enabled.
        Write an empty string to clear the current profile.

        Default: empty string
```

Re: [PATCH net-next 2/2] net/smc: Add documentation for limit_smc_hs and hs_ctrl

[D. Wythe]

On Fri, Mar 06, 2026 at 01:40:39AM +0900, Kyoji Ogasawara wrote:
> > > +hs_ctrl - STRING
> > > +     Select the SMC handshake control profile by name.
> > > +
> > > +     The selected profile controls whether SMC options are advertised
> > > +     during TCP SYN/SYN-ACK handshake.
> > > +
> > > +     Only available when CONFIG_SMC_HS_CTRL_BPF is enabled.
> > > +     Write an empty string to clear the current profile.
> >
> > It would be better to clarify that this string refers to the name of a
> > BPF struct_ops (type smc_hs_ctrl) implemented by the user.
> >
> 
> Thanks for the suggestion.
> I updated the hs_ctrl description to clarify that the string is the
> name of a user-implemented BPF struct_ops instance of type
> smc_hs_ctrl.
> Does this address your comment?
> 
> ```
>  hs_ctrl - STRING
>         Select the SMC handshake control profile by name.
> 
> +       This string refers to the name of a user-implemented
> +       BPF struct_ops instance of type smc_hs_ctrl.
> +
>         The selected profile controls whether SMC options are advertised
>         during TCP SYN/SYN-ACK handshake.
> 
>         Only available when CONFIG_SMC_HS_CTRL_BPF is enabled.
>         Write an empty string to clear the current profile.
> 
>         Default: empty string
> ```

LGTM. Thanks for your contribution.

D. Wythe