From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D12536404A; Thu, 5 Mar 2026 10:48:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772707693; cv=none; b=L1EaQU0JyORYPWNNY9H2FxZh0inz7FRCIgOJBC1bto/CT9wC9qS7euvKo0wx53IkBRjrKFWF+WsyxyCVJZOrNo+rNwGGX9ixpsBM/1Ap8UKH2QwaCHGsV4lFiBxgKk4PVSVlN4PUISIf199BM94nPByr69t/DgISQHJclMaoHY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772707693; c=relaxed/simple; bh=Z/9hORvgxbNhGbIdVYDvsOkYohGvgtN+sIjCAlZe5fM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PpbgmK0d74w0Sh81geVe4Mm5RAqP5XBgGrRN5BmDtANiL3S9wIKdgcZMzBAyiLvC96gyHIR7Q1WcYctNEOPa11F4DetbIgm/Z6UR0+eki6A9YrGaZlXQzod/RrhcKjBIgJmcRO4AUEkmKsRzSW75vWDfN1b4UJfiAeIFVEq0PR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z5NzB6PS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z5NzB6PS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47F5DC116C6; Thu, 5 Mar 2026 10:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772707693; bh=Z/9hORvgxbNhGbIdVYDvsOkYohGvgtN+sIjCAlZe5fM=; h=From:To:Cc:Subject:Date:From; b=Z5NzB6PSBTgr9XPyAmfXa47ML/Wywiu4wFi59s92eFynRZvU0FBH7CMsHAH/3I9+t TGyRsdr9seL4e9nl3bXlnQGlFuUMN2D1Rx52kO3CRfx1wjuLqXxpChv1mTjgaYgRET zAOkvi8J7HEg9EPQr66xGoqwCYWdhxtZRnTNHAP6wrhI+wXPJFjfqe+xM5e0VHbOrr 9EDGVLxfcCLTILwi1W9T4p0VGhcx0Oo5vyt81iP3GXiA9c1MednbZPXwPgBDBUncwn ptajBadI/G36GtTpQ3ZYwLn13hGqUNcvnooIRXXgyP2YnvQv5HL0dDicSUJZURdxrM RABJuJoIApNxw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vy6FX-000000004ET-0MJ7; Thu, 05 Mar 2026 11:48:11 +0100 From: Johan Hovold To: Tobias Waldekranz Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH] net: mdio: mvusb: drop redundant device reference Date: Thu, 5 Mar 2026 11:47:22 +0100 Message-ID: <20260305104722.16217-1-johan@kernel.org> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/mdio/mdio-mvusb.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/mdio/mdio-mvusb.c b/drivers/net/mdio/mdio-mvusb.c index 554837c21e73..f9c16c731c73 100644 --- a/drivers/net/mdio/mdio-mvusb.c +++ b/drivers/net/mdio/mdio-mvusb.c @@ -75,7 +75,7 @@ static int mvusb_mdio_probe(struct usb_interface *interface, mvusb = mdio->priv; mvusb->mdio = mdio; - mvusb->udev = usb_get_dev(interface_to_usbdev(interface)); + mvusb->udev = interface_to_usbdev(interface); /* Reversed from USB PCAPs, no idea what these mean. */ mvusb->buf[MVUSB_CMD_PREAMBLE0] = cpu_to_le16(0xe800); @@ -90,23 +90,17 @@ static int mvusb_mdio_probe(struct usb_interface *interface, usb_set_intfdata(interface, mvusb); ret = of_mdiobus_register(mdio, dev->of_node); if (ret) - goto put_dev; + return ret; return 0; - -put_dev: - usb_put_dev(mvusb->udev); - return ret; } static void mvusb_mdio_disconnect(struct usb_interface *interface) { struct mvusb_mdio *mvusb = usb_get_intfdata(interface); - struct usb_device *udev = mvusb->udev; mdiobus_unregister(mvusb->mdio); usb_set_intfdata(interface, NULL); - usb_put_dev(udev); } static struct usb_driver mvusb_mdio_driver = { -- 2.52.0