From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE0E7211A05; Fri, 6 Mar 2026 20:57:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772830660; cv=none; b=ngztRpr80Hd471gNlUJ9BEFKoZq4KiOXu3IqVupf7xTbF6RJtgzrPSUco+NVoghbreD68rzY0dE7rinCTgNlNzbGRYQMhAR9VKZMJGf289HoE8qMr8eYutTv134uKugLvVuN0LLHcZcWHUkTSIWd6xPR0U5iO7jKjr9HxSqao3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772830660; c=relaxed/simple; bh=maChXA3sdH0SMYvMxQthAI/tM5iNsuyzsBJGVckJJEM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=O4nLBi4tH5iht1qo0eeuNjTaQhpz4zCu2rr7ZxkoTd5jW1/hZGEWG7S+sKaSls7qbJxCYhi1y0zii9DaW3w/zyrK7P95XjRI7f+U5vDdoQAuq34ioT4EVKxWiXiOKPATin9B/gBVZg7+buoz5srcyHh4wfzu3Z5mhxNEvwmipvI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NhHY0bt+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NhHY0bt+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C914C4CEF7; Fri, 6 Mar 2026 20:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772830659; bh=maChXA3sdH0SMYvMxQthAI/tM5iNsuyzsBJGVckJJEM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NhHY0bt+zwzDxQWr5k7r8zCDjy4Ruo15GISNYpajSZawgQCMRi5+Z3dmohhfaM9VO LOKrDAifRqUil8dK0e2VIe3XWHgU6CirO5oPFJlQx4crPj/CJdHmBeDsd7Sn+TBUyP 1PQ92IXCjxFu8N7icnN/tUWNMK/AZ5KpgTm/h8hMTdl+QlUd362DdAth4FEXlZ/+6g J4b3OblFmT3MPJ41T9PwB4uqRG2k5JjN7Cf8iNfDBtvhd7k4JVCOsbRLmIkho2T9AL CqK6zDaRIcpbc6tltuc+tqPuPxuAmA6NI/9deqnAc2pWIv5lsCvQE0uVWX6v/RjYPz xa4Dvdb9x93Ow== Date: Fri, 6 Mar 2026 12:57:38 -0800 From: Jakub Kicinski To: Antonio Quartulli Cc: netdev@vger.kernel.org, Ralf Lici , Sabrina Dubroca , Paolo Abeni , Andrew Lunn , "David S. Miller" , Eric Dumazet , linux-kselftest@vger.kernel.org, shuah@kernel.org, horms@kernel.org Subject: Re: [PATCH net-next 5/9] selftests: ovpn: add notification parsing and matching Message-ID: <20260306125738.73a17bb4@kernel.org> In-Reply-To: References: <20260304230643.1014-1-antonio@openvpn.net> <20260304230643.1014-6-antonio@openvpn.net> <20260305191732.2bbc386b@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 6 Mar 2026 14:05:53 +0100 Antonio Quartulli wrote: > > There should probably be an else branch which prints some kind of > > echo "SKIP - requirements missing" > > > > Your requirements.py script prints stuff but the output needs to > > contain the word SKIP > > If "has_listener_requirements" is false, the test script still goes on, > but it won't check the received netlink notification content. > > So we're not really skipping the whole test, just one specific check > that requires extra tooling (which is normally found on all standard > distros). > > > Do you think we should rather SKIP the whole test so that we can easily > spot that something is missing? No strong preference. But speaking speaking just from the netdev CI perspective it's probably best to report SKIP and then keep going. The system does string matches on the output. If we report FAIL after the pass it will show as FAIL, if it's SKIP + PASS the report will be SKIP.