From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f202.google.com (mail-qk1-f202.google.com [209.85.222.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 447222459DD for ; Fri, 6 Mar 2026 13:32:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772803931; cv=none; b=IZqN2V1Hvq4Ilkqqzd6IBmqDXjg73C3Vqt+dCsvR5a8UtbeiH/JN34mqPP9q1GTwTue4TGloMy6w86wMu12s6sRKViolxd5sbMNvPPstN28DYbWNV2rFNV3yMc26QgQaJcthMCyd8+/T/4WBdl5OZ5UO4k+r5Xzt7k39v5oHmi4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772803931; c=relaxed/simple; bh=yglAOU9EoSizb5k31tzUSZH4Y6UBTD/3pT/iR9wOnVw=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=TqWFd0c8Y/ftwAw8uMlC/8WJQ8o4vizPp69Hjy0j/5yWef7+7V9wGrM02689vSdjA3CBlJ5nnJ0Unj+2Ncekb8tz3cMNq2SESbBBPaFxBXHGDFZUntWztejPm7o+lwsCMVXxIXcaj8f1AhpV9kC7/pwjqRcBj7DjbaCSzE2BFr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=CmkehRQ6; arc=none smtp.client-ip=209.85.222.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CmkehRQ6" Received: by mail-qk1-f202.google.com with SMTP id af79cd13be357-8cb5359e9d3so5542379785a.2 for ; Fri, 06 Mar 2026 05:32:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772803929; x=1773408729; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=C70vZFB5s1l7KkMHM++Ikt2rVAfRsUYTpLA6EyebqCE=; b=CmkehRQ6bnEKtqIenE0wK9HyLM8wfAVpmPWEn6mQAvHixBWTR7iYrjyf8ZElkS8y/q L45l4KWFEKkkdvt1aQoJmxQ3lZTiLvZ5EJDCfMQmSU35G01LwTaHYFnEbH1eqMDhvC6z tjUNMvuvxcuPgDAo5uz2PLK3/ZTrQh2pOU2YWNQxrGT6vkhIPEz5hge2C6+0IYHbJAht /zhvT5p1ihCj52qz2OttCFum5gYp/45d+QzBlPokAT6S47dKYPcamTGFg7L94K/lQiEr pZEkFjluCae4POy1cUGCHNigblHqcMFlESSQzvfGdkfymLwZySZJoK1dVcTDXpOp07+Y VHMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772803929; x=1773408729; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=C70vZFB5s1l7KkMHM++Ikt2rVAfRsUYTpLA6EyebqCE=; b=itiHRRjrdCx7fqRk71H4e4S+aLsZSF34C+rzbWsrf+bse97B9LQz1Nguel39Pv4a0v PKgvUOafxRosbJUcwEy3tLDXmoPxciGjvc+Tb4kaNmgwUC9Zfp9hdex3mPdavrAC34+D 1CSdJc61akDvaKBrxus5XNv3vQpR543xj6Fdw717Id3kOBUzSGEWOhM9hTHYToL6gveE +Of7sW/L4XK4gO5g9QvGgQPIyjfH309jTswblKT1nmL8ySeig+ZMqKpDXlSx5Fh7AmiO ESVziEphAlnlGZy7wgt/Hr+8fPVSiYByk1K51oBIYJLfDv7s8n4heME/K3vrOhhf9tor BqbQ== X-Forwarded-Encrypted: i=1; AJvYcCU05i3dVpDQIeTahTk2wLn9GKYzdEi8YX66otkB5GBnM+CenDB7rC9Nid9FXuHOLjVVBWHdjAk=@vger.kernel.org X-Gm-Message-State: AOJu0YyHjYaPkIimPefBfWaXk/HsIjO6m9cV3WrhxaGiZmSWeqZbzomz M61Neo1ZT9hen5sMibXW+9oHAkayAYNzqIVlZhLjHR6NHasP5B4qlbljqNARdvXVfjGNTEM3Esa FcOw3TLc62FZiJg== X-Received: from qkip25.prod.google.com ([2002:a05:620a:22f9:b0:8c7:cb6:2f03]) (user=edumazet job=prod-delivery.src-stubby-dispatcher) by 2002:a05:620a:3183:b0:8c6:a3ed:2f65 with SMTP id af79cd13be357-8cd6d386220mr254014285a.23.1772803928753; Fri, 06 Mar 2026 05:32:08 -0800 (PST) Date: Fri, 6 Mar 2026 13:31:54 +0000 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.53.0.473.g4a7958ca14-goog Message-ID: <20260306133154.678730-1-edumazet@google.com> Subject: [PATCH net-next] net/sched: use rtnl_kfree_skbs() in pfifo_fast_reset() From: Eric Dumazet To: "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , Jamal Hadi Salim , Jiri Pirko , netdev@vger.kernel.org, eric.dumazet@gmail.com, Eric Dumazet Content-Type: text/plain; charset="UTF-8" rtnl_kfree_skbs() reduces RTNL and qdisc spinlock hold time. skbs are freed later after RTNL has been released. Signed-off-by: Eric Dumazet --- net/sched/sch_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 55e17f9e5636f2d9e798889ff59b2f69c9c1709c..40e0d20ed0227ede4f1cb292613f1918c5a48f2c 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c @@ -850,7 +850,7 @@ static void pfifo_fast_reset(struct Qdisc *qdisc) continue; while ((skb = __skb_array_consume(q)) != NULL) - kfree_skb(skb); + rtnl_kfree_skbs(skb, skb); } if (qdisc_is_percpu_stats(qdisc)) { -- 2.53.0.473.g4a7958ca14-goog