public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, andrew+netdev@lunn.ch, corbet@lwn.net,
	skhan@linuxfoundation.org, workflows@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next] docs: netdev: refine netdevsim testing guidance
Date: Fri, 6 Mar 2026 14:39:03 +0000	[thread overview]
Message-ID: <20260306143903.GG461701@kernel.org> (raw)
In-Reply-To: <20260304151647.2770466-1-kuba@kernel.org>

On Wed, Mar 04, 2026 at 07:16:46AM -0800, Jakub Kicinski wrote:
> The library to create tests for both NIC HW and netdevsim has existed
> for almost a year. netdevsim-only tests we get increasingly feel like
> a waste, we should try to write tests that work both on netdevsim and
> real HW. Refine the guidance accordingly.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: corbet@lwn.net
> CC: skhan@linuxfoundation.org
> CC: workflows@vger.kernel.org
> CC: linux-doc@vger.kernel.org

Reviewed-by: Simon Horman <horms@kernel.org>

> ---
>  Documentation/process/maintainer-netdev.rst | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
> index 6bce4507d5d3..3aa13bc2405d 100644
> --- a/Documentation/process/maintainer-netdev.rst
> +++ b/Documentation/process/maintainer-netdev.rst
> @@ -479,8 +479,14 @@ netdevsim
>  
>  ``netdevsim`` is a test driver which can be used to exercise driver
>  configuration APIs without requiring capable hardware.
> -Mock-ups and tests based on ``netdevsim`` are strongly encouraged when
> -adding new APIs, but ``netdevsim`` in itself is **not** considered
> +Mock-ups and tests based on ``netdevsim`` are encouraged when
> +adding new APIs with complex logic in the stack. The tests should
> +be written so that they can run both against ``netdevsim`` and a real
> +device (see ``tools/testing/selftests/drivers/net/README.rst``).
> +``netdevsim``-only tests should focus on testing corner cases
> +and failure paths in the core which are hard to exercise with a real driver.
> +
> +``netdevsim`` in itself is **not** considered
>  a use case/user. You must also implement the new APIs in a real driver.

I don't know if it's desirable, but the line wrapping could
also be updated.

>  
>  We give no guarantees that ``netdevsim`` won't change in the future
> -- 
> 2.53.0
> 

  reply	other threads:[~2026-03-06 14:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04 15:16 [PATCH net-next] docs: netdev: refine netdevsim testing guidance Jakub Kicinski
2026-03-06 14:39 ` Simon Horman [this message]
2026-03-06 21:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260306143903.GG461701@kernel.org \
    --to=horms@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=skhan@linuxfoundation.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox