From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F95C1F16B for ; Fri, 6 Mar 2026 15:43:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772811806; cv=none; b=rsLUWF39pwS2AqZGIrugucxR3OAtmch9xj0zoW6DjaRKL2EqIEiWAfyxgXGQCQdbBaqr/jVBwkwFU8BbAmXqqfupj0R90hGrvuQqsfz/2n3nDAb+Ld6vR7F7oLV8bSmqqrziMW1tOkthpIO9i1xg6BzeNUVpPGhUWF6w7uKsVtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772811806; c=relaxed/simple; bh=Ag7VYELtAizJ3Ktu3lr0HPNTpWIrnBEwDc9r03+XSQI=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=KuHE1vZi4McTmr+hHRDmRIojIerKDKOabhZKGHcnUeG9n9XZZnlTkFRH25hz6zuuvJLRapazqk7O7h5NoWpXwvWd2lvrblG8i6iAHkKFSPwc4mSaXZd16SQQJYSy9XrR4sbuXcsEtqhlH0sCDFzAVB8vsN8r0MF4BjB4UYZYjF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=yhtnmbrZ; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="yhtnmbrZ" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-79878791ec6so148883417b3.3 for ; Fri, 06 Mar 2026 07:43:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772811804; x=1773416604; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=HyWlErDl4bVEU6bpo22F1kRA/Wy4PamUCZg+mcd+l3M=; b=yhtnmbrZDwn/8XDfhDCoYtlxojvxuarozZbwUG6Jhpp5EtFUj2sbGTfXy6aqRjDOBc hJjsIQ/d4NXDISAajakqLfEYhB1APcPhmgnUj/w88dlaJ+eGCmw13TQs10z01YSLmq8a CT/Vdu3J5M0jpzLptzKvIGRW006tuOmMJZZgQK69jYtMXoj3xHXBHEM+OWUf+Op9BuLb R6XjWRQBW6TGlv4D2MsFHlhXkjZ3VrPHI42j3WhCec2xj7kP3dTREUL6b2Xl3SySj1qA +sxBVeUWjUQXhDxv/YkRk7kDb3vn2ej2w95bXM/Wo74z8d+xERbhsnME+hK1xktZAH7p FeJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772811804; x=1773416604; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HyWlErDl4bVEU6bpo22F1kRA/Wy4PamUCZg+mcd+l3M=; b=N/RZzYw4UP1YBC2qVVJEQlI7zqekIrSl4L4zLBeGYcbO/rVlc7MaOpVK5xhjZpDmgg PfaLTswAX3Gc5wDxD2q9E1h8vsXRT0+qR5C0DYjxCncqRzicZREPb3TxsEHojC/qnXqc 0xvj2D9ZgPtFSOZEbrAk8O+pBxVrPwFDZ5FUX//RbZo2/RCBxrGC4k2GKq/3ZPTXCPXm hV7szYp67Xb34aFE38w/A4oBPe5dh8nrrwu47za38opTXUW4pSUUQRlImQ3xvU7VvY5r K6OsJoMDtMo1TRlEXqfR8oFAHWwKj+AmlnYYOkRcOFreYaosfnO3F3rfTrjf6uZyvnnn TqRA== X-Forwarded-Encrypted: i=1; AJvYcCUw7uW0msTZjfT+t7A4hSmliLbiJN+ueq+7rxsB6eEdhwh+wCypsyOmAjIBp9Jf0YFHXCFN0XQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyP3rrIZ9yCfwDW/fse9v1agU/R4n8kEBIO5z/D8eblnr0T9EHD uLeAYh2SYtSl47UjgT79Zdxs72VHyblVixuEQbm4nWjQd7JYGATEHa7eV2qqf+6zo9qVvJz3Btt jp14OYnfx+pGErA== X-Received: from ywbcc13.prod.google.com ([2002:a05:690c:94d:b0:795:2443:c4b9]) (user=edumazet job=prod-delivery.src-stubby-dispatcher) by 2002:a05:690c:d90:b0:794:f36a:c97 with SMTP id 00721157ae682-798dd799ce3mr22161987b3.55.1772811803753; Fri, 06 Mar 2026 07:43:23 -0800 (PST) Date: Fri, 6 Mar 2026 15:43:22 +0000 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.53.0.473.g4a7958ca14-goog Message-ID: <20260306154322.1086539-1-edumazet@google.com> Subject: [PATCH net-next] tcp: avoid dst->ops->check() call in tcp_v{4,6}_do_rcv() From: Eric Dumazet To: "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , Neal Cardwell , Kuniyuki Iwashima , netdev@vger.kernel.org, eric.dumazet@gmail.com, Eric Dumazet Content-Type: text/plain; charset="UTF-8" If incoming skb dst matches the socket cached one, there is no need to call again dst->ops->check(). Network layer already validated the skb dst for us, usually from tcp_v{4,6}_early_demux(). Signed-off-by: Eric Dumazet --- net/ipv4/tcp_ipv4.c | 2 +- net/ipv6/tcp_ipv6.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 190e8a238876d966822531c74f17b896181e359f..b8e0562f68d7a1d02a5bb8c3b0aa0fe3b574d0dc 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c @@ -1855,7 +1855,7 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb) sock_rps_save_rxhash(sk, skb); sk_mark_napi_id(sk, skb); - if (dst) { + if (dst && unlikely(dst != skb_dst(skb))) { if (sk->sk_rx_dst_ifindex != skb->skb_iif || !INDIRECT_CALL_1(dst->ops->check, ipv4_dst_check, dst, 0)) { diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index 164dceb842af767d93d0a2389564f543b2ba2fbf..074b83c9a551fafa52972a41506cdaf5299e24bd 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c @@ -1596,7 +1596,7 @@ int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb) sock_rps_save_rxhash(sk, skb); sk_mark_napi_id(sk, skb); - if (dst) { + if (dst && unlikely(dst != skb_dst(skb))) { if (sk->sk_rx_dst_ifindex != skb->skb_iif || INDIRECT_CALL_1(dst->ops->check, ip6_dst_check, dst, sk->sk_rx_dst_cookie) == NULL) { -- 2.53.0.473.g4a7958ca14-goog