From: Jakub Kicinski <kuba@kernel.org>
To: "Théo Lebrun" <theo.lebrun@bootlin.com>
Cc: "Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Benoît Monin" <benoit.monin@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Paolo Valerio" <pvalerio@redhat.com>
Subject: Re: [PATCH net-next 1/2] net: macb: implement ethtool_ops.get|set_channels()
Date: Fri, 6 Mar 2026 19:09:48 -0800 [thread overview]
Message-ID: <20260306190948.44d23f8f@kernel.org> (raw)
In-Reply-To: <20260305-macb-set-channels-v1-1-28e3a96a3dc3@bootlin.com>
On Thu, 05 Mar 2026 18:20:14 +0100 Théo Lebrun wrote:
> + if (!(bp->caps & MACB_CAPS_QUEUE_DISABLE))
> + return -EOPNOTSUPP;
Why not set max to 1 in this case?
> + if (!count || ch->rx_count || ch->tx_count)
> + return -EINVAL;
Core should check this for you already
> + if (count > bp->max_num_queues)
> + return -EINVAL;
and this
> + if (count == old_count)
> + return 0;
> +
> + if (running)
> + macb_close(bp->dev);
> +
> + bp->num_queues = count;
> + netif_set_real_num_queues(bp->dev, count, count);
> +
> + if (running) {
> + ret = macb_open(bp->dev);
> + if (ret) {
> + bp->num_queues = old_count;
> + netif_set_real_num_queues(bp->dev, old_count, old_count);
> + macb_open(bp->dev);
both macb_open() calls may fail under memory pressure
For new functionality we ask drivers to allocate all necessary
resources upfront then just swap them in and reconfigure HW
--
pw-bot: cr
next prev parent reply other threads:[~2026-03-07 3:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 17:20 [PATCH net-next 0/2] net: macb: implement ethtool set channels count operation Théo Lebrun
2026-03-05 17:20 ` [PATCH net-next 1/2] net: macb: implement ethtool_ops.get|set_channels() Théo Lebrun
2026-03-07 3:09 ` Jakub Kicinski [this message]
2026-03-09 17:04 ` Théo Lebrun
2026-03-09 21:15 ` Jakub Kicinski
2026-03-10 9:42 ` Théo Lebrun
2026-03-05 17:20 ` [PATCH net-next 2/2] net: macb: distribute evenly Tx SRAM segments Théo Lebrun
2026-03-07 3:07 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306190948.44d23f8f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=benoit.monin@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregory.clement@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=pvalerio@redhat.com \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox