From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E54B12741C9; Sat, 7 Mar 2026 01:18:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772846299; cv=none; b=HwOf6njRpahfpqXsjJUx12LaVmiKzHkkAR4b3jAbDSDqOkkOtyBQsUUeotkq8ahimdbIHfwgoOkbF5sV5tT65BQkUtPhUCPpgD2uFLxuiZC2uSkCtavGQ6RtaiYfvUY+80n91e5maOyzKPcHpqrfqzRy5K3lBZ8L933JzTrnLDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772846299; c=relaxed/simple; bh=dJPREhHEqg/9V2L2tTiRQa0B8jLxBb3+vg/KvKSJPGY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sB4nIJsboMyElTLH4qhJsX5Ytpb/OLMO0ucFlMKCEPfI87wxE639TBl7tbiLuAvhUCazwSJ+Lc/AZWjhcXXV+iQTlFW/KNXqKi1xJbyu7FVTkg/Ups//jO9N5RxvUetuW82/C+L/FuKWcIlA7DBxHb+14DzPlvG3OtR+G8cJ1S4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LmbOQbHi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LmbOQbHi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B4B1C4CEF7; Sat, 7 Mar 2026 01:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772846298; bh=dJPREhHEqg/9V2L2tTiRQa0B8jLxBb3+vg/KvKSJPGY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LmbOQbHixDQ6h++Bt1C3KQ5nfFZHrIIaICcOWfrcdBj3bEyip5Wa6dmaK2kzQdsNY NZtG3Hbrrk5g/wgJRnE81ylaUpV4Lco0hrQ84n0OZy9FXM28Fx1QCeyTzZcj4gpI2B 6eUggfJpH1qXdiRGU89O4AMomTBz70uSruKwsI+KqUMjYYkVdqtGww10xQ5ffb47Pq jhI68Oa0WG8Q3kZr7X7buSmJiZqncbN5yRj3owUR2XJDjDaUHLYuVoN04ez8I58dAf kHsC6aj3s6ZZaKATtdtC6fWRjo9v347eZT+LrXdvrzsVj+ukSgHPfDUeCOFzfv4oO8 RMEsvEOl8loow== From: Jakub Kicinski To: rosenp@gmail.com Cc: Jakub Kicinski , netdev@vger.kernel.org, andrew+netdev@lunn.ch, linux-kernel@vger.kernel.org (open list), edumazet@google.com, davem@davemloft.net, pabeni@redhat.com, marcin.s.wojtas@gmail.com Subject: Re: [net-next] net: mvneta: fix NVMEM mac address Date: Fri, 6 Mar 2026 17:18:16 -0800 Message-ID: <20260307011816.1223696-1-kuba@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260305224643.14524-1-rosenp@gmail.com> References: <20260305224643.14524-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- net: mvneta: fix NVMEM mac address This commit adds handling for EPROBE_DEFER from of_get_ethdev_address() to avoid falling back to a random MAC address when the NVMEM module loads after the ethernet driver. > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > index 9ba4aef7080c..18bc13dd4e58 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/drivers/net/ethernet/marvell/mvneta.c > @@ -5620,6 +5620,8 @@ static int mvneta_probe(struct platform_device *pdev) > } > > err = of_get_ethdev_address(dn, dev); > + if (err == -EPROBE_DEFER) > + goto err_free_ports; Does this leak the per-CPU stats? Earlier in mvneta_probe(), stats are allocated: pp->stats = netdev_alloc_pcpu_stats(struct mvneta_pcpu_stats); if (!pp->stats) { err = -ENOMEM; goto err_free_ports; } err = of_get_ethdev_address(dn, dev); When of_get_ethdev_address() returns -EPROBE_DEFER, this code jumps to err_free_ports which only frees pp->ports but not pp->stats. The err_free_ports label only calls free_percpu(pp->ports) and does not free pp->stats. Stats are only freed at the err_netdev label which is skipped by this error path. This causes a memory leak on every deferred probe attempt when NVMEM loads after the ethernet driver. > if (!err) { > mac_from = "device tree"; > } else { -- pw-bot: cr