public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCHv2 net-next] net: mvneta: support EPROBE_DEFER when reading MAC address
@ 2026-03-07  3:17 Rosen Penev
  2026-03-10 16:30 ` Simon Horman
  2026-03-11  2:40 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Rosen Penev @ 2026-03-07  3:17 UTC (permalink / raw)
  To: netdev
  Cc: Marcin Wojtas, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, open list

If nvmem loads after the ethernet driver, mac address assignments will
not take effect. of_get_ethdev_address returns EPROBE_DEFER in such a
case so we need to handle that to avoid eth_hw_addr_random.

Add extra goto section to just free stats as they are allocated right
above.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 v2: free stats on probe defer.
 drivers/net/ethernet/marvell/mvneta.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index d627858d2802..5bdf5020ec69 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -5620,6 +5620,8 @@ static int mvneta_probe(struct platform_device *pdev)
 	}

 	err = of_get_ethdev_address(dn, dev);
+	if (err == -EPROBE_DEFER)
+		goto err_free_stats;
 	if (!err) {
 		mac_from = "device tree";
 	} else {
@@ -5755,6 +5757,7 @@ static int mvneta_probe(struct platform_device *pdev)
 				       1 << pp->id);
 		mvneta_bm_put(pp->bm_priv);
 	}
+err_free_stats:
 	free_percpu(pp->stats);
 err_free_ports:
 	free_percpu(pp->ports);
--
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCHv2 net-next] net: mvneta: support EPROBE_DEFER when reading MAC address
  2026-03-07  3:17 [PATCHv2 net-next] net: mvneta: support EPROBE_DEFER when reading MAC address Rosen Penev
@ 2026-03-10 16:30 ` Simon Horman
  2026-03-11  2:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2026-03-10 16:30 UTC (permalink / raw)
  To: Rosen Penev
  Cc: netdev, Marcin Wojtas, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, open list

On Fri, Mar 06, 2026 at 07:17:09PM -0800, Rosen Penev wrote:
> If nvmem loads after the ethernet driver, mac address assignments will
> not take effect. of_get_ethdev_address returns EPROBE_DEFER in such a
> case so we need to handle that to avoid eth_hw_addr_random.
> 
> Add extra goto section to just free stats as they are allocated right
> above.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  v2: free stats on probe defer.

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCHv2 net-next] net: mvneta: support EPROBE_DEFER when reading MAC address
  2026-03-07  3:17 [PATCHv2 net-next] net: mvneta: support EPROBE_DEFER when reading MAC address Rosen Penev
  2026-03-10 16:30 ` Simon Horman
@ 2026-03-11  2:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-03-11  2:40 UTC (permalink / raw)
  To: Rosen Penev
  Cc: netdev, marcin.s.wojtas, andrew+netdev, davem, edumazet, kuba,
	pabeni, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri,  6 Mar 2026 19:17:09 -0800 you wrote:
> If nvmem loads after the ethernet driver, mac address assignments will
> not take effect. of_get_ethdev_address returns EPROBE_DEFER in such a
> case so we need to handle that to avoid eth_hw_addr_random.
> 
> Add extra goto section to just free stats as they are allocated right
> above.
> 
> [...]

Here is the summary with links:
  - [PATCHv2,net-next] net: mvneta: support EPROBE_DEFER when reading MAC address
    https://git.kernel.org/netdev/net-next/c/73a864352570

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-11  2:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-07  3:17 [PATCHv2 net-next] net: mvneta: support EPROBE_DEFER when reading MAC address Rosen Penev
2026-03-10 16:30 ` Simon Horman
2026-03-11  2:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox