Re: [PATCH net-next 1/2] amd-xgbe: Simplify powerdown/powerup paths

[kernel test robot <lkp@intel.com>]

Hi Raju,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Raju-Rangoju/amd-xgbe-Simplify-powerdown-powerup-paths/20260306-202410
base:   net-next/main
patch link:    https://lore.kernel.org/r/20260306121047.1231755-2-Raju.Rangoju%40amd.com
patch subject: [PATCH net-next 1/2] amd-xgbe: Simplify powerdown/powerup paths
config: sparc-randconfig-001-20260307 (https://download.01.org/0day-ci/archive/20260307/202603070918.CSq5IR0g-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260307/202603070918.CSq5IR0g-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603070918.CSq5IR0g-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/amd/xgbe/xgbe-pci.c:379:12: warning: 'xgbe_pci_resume' defined but not used [-Wunused-function]
     379 | static int xgbe_pci_resume(struct device *dev)
         |            ^~~~~~~~~~~~~~~
>> drivers/net/ethernet/amd/xgbe/xgbe-pci.c:363:12: warning: 'xgbe_pci_suspend' defined but not used [-Wunused-function]
     363 | static int xgbe_pci_suspend(struct device *dev)
         |            ^~~~~~~~~~~~~~~~


vim +/xgbe_pci_resume +379 drivers/net/ethernet/amd/xgbe/xgbe-pci.c

   362	
 > 363	static int xgbe_pci_suspend(struct device *dev)
   364	{
   365		struct xgbe_prv_data *pdata = dev_get_drvdata(dev);
   366		struct net_device *netdev = pdata->netdev;
   367		int ret = 0;
   368	
   369		if (netif_running(netdev))
   370			ret = xgbe_powerdown(netdev);
   371	
   372		pdata->lpm_ctrl = XMDIO_READ(pdata, MDIO_MMD_PCS, MDIO_CTRL1);
   373		pdata->lpm_ctrl |= MDIO_CTRL1_LPOWER;
   374		XMDIO_WRITE(pdata, MDIO_MMD_PCS, MDIO_CTRL1, pdata->lpm_ctrl);
   375	
   376		return ret;
   377	}
   378	
 > 379	static int xgbe_pci_resume(struct device *dev)
   380	{
   381		struct xgbe_prv_data *pdata = dev_get_drvdata(dev);
   382		struct net_device *netdev = pdata->netdev;
   383		int ret = 0;
   384	
   385		XP_IOWRITE(pdata, XP_INT_EN, 0x1fffff);
   386	
   387		pdata->lpm_ctrl &= ~MDIO_CTRL1_LPOWER;
   388		XMDIO_WRITE(pdata, MDIO_MMD_PCS, MDIO_CTRL1, pdata->lpm_ctrl);
   389	
   390		if (netif_running(netdev)) {
   391			ret = xgbe_powerup(netdev);
   392	
   393			/* Schedule a restart in case the link or phy state changed
   394			 * while we were powered down.
   395			 */
   396			schedule_work(&pdata->restart_work);
   397		}
   398	
   399		return ret;
   400	}
   401	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki