From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE11D30595B for ; Sat, 7 Mar 2026 09:22:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772875339; cv=none; b=oKH8C4ZgLS5ycF4hS6dMIQB8gd9iG6rYhl3B9/dbuNdu814vmJlDBV7WLhdn8Z5zv6OjJzDT/mwJAYSpujcoXjLYmnpdlWHJd1bnTwxI8Z0qFFT6HWuvU5zk11pbndLnAzb2hTyejJKf8/ivfxWsRNW/jcL5nWC/qjZmpC3u3nU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772875339; c=relaxed/simple; bh=RLuf0BWPmBmgE3OCwKI148eNby71BqdruVzZ8uESdto=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=jizDJrKKj1Mhe3LbLdqxMvlXWIePE0xDAfNH2lXD00b71+7obk163uMmpEy/Uqi61U74MObAkIYV0ibRxxsqLAH8+9VDJJaC1g403yWNw/v8Oa7pk86h9CDzDAy14DdHknP1nCkOJneqvZIJTCoeL2jBiDFhQWtOUpBo33Kcn6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=4eeIcNEM; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="4eeIcNEM" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-79881805767so117174557b3.3 for ; Sat, 07 Mar 2026 01:22:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772875337; x=1773480137; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=boljEDKAW+CRCitfA07JSzymSe3HqQTSV5hrgqY/gb8=; b=4eeIcNEMbz5cbXKtV4hsNgSMOF8nVV6UP7wODJNgE0LFSu41yNQLOnLUbpsWTEElFd tNM6G9Hr/2rObgpQe+VI5wADuutaMewDLOy6v8VjwZqxaK4Oix0TyzTjc0Dpzcfn5U4i HxjLWoeg2WzbOK44MA+eS9Fd4/C/tzy1a5QdZ+HJNO784v2IHsjn46Hy9mqFnMXHdJgC r+rh7VQfywOcpbfmGeLKdTni2krtvLvok/CtvQFbJh0BtpopYT0lKNKLYE1LDcwcVUmP VztMNGs03VQgtysipD9jv5UNGf0xewZvmQH1eJhG18yoqlHDA/ZHPd9zfknq/MTV6pgT cufA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772875337; x=1773480137; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=boljEDKAW+CRCitfA07JSzymSe3HqQTSV5hrgqY/gb8=; b=HAGs19u1YaDnDXRAeJExgM4RY/RyRtN9vBgLj1s0QHS+WazO4T+qVbULpF8o3dC8kc E4lk379Xsi07aG9PUWriPNLTJRNzV5uIp+NeYMYpIffCM3bl4GXD54kW0RDqHM3N4fkj zMP+QLCLI7cyePyakBobwuV2/pAWIKwgVGd3JDDGDpxUfIznpa+C3OUM9YuJWOpOUxT6 6f3LbjROgqwsYZbRz13iGVhHt0uF+TgokFnJgMphc3Z6rexTKJFPrhbkTfwhWwBnBC5N PSZNGILAZg+o+jgxAWhCj6uSPk3p6dGSYaS5C4Re3lbQxSc1KRBIjtvom285Y4L1gFRP lfZg== X-Forwarded-Encrypted: i=1; AJvYcCVEAvulF1M/JOXB3gmFpRgjq5sP7IFfP3OdLP17+UVgPXNdX1PeQeNEjTJr6dyu2+XP4OO21Js=@vger.kernel.org X-Gm-Message-State: AOJu0YxSo37BIny0hwQ6lWQ+QqoQ0xsY5luLfop2U5MZ+jm4YhuBYD1F 15cR2azRHL46dWwHGwHrDfcNASKt9brCZ6Oe77n78KV/vuZsIRvPEWbFyvSq5YpmsdkTR1VT5XM H26g9DHvjedwDaQ== X-Received: from ywah17.prod.google.com ([2002:a05:690c:c011:b0:798:6b80:4165]) (user=edumazet job=prod-delivery.src-stubby-dispatcher) by 2002:a05:690c:6e86:b0:797:d37d:d5a1 with SMTP id 00721157ae682-798dd7c6bb0mr45157047b3.61.1772875336648; Sat, 07 Mar 2026 01:22:16 -0800 (PST) Date: Sat, 7 Mar 2026 09:22:14 +0000 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.53.0.473.g4a7958ca14-goog Message-ID: <20260307092214.2433548-1-edumazet@google.com> Subject: [PATCH net-next] tcp: move sysctl_tcp_shrink_window to netns_ipv4_read_txrx group From: Eric Dumazet To: "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , Neal Cardwell , Kuniyuki Iwashima , netdev@vger.kernel.org, eric.dumazet@gmail.com, Eric Dumazet Content-Type: text/plain; charset="UTF-8" Commit 18fd64d25422 ("netns-ipv4: reorganize netns_ipv4 fast path variables") missed that __tcp_select_window() is reading net->ipv4.sysctl_tcp_shrink_window. Move this field to netns_ipv4_read_txrx group, as __tcp_select_window() is used both in tx and rx paths. Saves a potential cache line miss. Signed-off-by: Eric Dumazet --- include/net/netns/ipv4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/netns/ipv4.h b/include/net/netns/ipv4.h index 4c249aeaf7f12f8237232a6f3d3f3ed56d0a53d4..38624beff9b34161327d7549fcd0f041c9c91679 100644 --- a/include/net/netns/ipv4.h +++ b/include/net/netns/ipv4.h @@ -74,6 +74,7 @@ struct netns_ipv4 { /* TXRX readonly hotpath cache lines */ __cacheline_group_begin(netns_ipv4_read_txrx); + u8 sysctl_tcp_shrink_window; __cacheline_group_end(netns_ipv4_read_txrx); /* RX readonly hotpath cache line */ @@ -122,7 +123,6 @@ struct netns_ipv4 { #endif bool fib_has_custom_local_routes; bool fib_offload_disabled; - u8 sysctl_tcp_shrink_window; #ifdef CONFIG_IP_ROUTE_CLASSID atomic_t fib_num_tclassid_users; #endif -- 2.53.0.473.g4a7958ca14-goog