From: Kohei Enju <kohei@enjuk.jp>
To: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kohei.enju@gmail.com, Kohei Enju <kohei@enjuk.jp>
Subject: [PATCH iwl-next v1 1/2] igc: set RX hardware timestamps in igc_build_skb()
Date: Sat, 7 Mar 2026 18:27:38 +0000 [thread overview]
Message-ID: <20260307182808.155027-2-kohei@enjuk.jp> (raw)
In-Reply-To: <20260307182808.155027-1-kohei@enjuk.jp>
igc_construct_skb() sets RX hardware timestamps, but igc_build_skb()
does not. This has not been observable so far since igc currently does
not enable the build_skb RX path.
Set RX hardware timestamps in igc_build_skb() as well so that both skb
construction paths provide the same behavior.
Signed-off-by: Kohei Enju <kohei@enjuk.jp>
---
drivers/net/ethernet/intel/igc/igc_main.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index ebd831a4ff53..3a4c1ebe4faa 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -1964,13 +1964,16 @@ static void igc_add_rx_frag(struct igc_ring *rx_ring,
static struct sk_buff *igc_build_skb(struct igc_ring *rx_ring,
struct igc_rx_buffer *rx_buffer,
- struct xdp_buff *xdp)
+ struct igc_xdp_buff *ctx)
{
- unsigned int size = xdp->data_end - xdp->data;
- unsigned int truesize = igc_get_rx_frame_truesize(rx_ring, size);
- unsigned int metasize = xdp->data - xdp->data_meta;
+ unsigned int size, truesize, metasize;
+ struct xdp_buff *xdp = &ctx->xdp;
struct sk_buff *skb;
+ size = xdp->data_end - xdp->data;
+ truesize = igc_get_rx_frame_truesize(rx_ring, size);
+ metasize = xdp->data - xdp->data_meta;
+
/* prefetch first cache line of first page */
net_prefetch(xdp->data_meta);
@@ -1979,6 +1982,11 @@ static struct sk_buff *igc_build_skb(struct igc_ring *rx_ring,
if (unlikely(!skb))
return NULL;
+ if (ctx->rx_ts) {
+ skb_shinfo(skb)->tx_flags |= SKBTX_HW_TSTAMP_NETDEV;
+ skb_hwtstamps(skb)->netdev_data = ctx->rx_ts;
+ }
+
/* update pointers within the skb to store the data */
skb_reserve(skb, xdp->data - xdp->data_hard_start);
__skb_put(skb, size);
@@ -2681,7 +2689,7 @@ static int igc_clean_rx_irq(struct igc_q_vector *q_vector, const int budget)
} else if (skb)
igc_add_rx_frag(rx_ring, rx_buffer, skb, size);
else if (ring_uses_build_skb(rx_ring))
- skb = igc_build_skb(rx_ring, rx_buffer, &ctx.xdp);
+ skb = igc_build_skb(rx_ring, rx_buffer, &ctx);
else
skb = igc_construct_skb(rx_ring, rx_buffer, &ctx);
--
2.51.0
next prev parent reply other threads:[~2026-03-07 19:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 18:27 [PATCH iwl-next v1 0/2] igc: enable build_skb path Kohei Enju
2026-03-07 18:27 ` Kohei Enju [this message]
2026-03-10 7:43 ` [Intel-wired-lan] [PATCH iwl-next v1 1/2] igc: set RX hardware timestamps in igc_build_skb() Loktionov, Aleksandr
2026-03-15 13:56 ` Ruinskiy, Dima
2026-03-15 14:09 ` Kohei Enju
2026-03-07 18:27 ` [PATCH iwl-next v1 2/2] igc: enable build_skb on the non-XDP small-frame RX path Kohei Enju
2026-03-10 7:44 ` [Intel-wired-lan] " Loktionov, Aleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260307182808.155027-2-kohei@enjuk.jp \
--to=kohei@enjuk.jp \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kohei.enju@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox