From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, hawk@kernel.org,
ilias.apalodimas@linaro.org
Subject: Re: [PATCH net] page_pool: store detach_time as ktime_t to avoid false-negatives
Date: Sun, 8 Mar 2026 09:21:35 -0700 [thread overview]
Message-ID: <20260308092135.021c2bf0@kernel.org> (raw)
In-Reply-To: <CANn89iKaWRQfSPXc+nqAhz8Zj-Yh+kohPdOvFw-fzNkWTW1TXg@mail.gmail.com>
On Sun, 8 Mar 2026 01:10:55 +0100 Eric Dumazet wrote:
> > --- a/net/core/page_pool_user.c
> > +++ b/net/core/page_pool_user.c
> > @@ -245,7 +245,7 @@ page_pool_nl_fill(struct sk_buff *rsp, const struct page_pool *pool,
> > goto err_cancel;
>
> It is a bit unclear if we always hold page_pools_lock at this point.
>
> If not, a READ_ONCE(pool->user.detach_time) here would be needed,
> and a corresponding WRITE_ONCE() in page_pool_detached()
There's a bit of convoluted wrapping to share the code between page
pool access and access to stats, but AFAICT page_pools_lock should
be consistently held by readers and writers.
next prev parent reply other threads:[~2026-03-08 16:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 20:40 [PATCH net] page_pool: store detach_time as ktime_t to avoid false-negatives Jakub Kicinski
2026-03-08 0:10 ` Eric Dumazet
2026-03-08 16:21 ` Jakub Kicinski [this message]
2026-03-08 4:54 ` kernel test robot
2026-03-08 5:05 ` kernel test robot
2026-03-08 5:06 ` kernel test robot
2026-03-08 5:17 ` kernel test robot
2026-03-09 9:42 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260308092135.021c2bf0@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox