public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: irving.ch.lin <irving-ch.lin@mediatek.com>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Richard Cochran <richardcochran@gmail.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Chen-Yu Tsai <wenst@chromium.org>,
	Miles Chen <miles.chen@mediatek.com>
Cc: <linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>, <netdev@vger.kernel.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	Qiqi Wang <qiqi.wang@mediatek.com>, <sirius.wang@mediatek.com>,
	<vince-wl.liu@mediatek.com>, <jh.hsu@mediatek.com>,
	<irving-ch.lin@mediatek.com>
Subject: [PATCH v6 02/18] clk: mediatek: clk-mux: Make sure bypass clk enabled while setting MFG rate
Date: Mon, 9 Mar 2026 20:04:44 +0800	[thread overview]
Message-ID: <20260309120512.3624804-3-irving-ch.lin@mediatek.com> (raw)
In-Reply-To: <20260309120512.3624804-1-irving-ch.lin@mediatek.com>

From: Irving-CH Lin <irving-ch.lin@mediatek.com>

Enable bypass clock before MFG changing rate, to make sure
MFG reference clock available during transient.

Fixes: b66add7a74e8 ("clk: mediatek: mux: add clk notifier functions")
Signed-off-by: Irving-CH Lin <irving-ch.lin@mediatek.com>
---
 drivers/clk/mediatek/clk-mux.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/mediatek/clk-mux.c b/drivers/clk/mediatek/clk-mux.c
index 5f4b07e7c757..574e35a42115 100644
--- a/drivers/clk/mediatek/clk-mux.c
+++ b/drivers/clk/mediatek/clk-mux.c
@@ -414,16 +414,21 @@ static int mtk_clk_mux_notifier_cb(struct notifier_block *nb,
 	struct clk_notifier_data *data = _data;
 	struct clk_hw *hw = __clk_get_hw(data->clk);
 	struct mtk_mux_nb *mux_nb = to_mtk_mux_nb(nb);
+	struct clk_hw *p_hw = clk_hw_get_parent_by_index(hw, mux_nb->bypass_index);
 	int ret = 0;
 
 	switch (event) {
 	case PRE_RATE_CHANGE:
-		mux_nb->original_index = mux_nb->ops->get_parent(hw);
-		ret = mux_nb->ops->set_parent(hw, mux_nb->bypass_index);
+		ret = clk_prepare_enable(p_hw->clk);
+		if (ret == 0) {
+			mux_nb->original_index = mux_nb->ops->get_parent(hw);
+			ret = mux_nb->ops->set_parent(hw, mux_nb->bypass_index);
+		}
 		break;
 	case POST_RATE_CHANGE:
 	case ABORT_RATE_CHANGE:
 		ret = mux_nb->ops->set_parent(hw, mux_nb->original_index);
+		clk_disable_unprepare(p_hw->clk);
 		break;
 	}
 
-- 
2.45.2


  parent reply	other threads:[~2026-03-09 12:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 12:04 [PATCH v6 00/18] Add support for MT8189 clock controller irving.ch.lin
2026-03-09 12:04 ` [PATCH v6 01/18] dt-bindings: clock: Add MediaTek MT8189 clock irving.ch.lin
2026-03-10  7:38   ` Krzysztof Kozlowski
2026-03-12 20:06   ` David Lechner
2026-03-09 12:04 ` irving.ch.lin [this message]
2026-03-09 12:04 ` [PATCH v6 03/18] clk: mediatek: Add MT8189 apmixedsys clock support irving.ch.lin
2026-03-12 20:06   ` David Lechner
2026-03-09 12:04 ` [PATCH v6 04/18] clk: mediatek: Add MT8189 topckgen " irving.ch.lin
2026-03-09 12:04 ` [PATCH v6 05/18] clk: mediatek: Add MT8189 vlpckgen " irving.ch.lin
2026-03-09 12:04 ` [PATCH v6 06/18] clk: mediatek: Add MT8189 vlpcfg " irving.ch.lin
2026-03-09 12:04 ` [PATCH v6 07/18] clk: mediatek: Add MT8189 bus " irving.ch.lin
2026-03-09 12:04 ` [PATCH v6 08/18] clk: mediatek: Add MT8189 cam " irving.ch.lin
2026-03-09 12:04 ` [PATCH v6 09/18] clk: mediatek: Add MT8189 dbgao " irving.ch.lin
2026-03-09 12:04 ` [PATCH v6 10/18] clk: mediatek: Add MT8189 dvfsrc " irving.ch.lin
2026-03-09 12:04 ` [PATCH v6 11/18] clk: mediatek: Add MT8189 i2c " irving.ch.lin
2026-03-09 12:04 ` [PATCH v6 12/18] clk: mediatek: Add MT8189 img " irving.ch.lin
2026-03-09 12:04 ` [PATCH v6 13/18] clk: mediatek: Add MT8189 mdp " irving.ch.lin
2026-03-09 12:04 ` [PATCH v6 14/18] clk: mediatek: Add MT8189 mfg " irving.ch.lin
2026-03-09 12:04 ` [PATCH v6 15/18] clk: mediatek: Add MT8189 dispsys " irving.ch.lin
2026-03-12 20:06   ` David Lechner
2026-03-09 12:04 ` [PATCH v6 16/18] clk: mediatek: Add MT8189 scp " irving.ch.lin
2026-03-09 12:04 ` [PATCH v6 17/18] clk: mediatek: Add MT8189 ufs " irving.ch.lin
2026-03-09 12:05 ` [PATCH v6 18/18] clk: mediatek: Add MT8189 vcodec " irving.ch.lin
2026-03-12 20:06 ` [PATCH v6 00/18] Add support for MT8189 clock controller David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309120512.3624804-3-irving-ch.lin@mediatek.com \
    --to=irving-ch.lin@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jh.hsu@mediatek.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=miles.chen@mediatek.com \
    --cc=mturquette@baylibre.com \
    --cc=netdev@vger.kernel.org \
    --cc=qiqi.wang@mediatek.com \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sirius.wang@mediatek.com \
    --cc=vince-wl.liu@mediatek.com \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox