public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Wei Wang <weibunny.kernel@gmail.com>
Cc: netdev@vger.kernel.org, Daniel Zahka <daniel.zahka@gmail.com>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	David Wei <dw@davidwei.uk>, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Wei Wang <weibunny@fb.com>
Subject: Re: [PATCH v3 net-next 5/5] selftest/net: psp: Add test for dev-assoc/disassoc
Date: Mon, 9 Mar 2026 16:38:59 -0700	[thread overview]
Message-ID: <20260309163859.382968a0@kernel.org> (raw)
In-Reply-To: <20260309183454.2872967-6-weibunny.kernel@gmail.com>

On Mon,  9 Mar 2026 11:34:53 -0700 Wei Wang wrote:
> -    with NetDrvEpEnv(__file__) as cfg:
> +    # Use a different prefix for netkit guest to avoid conflict with dev prefix
> +    nk_v6_pfx = "2001:db9::"
> +
> +    # Set LOCAL_PREFIX_V6 to a DIFFERENT prefix than the dev prefix to avoid BPF
> +    # redirecting psp_responder traffic. The BPF only redirects traffic
> +    # matching LOCAL_PREFIX_V6, so dev traffic (2001:db8::) won't be affected.
> +    if "LOCAL_PREFIX_V6" not in os.environ:
> +        os.environ["LOCAL_PREFIX_V6"] = nk_v6_pfx
> +
> +    with NetDrvContEnv(__file__, install_tx_redirect_bpf=True) as cfg:

NETKIT needs to be added to the driver/net's config (it's only in
drivers/net/hw/config now)

Can we also add some code to handle NetDrvContEnv() creation failing
and falling back to NetDrvEpEnv() ? Skipping just the test cases
that need cont?

Last but not least let's use variants instead of the test builder?
-- 
pw-bot: cr

  reply	other threads:[~2026-03-09 23:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 18:34 [PATCH v3 net-next 0/5] psp: Add support for dev-assoc/disassoc Wei Wang
2026-03-09 18:34 ` [PATCH v3 net-next 1/5] psp: add admin/non-admin version of psp_device_get_locked Wei Wang
2026-03-09 18:34 ` [PATCH v3 net-next 2/5] psp: add new netlink cmd for dev-assoc and dev-disassoc Wei Wang
2026-03-10  2:26   ` Bobby Eshleman
2026-03-10 16:38     ` Wei Wang
2026-03-10 14:25   ` Daniel Zahka
2026-03-10 17:03     ` Wei Wang
2026-03-10 15:08   ` Daniel Zahka
2026-03-10 19:42     ` Wei Wang
2026-03-09 18:34 ` [PATCH v3 net-next 3/5] psp: add a new netdev event for dev unregister Wei Wang
2026-03-10  0:37   ` Willem de Bruijn
2026-03-10 20:45     ` Wei Wang
2026-03-09 18:34 ` [PATCH v3 net-next 4/5] selftests/net: Add bpf skb forwarding program Wei Wang
2026-03-09 18:34 ` [PATCH v3 net-next 5/5] selftest/net: psp: Add test for dev-assoc/disassoc Wei Wang
2026-03-09 23:38   ` Jakub Kicinski [this message]
2026-03-10 20:46     ` Wei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309163859.382968a0@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=daniel.zahka@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dw@davidwei.uk \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=weibunny.kernel@gmail.com \
    --cc=weibunny@fb.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox