From: Jakub Kicinski <kuba@kernel.org>
To: Chuck Lever <cel@kernel.org>
Cc: john.fastabend@gmail.com, sd@queasysnail.net,
<netdev@vger.kernel.org>, <kernel-tls-handshake@lists.linux.dev>,
Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH v1 0/6] TLS read_sock performance scalability
Date: Mon, 9 Mar 2026 20:14:47 -0700 [thread overview]
Message-ID: <20260309201447.56dbb14f@kernel.org> (raw)
In-Reply-To: <20260305211402.39408-1-cel@kernel.org>
On Thu, 5 Mar 2026 16:13:56 -0500 Chuck Lever wrote:
> I'd like to encourage in-kernel kTLS consumers (i.e., NFS and
> NVMe/TCP) to coalesce on the use of read_sock. When I suggested
> this to Hannes, he reported a number of nagging performance
> scalability issues with read_sock. This series is an attempt to
> run these issues down and get them fixed before we convert the
> above sock_recvmsg consumers over to read_sock.
This series seems to be lacking polish:
- every patch which complicates the codebase should come with clear
characterization of the perf win
- increasing duplication / copy paste between recv and read sock paths
- wouldn't the data_ready suppression equally apply to the recvmsg
path?
prev parent reply other threads:[~2026-03-10 3:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 21:13 [PATCH v1 0/6] TLS read_sock performance scalability Chuck Lever
2026-03-05 21:13 ` [PATCH v1 1/6] tls: Fix dangling skb pointer in tls_sw_read_sock() Chuck Lever
2026-03-05 22:19 ` Jakub Kicinski
2026-03-06 14:33 ` Chuck Lever
2026-03-05 21:13 ` [PATCH v1 2/6] tls: Factor tls_strp_msg_release() from tls_strp_msg_done() Chuck Lever
2026-03-05 21:13 ` [PATCH v1 3/6] tls: Suppress spurious saved_data_ready during read_sock Chuck Lever
2026-03-05 21:14 ` [PATCH v1 4/6] tls: Flush backlog before tls_rx_rec_wait in read_sock Chuck Lever
2026-03-05 21:14 ` [PATCH v1 5/6] tls: Restructure tls_sw_read_sock() into submit/deliver phases Chuck Lever
2026-03-05 21:14 ` [PATCH v1 6/6] tls: Enable batch async decryption in read_sock Chuck Lever
2026-03-10 3:14 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309201447.56dbb14f@kernel.org \
--to=kuba@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=john.fastabend@gmail.com \
--cc=kernel-tls-handshake@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox