* [PATCH v1 1/8] soc: qcom: qmi: Enumerate the service IDs of QMI
2026-03-09 23:03 [PATCH v1 0/8] Group QMI service IDs into the QMI header Daniel Lezcano
@ 2026-03-09 23:03 ` Daniel Lezcano
2026-03-10 0:04 ` Dmitry Baryshkov
2026-03-10 9:57 ` Konrad Dybcio
2026-03-09 23:03 ` [PATCH v1 2/8] net: ipa: Use the unified QMI service ID instead of defining it locally Daniel Lezcano
` (10 subsequent siblings)
11 siblings, 2 replies; 28+ messages in thread
From: Daniel Lezcano @ 2026-03-09 23:03 UTC (permalink / raw)
To: konradybcio, andersson
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
The QMI framework proposes a set of services which are defined by an
integer identifier. The different QMI client lookup for the services
via this identifier. Moreover, the function qmi_add_lookup() and
qmi_add_server() must match the service ID but the code in different
places set the same value but with a different macro name. These
macros are spreaded across the different subsystems implementing the
protocols associated with a service. It would make more sense to
define them in the QMI header for the sake of consistency and clarity.
This change use an unified naming for the services and enumerate the
ones implemented in the Linux kernel. More services can come later and
put the service ID in this same header.
Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
---
include/linux/soc/qcom/qmi.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/include/linux/soc/qcom/qmi.h b/include/linux/soc/qcom/qmi.h
index 291cdc7ef49c..b8d07f2c07e7 100644
--- a/include/linux/soc/qcom/qmi.h
+++ b/include/linux/soc/qcom/qmi.h
@@ -92,6 +92,18 @@ struct qmi_elem_info {
#define QMI_ERR_INCOMPATIBLE_STATE_V01 90
#define QMI_ERR_NOT_SUPPORTED_V01 94
+/*
+ * Enumerate the IDs of the QMI services
+ */
+#define QMI_SERVICE_ID_TEST 0x0F /* 15 */
+#define QMI_SERVICE_ID_SSCTL 0x2B /* 43 */
+#define QMI_SERVICE_ID_IPA 0x31 /* 49 */
+#define QMI_SERVICE_ID_SERVREG_LOC 0x40 /* 64 */
+#define QMI_SERVICE_ID_SERVREG_NOTIF 0x42 /* 66 */
+#define QMI_SERVICE_ID_WLFW 0x45 /* 69 */
+#define QMI_SERVICE_ID_SLIMBUS 0x301 /* 769 */
+#define QMI_SERVICE_ID_USB_AUDIO_STREAM 0x41D /* 1053 */
+
/**
* struct qmi_response_type_v01 - common response header (decoded)
* @result: result of the transaction
--
2.43.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* Re: [PATCH v1 1/8] soc: qcom: qmi: Enumerate the service IDs of QMI
2026-03-09 23:03 ` [PATCH v1 1/8] soc: qcom: qmi: Enumerate the service IDs of QMI Daniel Lezcano
@ 2026-03-10 0:04 ` Dmitry Baryshkov
2026-03-10 9:57 ` Konrad Dybcio
1 sibling, 0 replies; 28+ messages in thread
From: Dmitry Baryshkov @ 2026-03-10 0:04 UTC (permalink / raw)
To: Daniel Lezcano
Cc: konradybcio, andersson, linux-kernel, Alex Elder, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jeff Johnson, Mathieu Poirier, Srinivas Kandagatla,
Jaroslav Kysela, Takashi Iwai, Kees Cook, Greg Kroah-Hartman,
Arnd Bergmann, Mark Brown, Wesley Cheng, netdev, linux-wireless,
ath10k, ath11k, ath12k, linux-arm-msm, linux-remoteproc,
linux-sound
On Tue, Mar 10, 2026 at 12:03:30AM +0100, Daniel Lezcano wrote:
> The QMI framework proposes a set of services which are defined by an
> integer identifier. The different QMI client lookup for the services
> via this identifier. Moreover, the function qmi_add_lookup() and
> qmi_add_server() must match the service ID but the code in different
> places set the same value but with a different macro name. These
> macros are spreaded across the different subsystems implementing the
> protocols associated with a service. It would make more sense to
> define them in the QMI header for the sake of consistency and clarity.
>
> This change use an unified naming for the services and enumerate the
Nit: see Documentation/process/submitting-patches.rst, "This patch"
Other than that,
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ones implemented in the Linux kernel. More services can come later and
> put the service ID in this same header.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
> ---
> include/linux/soc/qcom/qmi.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 1/8] soc: qcom: qmi: Enumerate the service IDs of QMI
2026-03-09 23:03 ` [PATCH v1 1/8] soc: qcom: qmi: Enumerate the service IDs of QMI Daniel Lezcano
2026-03-10 0:04 ` Dmitry Baryshkov
@ 2026-03-10 9:57 ` Konrad Dybcio
2026-03-10 10:06 ` Daniel Lezcano
2026-03-10 13:23 ` Daniel Lezcano
1 sibling, 2 replies; 28+ messages in thread
From: Konrad Dybcio @ 2026-03-10 9:57 UTC (permalink / raw)
To: Daniel Lezcano, konradybcio, andersson
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
On 3/10/26 12:03 AM, Daniel Lezcano wrote:
> The QMI framework proposes a set of services which are defined by an
> integer identifier. The different QMI client lookup for the services
> via this identifier. Moreover, the function qmi_add_lookup() and
> qmi_add_server() must match the service ID but the code in different
> places set the same value but with a different macro name. These
> macros are spreaded across the different subsystems implementing the
> protocols associated with a service. It would make more sense to
> define them in the QMI header for the sake of consistency and clarity.
>
> This change use an unified naming for the services and enumerate the
> ones implemented in the Linux kernel. More services can come later and
> put the service ID in this same header.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
> ---
> include/linux/soc/qcom/qmi.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/include/linux/soc/qcom/qmi.h b/include/linux/soc/qcom/qmi.h
> index 291cdc7ef49c..b8d07f2c07e7 100644
> --- a/include/linux/soc/qcom/qmi.h
> +++ b/include/linux/soc/qcom/qmi.h
> @@ -92,6 +92,18 @@ struct qmi_elem_info {
> #define QMI_ERR_INCOMPATIBLE_STATE_V01 90
> #define QMI_ERR_NOT_SUPPORTED_V01 94
>
> +/*
> + * Enumerate the IDs of the QMI services
In case that's useful:
https://github.com/linux-msm/qrtr/blob/master/src/lookup.c#L23
Konrad
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v1 1/8] soc: qcom: qmi: Enumerate the service IDs of QMI
2026-03-10 9:57 ` Konrad Dybcio
@ 2026-03-10 10:06 ` Daniel Lezcano
2026-03-10 13:23 ` Daniel Lezcano
1 sibling, 0 replies; 28+ messages in thread
From: Daniel Lezcano @ 2026-03-10 10:06 UTC (permalink / raw)
To: Konrad Dybcio, konradybcio, andersson
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
On 3/10/26 10:57, Konrad Dybcio wrote:
> On 3/10/26 12:03 AM, Daniel Lezcano wrote:
>> The QMI framework proposes a set of services which are defined by an
>> integer identifier. The different QMI client lookup for the services
>> via this identifier. Moreover, the function qmi_add_lookup() and
>> qmi_add_server() must match the service ID but the code in different
>> places set the same value but with a different macro name. These
>> macros are spreaded across the different subsystems implementing the
>> protocols associated with a service. It would make more sense to
>> define them in the QMI header for the sake of consistency and clarity.
>>
>> This change use an unified naming for the services and enumerate the
>> ones implemented in the Linux kernel. More services can come later and
>> put the service ID in this same header.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
>> ---
>> include/linux/soc/qcom/qmi.h | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/include/linux/soc/qcom/qmi.h b/include/linux/soc/qcom/qmi.h
>> index 291cdc7ef49c..b8d07f2c07e7 100644
>> --- a/include/linux/soc/qcom/qmi.h
>> +++ b/include/linux/soc/qcom/qmi.h
>> @@ -92,6 +92,18 @@ struct qmi_elem_info {
>> #define QMI_ERR_INCOMPATIBLE_STATE_V01 90
>> #define QMI_ERR_NOT_SUPPORTED_V01 94
>>
>> +/*
>> + * Enumerate the IDs of the QMI services
>
> In case that's useful:
>
> https://github.com/linux-msm/qrtr/blob/master/src/lookup.c#L23
Thanks !
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v1 1/8] soc: qcom: qmi: Enumerate the service IDs of QMI
2026-03-10 9:57 ` Konrad Dybcio
2026-03-10 10:06 ` Daniel Lezcano
@ 2026-03-10 13:23 ` Daniel Lezcano
1 sibling, 0 replies; 28+ messages in thread
From: Daniel Lezcano @ 2026-03-10 13:23 UTC (permalink / raw)
To: Konrad Dybcio, konradybcio, andersson
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
On 3/10/26 10:57, Konrad Dybcio wrote:
> On 3/10/26 12:03 AM, Daniel Lezcano wrote:
>> The QMI framework proposes a set of services which are defined by an
>> integer identifier. The different QMI client lookup for the services
>> via this identifier. Moreover, the function qmi_add_lookup() and
>> qmi_add_server() must match the service ID but the code in different
>> places set the same value but with a different macro name. These
>> macros are spreaded across the different subsystems implementing the
>> protocols associated with a service. It would make more sense to
>> define them in the QMI header for the sake of consistency and clarity.
>>
>> This change use an unified naming for the services and enumerate the
>> ones implemented in the Linux kernel. More services can come later and
>> put the service ID in this same header.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
>> ---
>> include/linux/soc/qcom/qmi.h | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/include/linux/soc/qcom/qmi.h b/include/linux/soc/qcom/qmi.h
>> index 291cdc7ef49c..b8d07f2c07e7 100644
>> --- a/include/linux/soc/qcom/qmi.h
>> +++ b/include/linux/soc/qcom/qmi.h
>> @@ -92,6 +92,18 @@ struct qmi_elem_info {
>> #define QMI_ERR_INCOMPATIBLE_STATE_V01 90
>> #define QMI_ERR_NOT_SUPPORTED_V01 94
>>
>> +/*
>> + * Enumerate the IDs of the QMI services
I've the same number of patches fixing the copyright for each patch
touched in this series. Shall I post the series separately and fold them
with the corresponding patch ? (IMO the former is cleaner)
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v1 2/8] net: ipa: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 [PATCH v1 0/8] Group QMI service IDs into the QMI header Daniel Lezcano
2026-03-09 23:03 ` [PATCH v1 1/8] soc: qcom: qmi: Enumerate the service IDs of QMI Daniel Lezcano
@ 2026-03-09 23:03 ` Daniel Lezcano
2026-03-10 0:04 ` Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 3/8] net: drivers: wireless: ath: " Daniel Lezcano
` (9 subsequent siblings)
11 siblings, 1 reply; 28+ messages in thread
From: Daniel Lezcano @ 2026-03-09 23:03 UTC (permalink / raw)
To: konradybcio, andersson
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
Instead of defining a local macro with a custom name for the QMI
service identifier, use the one provided in qmi.h and remove the
locally defined macro.
Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
---
drivers/net/ipa/ipa_qmi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ipa/ipa_qmi.c b/drivers/net/ipa/ipa_qmi.c
index d771f3a71f94..37936ad132a2 100644
--- a/drivers/net/ipa/ipa_qmi.c
+++ b/drivers/net/ipa/ipa_qmi.c
@@ -66,11 +66,9 @@
* determination of when things are "ready"
*/
-#define IPA_HOST_SERVICE_SVC_ID 0x31
#define IPA_HOST_SVC_VERS 1
#define IPA_HOST_SERVICE_INS_ID 1
-#define IPA_MODEM_SERVICE_SVC_ID 0x31
#define IPA_MODEM_SERVICE_INS_ID 2
#define IPA_MODEM_SVC_VERS 1
@@ -484,7 +482,7 @@ int ipa_qmi_setup(struct ipa *ipa)
if (ret)
return ret;
- ret = qmi_add_server(&ipa_qmi->server_handle, IPA_HOST_SERVICE_SVC_ID,
+ ret = qmi_add_server(&ipa_qmi->server_handle, QMI_SERVICE_ID_IPA,
IPA_HOST_SVC_VERS, IPA_HOST_SERVICE_INS_ID);
if (ret)
goto err_server_handle_release;
@@ -501,7 +499,7 @@ int ipa_qmi_setup(struct ipa *ipa)
/* We need this ready before the service lookup is added */
INIT_WORK(&ipa_qmi->init_driver_work, ipa_client_init_driver_work);
- ret = qmi_add_lookup(&ipa_qmi->client_handle, IPA_MODEM_SERVICE_SVC_ID,
+ ret = qmi_add_lookup(&ipa_qmi->client_handle, QMI_SERVICE_ID_IPA,
IPA_MODEM_SVC_VERS, IPA_MODEM_SERVICE_INS_ID);
if (ret)
goto err_client_handle_release;
--
2.43.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* Re: [PATCH v1 2/8] net: ipa: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 ` [PATCH v1 2/8] net: ipa: Use the unified QMI service ID instead of defining it locally Daniel Lezcano
@ 2026-03-10 0:04 ` Dmitry Baryshkov
0 siblings, 0 replies; 28+ messages in thread
From: Dmitry Baryshkov @ 2026-03-10 0:04 UTC (permalink / raw)
To: Daniel Lezcano
Cc: konradybcio, andersson, linux-kernel, Alex Elder, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jeff Johnson, Mathieu Poirier, Srinivas Kandagatla,
Jaroslav Kysela, Takashi Iwai, Kees Cook, Greg Kroah-Hartman,
Arnd Bergmann, Mark Brown, Wesley Cheng, netdev, linux-wireless,
ath10k, ath11k, ath12k, linux-arm-msm, linux-remoteproc,
linux-sound
On Tue, Mar 10, 2026 at 12:03:31AM +0100, Daniel Lezcano wrote:
> Instead of defining a local macro with a custom name for the QMI
> service identifier, use the one provided in qmi.h and remove the
> locally defined macro.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
> ---
> drivers/net/ipa/ipa_qmi.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v1 3/8] net: drivers: wireless: ath: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 [PATCH v1 0/8] Group QMI service IDs into the QMI header Daniel Lezcano
2026-03-09 23:03 ` [PATCH v1 1/8] soc: qcom: qmi: Enumerate the service IDs of QMI Daniel Lezcano
2026-03-09 23:03 ` [PATCH v1 2/8] net: ipa: Use the unified QMI service ID instead of defining it locally Daniel Lezcano
@ 2026-03-09 23:03 ` Daniel Lezcano
2026-03-10 0:05 ` Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 4/8] remoteproc: qcom: " Daniel Lezcano
` (8 subsequent siblings)
11 siblings, 1 reply; 28+ messages in thread
From: Daniel Lezcano @ 2026-03-09 23:03 UTC (permalink / raw)
To: konradybcio, andersson
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
Instead of defining a local macro with a custom name for the QMI
service identifier, use the one provided in qmi.h and remove the
locally defined macro.
Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/qmi.c | 2 +-
drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 -
drivers/net/wireless/ath/ath11k/qmi.c | 2 +-
drivers/net/wireless/ath/ath11k/qmi.h | 1 -
drivers/net/wireless/ath/ath12k/qmi.c | 2 +-
drivers/net/wireless/ath/ath12k/qmi.h | 1 -
6 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c
index eebd78e7ff6b..4fdd0af415d5 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.c
+++ b/drivers/net/wireless/ath/ath10k/qmi.c
@@ -1105,7 +1105,7 @@ int ath10k_qmi_init(struct ath10k *ar, u32 msa_size)
spin_lock_init(&qmi->event_lock);
INIT_WORK(&qmi->event_work, ath10k_qmi_driver_event_work);
- ret = qmi_add_lookup(&qmi->qmi_hdl, WLFW_SERVICE_ID_V01,
+ ret = qmi_add_lookup(&qmi->qmi_hdl, QMI_SERVICE_ID_WLFW,
WLFW_SERVICE_VERS_V01, 0);
if (ret)
goto err_qmi_lookup;
diff --git a/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h b/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h
index 9f311f3bc9e7..88d58f78989d 100644
--- a/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h
+++ b/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h
@@ -7,7 +7,6 @@
#ifndef WCN3990_QMI_SVC_V01_H
#define WCN3990_QMI_SVC_V01_H
-#define WLFW_SERVICE_ID_V01 0x45
#define WLFW_SERVICE_VERS_V01 0x01
#define QMI_WLFW_BDF_DOWNLOAD_REQ_V01 0x0025
diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
index feebbc30f3df..1397756d6251 100644
--- a/drivers/net/wireless/ath/ath11k/qmi.c
+++ b/drivers/net/wireless/ath/ath11k/qmi.c
@@ -3337,7 +3337,7 @@ int ath11k_qmi_init_service(struct ath11k_base *ab)
spin_lock_init(&ab->qmi.event_lock);
INIT_WORK(&ab->qmi.event_work, ath11k_qmi_driver_event_work);
- ret = qmi_add_lookup(&ab->qmi.handle, ATH11K_QMI_WLFW_SERVICE_ID_V01,
+ ret = qmi_add_lookup(&ab->qmi.handle, QMI_SERVICE_ID_WLFW,
ATH11K_QMI_WLFW_SERVICE_VERS_V01,
ab->qmi.service_ins_id);
if (ret < 0) {
diff --git a/drivers/net/wireless/ath/ath11k/qmi.h b/drivers/net/wireless/ath/ath11k/qmi.h
index 7968ab122b65..eae416db8b52 100644
--- a/drivers/net/wireless/ath/ath11k/qmi.h
+++ b/drivers/net/wireless/ath/ath11k/qmi.h
@@ -15,7 +15,6 @@
#define ATH11K_QMI_MAX_BDF_FILE_NAME_SIZE 64
#define ATH11K_QMI_CALDB_ADDRESS 0x4BA00000
#define ATH11K_QMI_WLANFW_MAX_BUILD_ID_LEN_V01 128
-#define ATH11K_QMI_WLFW_SERVICE_ID_V01 0x45
#define ATH11K_QMI_WLFW_SERVICE_VERS_V01 0x01
#define ATH11K_QMI_WLFW_SERVICE_INS_ID_V01 0x02
#define ATH11K_QMI_WLFW_SERVICE_INS_ID_V01_QCA6390 0x01
diff --git a/drivers/net/wireless/ath/ath12k/qmi.c b/drivers/net/wireless/ath/ath12k/qmi.c
index c11b84b56f8f..f31cba7af722 100644
--- a/drivers/net/wireless/ath/ath12k/qmi.c
+++ b/drivers/net/wireless/ath/ath12k/qmi.c
@@ -4061,7 +4061,7 @@ int ath12k_qmi_init_service(struct ath12k_base *ab)
spin_lock_init(&ab->qmi.event_lock);
INIT_WORK(&ab->qmi.event_work, ath12k_qmi_driver_event_work);
- ret = qmi_add_lookup(&ab->qmi.handle, ATH12K_QMI_WLFW_SERVICE_ID_V01,
+ ret = qmi_add_lookup(&ab->qmi.handle, QMI_SERVICE_ID_WLFW,
ATH12K_QMI_WLFW_SERVICE_VERS_V01,
ab->qmi.service_ins_id);
if (ret < 0) {
diff --git a/drivers/net/wireless/ath/ath12k/qmi.h b/drivers/net/wireless/ath/ath12k/qmi.h
index b5a4a01391cb..2a63e214eb42 100644
--- a/drivers/net/wireless/ath/ath12k/qmi.h
+++ b/drivers/net/wireless/ath/ath12k/qmi.h
@@ -15,7 +15,6 @@
#define ATH12K_QMI_MAX_BDF_FILE_NAME_SIZE 64
#define ATH12K_QMI_CALDB_ADDRESS 0x4BA00000
#define ATH12K_QMI_WLANFW_MAX_BUILD_ID_LEN_V01 128
-#define ATH12K_QMI_WLFW_SERVICE_ID_V01 0x45
#define ATH12K_QMI_WLFW_SERVICE_VERS_V01 0x01
#define ATH12K_QMI_WLFW_SERVICE_INS_ID_V01 0x02
#define ATH12K_QMI_WLFW_SERVICE_INS_ID_V01_WCN7850 0x1
--
2.43.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* Re: [PATCH v1 3/8] net: drivers: wireless: ath: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 ` [PATCH v1 3/8] net: drivers: wireless: ath: " Daniel Lezcano
@ 2026-03-10 0:05 ` Dmitry Baryshkov
0 siblings, 0 replies; 28+ messages in thread
From: Dmitry Baryshkov @ 2026-03-10 0:05 UTC (permalink / raw)
To: Daniel Lezcano
Cc: konradybcio, andersson, linux-kernel, Alex Elder, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jeff Johnson, Mathieu Poirier, Srinivas Kandagatla,
Jaroslav Kysela, Takashi Iwai, Kees Cook, Greg Kroah-Hartman,
Arnd Bergmann, Mark Brown, Wesley Cheng, netdev, linux-wireless,
ath10k, ath11k, ath12k, linux-arm-msm, linux-remoteproc,
linux-sound
On Tue, Mar 10, 2026 at 12:03:32AM +0100, Daniel Lezcano wrote:
> Instead of defining a local macro with a custom name for the QMI
> service identifier, use the one provided in qmi.h and remove the
> locally defined macro.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/qmi.c | 2 +-
> drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 -
> drivers/net/wireless/ath/ath11k/qmi.c | 2 +-
> drivers/net/wireless/ath/ath11k/qmi.h | 1 -
> drivers/net/wireless/ath/ath12k/qmi.c | 2 +-
> drivers/net/wireless/ath/ath12k/qmi.h | 1 -
> 6 files changed, 3 insertions(+), 6 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v1 4/8] remoteproc: qcom: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 [PATCH v1 0/8] Group QMI service IDs into the QMI header Daniel Lezcano
` (2 preceding siblings ...)
2026-03-09 23:03 ` [PATCH v1 3/8] net: drivers: wireless: ath: " Daniel Lezcano
@ 2026-03-09 23:03 ` Daniel Lezcano
2026-03-10 0:05 ` Dmitry Baryshkov
2026-03-16 2:09 ` (subset) " Bjorn Andersson
2026-03-09 23:03 ` [PATCH v1 5/8] slimbus: qcom-ngd-ctrl: " Daniel Lezcano
` (7 subsequent siblings)
11 siblings, 2 replies; 28+ messages in thread
From: Daniel Lezcano @ 2026-03-09 23:03 UTC (permalink / raw)
To: konradybcio, andersson
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
Instead of defining a local macro with a custom name for the QMI
service identifier, use the one provided in qmi.h and remove the
locally defined macro.
Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
---
drivers/remoteproc/qcom_sysmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c
index cf10e8ecfb8f..5bd4147f1f37 100644
--- a/drivers/remoteproc/qcom_sysmon.c
+++ b/drivers/remoteproc/qcom_sysmon.c
@@ -677,7 +677,7 @@ struct qcom_sysmon *qcom_add_sysmon_subdev(struct rproc *rproc,
return ERR_PTR(ret);
}
- qmi_add_lookup(&sysmon->qmi, 43, 0, 0);
+ qmi_add_lookup(&sysmon->qmi, QMI_SERVICE_ID_SSCTL, 0, 0);
sysmon->subdev.prepare = sysmon_prepare;
sysmon->subdev.start = sysmon_start;
--
2.43.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* Re: [PATCH v1 4/8] remoteproc: qcom: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 ` [PATCH v1 4/8] remoteproc: qcom: " Daniel Lezcano
@ 2026-03-10 0:05 ` Dmitry Baryshkov
2026-03-16 2:09 ` (subset) " Bjorn Andersson
1 sibling, 0 replies; 28+ messages in thread
From: Dmitry Baryshkov @ 2026-03-10 0:05 UTC (permalink / raw)
To: Daniel Lezcano
Cc: konradybcio, andersson, linux-kernel, Alex Elder, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jeff Johnson, Mathieu Poirier, Srinivas Kandagatla,
Jaroslav Kysela, Takashi Iwai, Kees Cook, Greg Kroah-Hartman,
Arnd Bergmann, Mark Brown, Wesley Cheng, netdev, linux-wireless,
ath10k, ath11k, ath12k, linux-arm-msm, linux-remoteproc,
linux-sound
On Tue, Mar 10, 2026 at 12:03:33AM +0100, Daniel Lezcano wrote:
> Instead of defining a local macro with a custom name for the QMI
> service identifier, use the one provided in qmi.h and remove the
> locally defined macro.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
> ---
> drivers/remoteproc/qcom_sysmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: (subset) [PATCH v1 4/8] remoteproc: qcom: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 ` [PATCH v1 4/8] remoteproc: qcom: " Daniel Lezcano
2026-03-10 0:05 ` Dmitry Baryshkov
@ 2026-03-16 2:09 ` Bjorn Andersson
2026-03-19 9:02 ` Daniel Lezcano
1 sibling, 1 reply; 28+ messages in thread
From: Bjorn Andersson @ 2026-03-16 2:09 UTC (permalink / raw)
To: konradybcio, Daniel Lezcano
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
On Tue, 10 Mar 2026 00:03:33 +0100, Daniel Lezcano wrote:
> Instead of defining a local macro with a custom name for the QMI
> service identifier, use the one provided in qmi.h and remove the
> locally defined macro.
>
>
Applied, thanks!
[4/8] remoteproc: qcom: Use the unified QMI service ID instead of defining it locally
commit: 95b6c029e56e4d75e2957ce7ac795da29415865b
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: (subset) [PATCH v1 4/8] remoteproc: qcom: Use the unified QMI service ID instead of defining it locally
2026-03-16 2:09 ` (subset) " Bjorn Andersson
@ 2026-03-19 9:02 ` Daniel Lezcano
0 siblings, 0 replies; 28+ messages in thread
From: Daniel Lezcano @ 2026-03-19 9:02 UTC (permalink / raw)
To: Bjorn Andersson, konradybcio
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
Hi,
On 3/16/26 03:09, Bjorn Andersson wrote:
>
> On Tue, 10 Mar 2026 00:03:33 +0100, Daniel Lezcano wrote:
>> Instead of defining a local macro with a custom name for the QMI
>> service identifier, use the one provided in qmi.h and remove the
>> locally defined macro.
>>
>>
>
> Applied, thanks!
>
> [4/8] remoteproc: qcom: Use the unified QMI service ID instead of defining it locally
> commit: 95b6c029e56e4d75e2957ce7ac795da29415865b
Just a head up I'm not seeing it in qcom/for-next
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v1 5/8] slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 [PATCH v1 0/8] Group QMI service IDs into the QMI header Daniel Lezcano
` (3 preceding siblings ...)
2026-03-09 23:03 ` [PATCH v1 4/8] remoteproc: qcom: " Daniel Lezcano
@ 2026-03-09 23:03 ` Daniel Lezcano
2026-03-10 0:06 ` Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 6/8] soc: qcom: pdr: " Daniel Lezcano
` (6 subsequent siblings)
11 siblings, 1 reply; 28+ messages in thread
From: Daniel Lezcano @ 2026-03-09 23:03 UTC (permalink / raw)
To: konradybcio, andersson
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
Instead of defining a local macro with a custom name for the QMI
service identifier, use the one provided in qmi.h and remove the
locally defined macro.
Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
---
drivers/slimbus/qcom-ngd-ctrl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
index 9aa7218b4e8d..0b88b8577bdb 100644
--- a/drivers/slimbus/qcom-ngd-ctrl.c
+++ b/drivers/slimbus/qcom-ngd-ctrl.c
@@ -48,7 +48,6 @@
NGD_INT_RX_MSG_RCVD)
/* Slimbus QMI service */
-#define SLIMBUS_QMI_SVC_ID 0x0301
#define SLIMBUS_QMI_SVC_V1 1
#define SLIMBUS_QMI_INS_ID 0
#define SLIMBUS_QMI_SELECT_INSTANCE_REQ_V01 0x0020
@@ -1408,8 +1407,8 @@ static int qcom_slim_ngd_qmi_svc_event_init(struct qcom_slim_ngd_ctrl *ctrl)
return ret;
}
- ret = qmi_add_lookup(&qmi->svc_event_hdl, SLIMBUS_QMI_SVC_ID,
- SLIMBUS_QMI_SVC_V1, SLIMBUS_QMI_INS_ID);
+ ret = qmi_add_lookup(&qmi->svc_event_hdl, QMI_SERVICE_ID_SLIMBUS,
+ SLIMBUS_QMI_SVC_V1, SLIMBUS_QMI_INS_ID);
if (ret < 0) {
dev_err(ctrl->dev, "qmi_add_lookup failed: %d\n", ret);
qmi_handle_release(&qmi->svc_event_hdl);
--
2.43.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* Re: [PATCH v1 5/8] slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 ` [PATCH v1 5/8] slimbus: qcom-ngd-ctrl: " Daniel Lezcano
@ 2026-03-10 0:06 ` Dmitry Baryshkov
0 siblings, 0 replies; 28+ messages in thread
From: Dmitry Baryshkov @ 2026-03-10 0:06 UTC (permalink / raw)
To: Daniel Lezcano
Cc: konradybcio, andersson, linux-kernel, Alex Elder, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jeff Johnson, Mathieu Poirier, Srinivas Kandagatla,
Jaroslav Kysela, Takashi Iwai, Kees Cook, Greg Kroah-Hartman,
Arnd Bergmann, Mark Brown, Wesley Cheng, netdev, linux-wireless,
ath10k, ath11k, ath12k, linux-arm-msm, linux-remoteproc,
linux-sound
On Tue, Mar 10, 2026 at 12:03:34AM +0100, Daniel Lezcano wrote:
> Instead of defining a local macro with a custom name for the QMI
> service identifier, use the one provided in qmi.h and remove the
> locally defined macro.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
> ---
> drivers/slimbus/qcom-ngd-ctrl.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v1 6/8] soc: qcom: pdr: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 [PATCH v1 0/8] Group QMI service IDs into the QMI header Daniel Lezcano
` (4 preceding siblings ...)
2026-03-09 23:03 ` [PATCH v1 5/8] slimbus: qcom-ngd-ctrl: " Daniel Lezcano
@ 2026-03-09 23:03 ` Daniel Lezcano
2026-03-10 0:06 ` Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 7/8] ALSA: usb-audio: qcom: " Daniel Lezcano
` (5 subsequent siblings)
11 siblings, 1 reply; 28+ messages in thread
From: Daniel Lezcano @ 2026-03-09 23:03 UTC (permalink / raw)
To: konradybcio, andersson
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
Instead of defining a local macro with a custom name for the QMI
service identifier, use the one provided in qmi.h and remove the
locally defined macro.
Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
---
drivers/soc/qcom/pdr_interface.c | 4 ++--
drivers/soc/qcom/pdr_internal.h | 3 ---
drivers/soc/qcom/qcom_pd_mapper.c | 2 +-
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/soc/qcom/pdr_interface.c b/drivers/soc/qcom/pdr_interface.c
index 72259f489075..6d879e1540b0 100644
--- a/drivers/soc/qcom/pdr_interface.c
+++ b/drivers/soc/qcom/pdr_interface.c
@@ -523,7 +523,7 @@ struct pdr_service *pdr_add_lookup(struct pdr_handle *pdr,
if (!pds)
return ERR_PTR(-ENOMEM);
- pds->service = SERVREG_NOTIFIER_SERVICE;
+ pds->service = QMI_SERVICE_ID_SERVREG_NOTIF;
strscpy(pds->service_name, service_name, sizeof(pds->service_name));
strscpy(pds->service_path, service_path, sizeof(pds->service_path));
pds->need_locator_lookup = true;
@@ -678,7 +678,7 @@ struct pdr_handle *pdr_handle_alloc(void (*status)(int state,
if (ret < 0)
goto destroy_indack;
- ret = qmi_add_lookup(&pdr->locator_hdl, SERVREG_LOCATOR_SERVICE, 1, 1);
+ ret = qmi_add_lookup(&pdr->locator_hdl, QMI_SERVICE_ID_SERVREG_LOC, 1, 1);
if (ret < 0)
goto release_qmi_handle;
diff --git a/drivers/soc/qcom/pdr_internal.h b/drivers/soc/qcom/pdr_internal.h
index 039508c1bbf7..6cd8cbe26822 100644
--- a/drivers/soc/qcom/pdr_internal.h
+++ b/drivers/soc/qcom/pdr_internal.h
@@ -4,9 +4,6 @@
#include <linux/soc/qcom/pdr.h>
-#define SERVREG_LOCATOR_SERVICE 0x40
-#define SERVREG_NOTIFIER_SERVICE 0x42
-
#define SERVREG_REGISTER_LISTENER_REQ 0x20
#define SERVREG_GET_DOMAIN_LIST_REQ 0x21
#define SERVREG_STATE_UPDATED_IND_ID 0x22
diff --git a/drivers/soc/qcom/qcom_pd_mapper.c b/drivers/soc/qcom/qcom_pd_mapper.c
index dc10bc859ff4..bb60b5c40554 100644
--- a/drivers/soc/qcom/qcom_pd_mapper.c
+++ b/drivers/soc/qcom/qcom_pd_mapper.c
@@ -656,7 +656,7 @@ static struct qcom_pdm_data *qcom_pdm_start(void)
goto err_stop;
}
- ret = qmi_add_server(&data->handle, SERVREG_LOCATOR_SERVICE,
+ ret = qmi_add_server(&data->handle, QMI_SERVICE_ID_SERVREG_LOC,
SERVREG_QMI_VERSION, SERVREG_QMI_INSTANCE);
if (ret) {
pr_err("PDM: error adding server %d\n", ret);
--
2.43.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* Re: [PATCH v1 6/8] soc: qcom: pdr: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 ` [PATCH v1 6/8] soc: qcom: pdr: " Daniel Lezcano
@ 2026-03-10 0:06 ` Dmitry Baryshkov
0 siblings, 0 replies; 28+ messages in thread
From: Dmitry Baryshkov @ 2026-03-10 0:06 UTC (permalink / raw)
To: Daniel Lezcano
Cc: konradybcio, andersson, linux-kernel, Alex Elder, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jeff Johnson, Mathieu Poirier, Srinivas Kandagatla,
Jaroslav Kysela, Takashi Iwai, Kees Cook, Greg Kroah-Hartman,
Arnd Bergmann, Mark Brown, Wesley Cheng, netdev, linux-wireless,
ath10k, ath11k, ath12k, linux-arm-msm, linux-remoteproc,
linux-sound
On Tue, Mar 10, 2026 at 12:03:35AM +0100, Daniel Lezcano wrote:
> Instead of defining a local macro with a custom name for the QMI
> service identifier, use the one provided in qmi.h and remove the
> locally defined macro.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
> ---
> drivers/soc/qcom/pdr_interface.c | 4 ++--
> drivers/soc/qcom/pdr_internal.h | 3 ---
> drivers/soc/qcom/qcom_pd_mapper.c | 2 +-
> 3 files changed, 3 insertions(+), 6 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v1 7/8] ALSA: usb-audio: qcom: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 [PATCH v1 0/8] Group QMI service IDs into the QMI header Daniel Lezcano
` (5 preceding siblings ...)
2026-03-09 23:03 ` [PATCH v1 6/8] soc: qcom: pdr: " Daniel Lezcano
@ 2026-03-09 23:03 ` Daniel Lezcano
2026-03-10 0:07 ` Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 8/8] samples: qmi: " Daniel Lezcano
` (4 subsequent siblings)
11 siblings, 1 reply; 28+ messages in thread
From: Daniel Lezcano @ 2026-03-09 23:03 UTC (permalink / raw)
To: konradybcio, andersson
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound,
Erick Karanja
Instead of defining a local macro with a custom name for the QMI
service identifier, use the one provided in qmi.h and remove the
locally defined macro.
Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
---
sound/usb/qcom/qc_audio_offload.c | 2 +-
sound/usb/qcom/usb_audio_qmi_v01.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/usb/qcom/qc_audio_offload.c b/sound/usb/qcom/qc_audio_offload.c
index 510b68cced33..bc4e1bdacaa8 100644
--- a/sound/usb/qcom/qc_audio_offload.c
+++ b/sound/usb/qcom/qc_audio_offload.c
@@ -1927,7 +1927,7 @@ static int qc_usb_audio_probe(struct auxiliary_device *auxdev,
QMI_UAUDIO_STREAM_REQ_MSG_V01_MAX_MSG_LEN,
&uaudio_svc_ops_options,
&uaudio_stream_req_handlers);
- ret = qmi_add_server(svc->uaudio_svc_hdl, UAUDIO_STREAM_SERVICE_ID_V01,
+ ret = qmi_add_server(svc->uaudio_svc_hdl, QMI_SERVICE_ID_USB_AUDIO_STREAM,
UAUDIO_STREAM_SERVICE_VERS_V01, 0);
uaudio_svc = svc;
diff --git a/sound/usb/qcom/usb_audio_qmi_v01.h b/sound/usb/qcom/usb_audio_qmi_v01.h
index a1298d75d9f8..c7eee03225ec 100644
--- a/sound/usb/qcom/usb_audio_qmi_v01.h
+++ b/sound/usb/qcom/usb_audio_qmi_v01.h
@@ -6,7 +6,6 @@
#ifndef USB_QMI_V01_H
#define USB_QMI_V01_H
-#define UAUDIO_STREAM_SERVICE_ID_V01 0x41D
#define UAUDIO_STREAM_SERVICE_VERS_V01 0x01
#define QMI_UAUDIO_STREAM_RESP_V01 0x0001
--
2.43.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* Re: [PATCH v1 7/8] ALSA: usb-audio: qcom: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 ` [PATCH v1 7/8] ALSA: usb-audio: qcom: " Daniel Lezcano
@ 2026-03-10 0:07 ` Dmitry Baryshkov
0 siblings, 0 replies; 28+ messages in thread
From: Dmitry Baryshkov @ 2026-03-10 0:07 UTC (permalink / raw)
To: Daniel Lezcano
Cc: konradybcio, andersson, linux-kernel, Alex Elder, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jeff Johnson, Mathieu Poirier, Srinivas Kandagatla,
Jaroslav Kysela, Takashi Iwai, Kees Cook, Greg Kroah-Hartman,
Arnd Bergmann, Mark Brown, Wesley Cheng, netdev, linux-wireless,
ath10k, ath11k, ath12k, linux-arm-msm, linux-remoteproc,
linux-sound, Erick Karanja
On Tue, Mar 10, 2026 at 12:03:36AM +0100, Daniel Lezcano wrote:
> Instead of defining a local macro with a custom name for the QMI
> service identifier, use the one provided in qmi.h and remove the
> locally defined macro.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
> ---
> sound/usb/qcom/qc_audio_offload.c | 2 +-
> sound/usb/qcom/usb_audio_qmi_v01.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v1 8/8] samples: qmi: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 [PATCH v1 0/8] Group QMI service IDs into the QMI header Daniel Lezcano
` (6 preceding siblings ...)
2026-03-09 23:03 ` [PATCH v1 7/8] ALSA: usb-audio: qcom: " Daniel Lezcano
@ 2026-03-09 23:03 ` Daniel Lezcano
2026-03-10 0:07 ` Dmitry Baryshkov
2026-03-09 23:50 ` [PATCH v1 0/8] Group QMI service IDs into the QMI header Jeff Johnson
` (3 subsequent siblings)
11 siblings, 1 reply; 28+ messages in thread
From: Daniel Lezcano @ 2026-03-09 23:03 UTC (permalink / raw)
To: konradybcio, andersson
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
Instead of defining a local macro with a custom name for the QMI
service identifier, use the one provided in qmi.h and remove the
locally defined macro.
Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
---
samples/qmi/qmi_sample_client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/qmi/qmi_sample_client.c b/samples/qmi/qmi_sample_client.c
index d1814582319b..247ec5e54c4f 100644
--- a/samples/qmi/qmi_sample_client.c
+++ b/samples/qmi/qmi_sample_client.c
@@ -592,7 +592,7 @@ static int qmi_sample_init(void)
if (ret < 0)
goto err_unregister_driver;
- qmi_add_lookup(&lookup_client, 15, 0, 0);
+ qmi_add_lookup(&lookup_client, QMI_SERVICE_ID_TEST, 0, 0);
return 0;
--
2.43.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* Re: [PATCH v1 8/8] samples: qmi: Use the unified QMI service ID instead of defining it locally
2026-03-09 23:03 ` [PATCH v1 8/8] samples: qmi: " Daniel Lezcano
@ 2026-03-10 0:07 ` Dmitry Baryshkov
0 siblings, 0 replies; 28+ messages in thread
From: Dmitry Baryshkov @ 2026-03-10 0:07 UTC (permalink / raw)
To: Daniel Lezcano
Cc: konradybcio, andersson, linux-kernel, Alex Elder, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jeff Johnson, Mathieu Poirier, Srinivas Kandagatla,
Jaroslav Kysela, Takashi Iwai, Kees Cook, Greg Kroah-Hartman,
Arnd Bergmann, Mark Brown, Wesley Cheng, netdev, linux-wireless,
ath10k, ath11k, ath12k, linux-arm-msm, linux-remoteproc,
linux-sound
On Tue, Mar 10, 2026 at 12:03:37AM +0100, Daniel Lezcano wrote:
> Instead of defining a local macro with a custom name for the QMI
> service identifier, use the one provided in qmi.h and remove the
> locally defined macro.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
> ---
> samples/qmi/qmi_sample_client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 0/8] Group QMI service IDs into the QMI header
2026-03-09 23:03 [PATCH v1 0/8] Group QMI service IDs into the QMI header Daniel Lezcano
` (7 preceding siblings ...)
2026-03-09 23:03 ` [PATCH v1 8/8] samples: qmi: " Daniel Lezcano
@ 2026-03-09 23:50 ` Jeff Johnson
2026-03-10 0:09 ` Daniel Lezcano
2026-03-10 0:11 ` Dmitry Baryshkov
` (2 subsequent siblings)
11 siblings, 1 reply; 28+ messages in thread
From: Jeff Johnson @ 2026-03-09 23:50 UTC (permalink / raw)
To: Daniel Lezcano, konradybcio, andersson
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
On 3/9/2026 4:03 PM, Daniel Lezcano wrote:
> The different subsystems implementing the QMI service protocol are
> using their own definition of the service id. It is not a problem but
> it results on having those duplicated with different names but the
> same value and without consistency in their name.
>
> It makes more sense to unify their names and move the definitions in
> the QMI header file providing a consistent way to represent the
> supported protocols. Consequently the different drivers will use them
> instead of their own definition of the service id.
>
> Cc: Alex Elder <elder@kernel.org>
> Cc: Andrew Lunn <andrew+netdev@lunn.ch>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Jeff Johnson <jjohnson@kernel.org>
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Srinivas Kandagatla <srini@kernel.org>
> Cc: Konrad Dybcio <konradybcio@kernel.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: Kees Cook <kees@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Wesley Cheng <quic_wcheng@quicinc.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-wireless@vger.kernel.org
> Cc: ath10k@lists.infradead.org
> Cc: ath11k@lists.infradead.org
> Cc: ath12k@lists.infradead.org
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-remoteproc@vger.kernel.org
> Cc: linux-sound@vger.kernel.org
> ---
> Daniel Lezcano (8):
> soc: qcom: qmi: Enumerate the service IDs of QMI
> net: ipa: Use the unified QMI service ID instead of defining it
> locally
> net: drivers: wireless: ath: Use the unified QMI service ID instead of
> defining it locally
prefix for wireless drivers is simply wifi: <driver>:
so s/net: drivers: wireless:/wifi:/
> remoteproc: qcom: Use the unified QMI service ID instead of defining
> it locally
> slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of
> defining it locally
> soc: qcom: pdr: Use the unified QMI service ID instead of defining it
> locally
> ALSA: usb-audio: qcom: Use the unified QMI service ID instead of
> defining it locally
> samples: qmi: Use the unified QMI service ID instead of defining it
> locally
>
> drivers/net/ipa/ipa_qmi.c | 6 ++----
> drivers/net/wireless/ath/ath10k/qmi.c | 2 +-
> drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 -
> drivers/net/wireless/ath/ath11k/qmi.c | 2 +-
> drivers/net/wireless/ath/ath11k/qmi.h | 1 -
> drivers/net/wireless/ath/ath12k/qmi.c | 2 +-
> drivers/net/wireless/ath/ath12k/qmi.h | 1 -
> drivers/remoteproc/qcom_sysmon.c | 2 +-
> drivers/slimbus/qcom-ngd-ctrl.c | 5 ++---
> drivers/soc/qcom/pdr_interface.c | 4 ++--
> drivers/soc/qcom/pdr_internal.h | 3 ---
> drivers/soc/qcom/qcom_pd_mapper.c | 2 +-
> include/linux/soc/qcom/qmi.h | 12 ++++++++++++
> samples/qmi/qmi_sample_client.c | 2 +-
> sound/usb/qcom/qc_audio_offload.c | 2 +-
> sound/usb/qcom/usb_audio_qmi_v01.h | 1 -
You are touching a lot of subsystems with a single series.
How do you plan on having these land?
Do you have a maintainer who will take all of these through their tree?
> 16 files changed, 25 insertions(+), 23 deletions(-)
>
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v1 0/8] Group QMI service IDs into the QMI header
2026-03-09 23:50 ` [PATCH v1 0/8] Group QMI service IDs into the QMI header Jeff Johnson
@ 2026-03-10 0:09 ` Daniel Lezcano
2026-03-16 2:02 ` Bjorn Andersson
0 siblings, 1 reply; 28+ messages in thread
From: Daniel Lezcano @ 2026-03-10 0:09 UTC (permalink / raw)
To: Jeff Johnson, konradybcio, andersson
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
On 3/10/26 00:50, Jeff Johnson wrote:
> On 3/9/2026 4:03 PM, Daniel Lezcano wrote:
>> The different subsystems implementing the QMI service protocol are
>> using their own definition of the service id. It is not a problem but
>> it results on having those duplicated with different names but the
>> same value and without consistency in their name.
>>
>> It makes more sense to unify their names and move the definitions in
[ ... ]
> prefix for wireless drivers is simply wifi: <driver>:
> so s/net: drivers: wireless:/wifi:/
Noted, thanks
>> remoteproc: qcom: Use the unified QMI service ID instead of defining
>> it locally
>> slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of
>> defining it locally
>> soc: qcom: pdr: Use the unified QMI service ID instead of defining it
>> locally
>> ALSA: usb-audio: qcom: Use the unified QMI service ID instead of
>> defining it locally
>> samples: qmi: Use the unified QMI service ID instead of defining it
>> locally
>>
>> drivers/net/ipa/ipa_qmi.c | 6 ++----
>> drivers/net/wireless/ath/ath10k/qmi.c | 2 +-
>> drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 -
>> drivers/net/wireless/ath/ath11k/qmi.c | 2 +-
>> drivers/net/wireless/ath/ath11k/qmi.h | 1 -
>> drivers/net/wireless/ath/ath12k/qmi.c | 2 +-
>> drivers/net/wireless/ath/ath12k/qmi.h | 1 -
>> drivers/remoteproc/qcom_sysmon.c | 2 +-
>> drivers/slimbus/qcom-ngd-ctrl.c | 5 ++---
>> drivers/soc/qcom/pdr_interface.c | 4 ++--
>> drivers/soc/qcom/pdr_internal.h | 3 ---
>> drivers/soc/qcom/qcom_pd_mapper.c | 2 +-
>> include/linux/soc/qcom/qmi.h | 12 ++++++++++++
>> samples/qmi/qmi_sample_client.c | 2 +-
>> sound/usb/qcom/qc_audio_offload.c | 2 +-
>> sound/usb/qcom/usb_audio_qmi_v01.h | 1 -
>
> You are touching a lot of subsystems with a single series.
> How do you plan on having these land?
> Do you have a maintainer who will take all of these through their tree?
Yes I thought Bjorn or Konrad would take them with the acked-by from the
different subsystems
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 0/8] Group QMI service IDs into the QMI header
2026-03-10 0:09 ` Daniel Lezcano
@ 2026-03-16 2:02 ` Bjorn Andersson
0 siblings, 0 replies; 28+ messages in thread
From: Bjorn Andersson @ 2026-03-16 2:02 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Jeff Johnson, konradybcio, linux-kernel, Alex Elder, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jeff Johnson, Mathieu Poirier, Srinivas Kandagatla,
Jaroslav Kysela, Takashi Iwai, Kees Cook, Greg Kroah-Hartman,
Arnd Bergmann, Mark Brown, Wesley Cheng, netdev, linux-wireless,
ath10k, ath11k, ath12k, linux-arm-msm, linux-remoteproc,
linux-sound
On Tue, Mar 10, 2026 at 01:09:08AM +0100, Daniel Lezcano wrote:
> On 3/10/26 00:50, Jeff Johnson wrote:
> > On 3/9/2026 4:03 PM, Daniel Lezcano wrote:
> > > The different subsystems implementing the QMI service protocol are
> > > using their own definition of the service id. It is not a problem but
> > > it results on having those duplicated with different names but the
> > > same value and without consistency in their name.
> > >
> > > It makes more sense to unify their names and move the definitions in
>
> [ ... ]
>
> > prefix for wireless drivers is simply wifi: <driver>:
> > so s/net: drivers: wireless:/wifi:/
>
> Noted, thanks
>
> > > remoteproc: qcom: Use the unified QMI service ID instead of defining
> > > it locally
> > > slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of
> > > defining it locally
> > > soc: qcom: pdr: Use the unified QMI service ID instead of defining it
> > > locally
> > > ALSA: usb-audio: qcom: Use the unified QMI service ID instead of
> > > defining it locally
> > > samples: qmi: Use the unified QMI service ID instead of defining it
> > > locally
> > >
> > > drivers/net/ipa/ipa_qmi.c | 6 ++----
> > > drivers/net/wireless/ath/ath10k/qmi.c | 2 +-
> > > drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 -
> > > drivers/net/wireless/ath/ath11k/qmi.c | 2 +-
> > > drivers/net/wireless/ath/ath11k/qmi.h | 1 -
> > > drivers/net/wireless/ath/ath12k/qmi.c | 2 +-
> > > drivers/net/wireless/ath/ath12k/qmi.h | 1 -
> > > drivers/remoteproc/qcom_sysmon.c | 2 +-
> > > drivers/slimbus/qcom-ngd-ctrl.c | 5 ++---
> > > drivers/soc/qcom/pdr_interface.c | 4 ++--
> > > drivers/soc/qcom/pdr_internal.h | 3 ---
> > > drivers/soc/qcom/qcom_pd_mapper.c | 2 +-
> > > include/linux/soc/qcom/qmi.h | 12 ++++++++++++
> > > samples/qmi/qmi_sample_client.c | 2 +-
> > > sound/usb/qcom/qc_audio_offload.c | 2 +-
> > > sound/usb/qcom/usb_audio_qmi_v01.h | 1 -
> >
> > You are touching a lot of subsystems with a single series.
> > How do you plan on having these land?
> > Do you have a maintainer who will take all of these through their tree?
>
> Yes I thought Bjorn or Konrad would take them with the acked-by from the
> different subsystems
As we haven't received any such acks, I pulled patch 1 into an immutable
branch and pushed it here:
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git 20260309230346.3584252-2-daniel.lezcano@oss.qualcomm.com
Other maintainers can use this to pull respective changes, or you can
repost the individual patches with this (or follow up once it's in
-rc1).
Regards,
Bjorn
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 0/8] Group QMI service IDs into the QMI header
2026-03-09 23:03 [PATCH v1 0/8] Group QMI service IDs into the QMI header Daniel Lezcano
` (8 preceding siblings ...)
2026-03-09 23:50 ` [PATCH v1 0/8] Group QMI service IDs into the QMI header Jeff Johnson
@ 2026-03-10 0:11 ` Dmitry Baryshkov
2026-03-16 2:02 ` (subset) " Bjorn Andersson
2026-03-18 13:50 ` Bjorn Andersson
11 siblings, 0 replies; 28+ messages in thread
From: Dmitry Baryshkov @ 2026-03-10 0:11 UTC (permalink / raw)
To: Daniel Lezcano
Cc: konradybcio, andersson, linux-kernel, Alex Elder, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jeff Johnson, Mathieu Poirier, Srinivas Kandagatla,
Jaroslav Kysela, Takashi Iwai, Kees Cook, Greg Kroah-Hartman,
Arnd Bergmann, Mark Brown, Wesley Cheng, netdev, linux-wireless,
ath10k, ath11k, ath12k, linux-arm-msm, linux-remoteproc,
linux-sound
On Tue, Mar 10, 2026 at 12:03:29AM +0100, Daniel Lezcano wrote:
> The different subsystems implementing the QMI service protocol are
> using their own definition of the service id. It is not a problem but
> it results on having those duplicated with different names but the
> same value and without consistency in their name.
>
> It makes more sense to unify their names and move the definitions in
> the QMI header file providing a consistent way to represent the
> supported protocols. Consequently the different drivers will use them
> instead of their own definition of the service id.
Also this looks like a first step towards providing qrtr service debugfs
in the kernel.
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: (subset) [PATCH v1 0/8] Group QMI service IDs into the QMI header
2026-03-09 23:03 [PATCH v1 0/8] Group QMI service IDs into the QMI header Daniel Lezcano
` (9 preceding siblings ...)
2026-03-10 0:11 ` Dmitry Baryshkov
@ 2026-03-16 2:02 ` Bjorn Andersson
2026-03-18 13:50 ` Bjorn Andersson
11 siblings, 0 replies; 28+ messages in thread
From: Bjorn Andersson @ 2026-03-16 2:02 UTC (permalink / raw)
To: konradybcio, Daniel Lezcano
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
On Tue, 10 Mar 2026 00:03:29 +0100, Daniel Lezcano wrote:
> The different subsystems implementing the QMI service protocol are
> using their own definition of the service id. It is not a problem but
> it results on having those duplicated with different names but the
> same value and without consistency in their name.
>
> It makes more sense to unify their names and move the definitions in
> the QMI header file providing a consistent way to represent the
> supported protocols. Consequently the different drivers will use them
> instead of their own definition of the service id.
>
> [...]
Applied, thanks!
[6/8] soc: qcom: pdr: Use the unified QMI service ID instead of defining it locally
commit: 24f80cbe0b8f4c6b27d03c7a7ad707d76c1c4885
[8/8] samples: qmi: Use the unified QMI service ID instead of defining it locally
commit: 8baf6b3b7695849581a91bdaf66af2be68ef32ed
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: (subset) [PATCH v1 0/8] Group QMI service IDs into the QMI header
2026-03-09 23:03 [PATCH v1 0/8] Group QMI service IDs into the QMI header Daniel Lezcano
` (10 preceding siblings ...)
2026-03-16 2:02 ` (subset) " Bjorn Andersson
@ 2026-03-18 13:50 ` Bjorn Andersson
11 siblings, 0 replies; 28+ messages in thread
From: Bjorn Andersson @ 2026-03-18 13:50 UTC (permalink / raw)
To: konradybcio, Daniel Lezcano
Cc: linux-kernel, Alex Elder, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jeff Johnson,
Mathieu Poirier, Srinivas Kandagatla, Jaroslav Kysela,
Takashi Iwai, Kees Cook, Greg Kroah-Hartman, Arnd Bergmann,
Mark Brown, Wesley Cheng, netdev, linux-wireless, ath10k, ath11k,
ath12k, linux-arm-msm, linux-remoteproc, linux-sound
On Tue, 10 Mar 2026 00:03:29 +0100, Daniel Lezcano wrote:
> The different subsystems implementing the QMI service protocol are
> using their own definition of the service id. It is not a problem but
> it results on having those duplicated with different names but the
> same value and without consistency in their name.
>
> It makes more sense to unify their names and move the definitions in
> the QMI header file providing a consistent way to represent the
> supported protocols. Consequently the different drivers will use them
> instead of their own definition of the service id.
>
> [...]
Applied, thanks!
[8/8] samples: qmi: Use the unified QMI service ID instead of defining it locally
commit: 8baf6b3b7695849581a91bdaf66af2be68ef32ed
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 28+ messages in thread