From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35C9B4279FA for ; Mon, 9 Mar 2026 23:05:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097557; cv=none; b=lfxNNbHZout0TA0ghHHSXEL2oPP8DRqZY4KmfQv5B6lWjw3a2EZg+awwXCfvo/T/fXp0HShEiXdMCTc3By3FOeHtedeP4nhZ3pCZ0ONoir1eNTGoK7/x30hV3ehtB1joIVhUtbmhpBcW54d44d20xQQs3vLYpCjeBdqF8BxcEtY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097557; c=relaxed/simple; bh=ulxSsa7188EBz+8PhYCrmatbVk0Sh+N5SiDD0XnhX7Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hdCnNo1xsT7Q81Bj7346kuiu1krpO21Pqah/KlE637cDY90nNNXbh5tO0rUF0XZWFnpJJ8OrLnJvkIzi+YqYqgg3EIDAJWahFpZL0DjJCepzXtJX3NOS9DC0yfaC9Gt+0GOVrkycSvMaOSKURhHeieHM13w2oqLaRb7agpoheZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PaYhT6ey; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=heE5DFLZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PaYhT6ey"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="heE5DFLZ" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629HBtjZ1921304 for ; Mon, 9 Mar 2026 23:05:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=/gz4Ge3MHwk UDTTkujrW9dZ+6p+ProQlBVOR/K4PwRg=; b=PaYhT6eylqd83bpMQFYbYaV0W5S mkzH1MgbfuAvBJ/7ojSkvwmB2brtv9Dy0UGX8UfrUnxTxvdkTdNan6OUS2+NvZ3e sF4nS+5Yv9L3QfuMDCsD6Y+UAuJmb43YTmwqFS/Gys81rzF0MMxK7v08rJZhdA1b WV2fQRVJm2zf+akHmBl5+inla5z3FhhzRUmrUlgsAKzOM7bgrX6B1OO3v2UxpUMA AYOSjkMi2Tv+TU2zS8pwaDgeJpYWAu2pVQBaPXzhjOTfhZ+VLz3I6w89RDpVfuLp GxB1r5AI7dmq8fbxWWH/M/nZkJFhPG1GwJ7GLHTCooGJvaSAAf/y037ZHYw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csxy81uw8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 23:05:55 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd7d66afceso1295837485a.3 for ; Mon, 09 Mar 2026 16:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773097555; x=1773702355; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/gz4Ge3MHwkUDTTkujrW9dZ+6p+ProQlBVOR/K4PwRg=; b=heE5DFLZZBFfzHQy57r9wHCcM5YyZkfzpeXU2HCzt/OvFiUW/GmmCMHNUKMFHibU9c yP4bGFgz/mapyRq735LKe9UDNwcX1Sm3nJhW8scXKUSJvK+xYC6O1p2h/Sh746jQfc9f 8dU9JpiWIOplw9CKZL4pUEe4UWJ1vC1lMybwsRSMqBQqCMFgU6f9IGs+f6urSWiIYHzu yi/zvoGtPs+CGXb6QOZDdISu7Bt9YXMJ1EgEhNevR+KEvdK/S72EbScaUAZYCWCbyfUN U3J3ya5ezlxjBm5Y6GZ1D9s4eVEZrJBI9YDE7oP7FprjG9WvTGPmjW85bODcPm/CXPem OjgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773097555; x=1773702355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/gz4Ge3MHwkUDTTkujrW9dZ+6p+ProQlBVOR/K4PwRg=; b=AGjPBlrewuijILQmHfDcw6DXefVJA5twzsiwT6NW6QcsgUiAui8Ww01cg588owcV4v sYJ6+dewLAmmzTW+GLEArVqJGkfA4ou8zHtA54TIJzm/VTGYkGFd8uapwYp3JJjnDYwG 8l8eIcGmmpJH18gsRyyT43rZGsk4Uo+uSIqG34oqLNzUxiPeDChNoZuHxtB/Q05e7Xci Bz7myBdBe2Lby7vaHQrVtt1ktKmBpHPnc8YEdmIP/Pr2YtEcVgMVNSLp+zRFoRYQsX3a AJEeIirSqtPnfewGOCFZxEsM9Kt0boGZiBZh8L9/J/yYmGAo/8jsSNcJRyoyvKS1qMKr RLhg== X-Forwarded-Encrypted: i=1; AJvYcCXN1lvOJjm/35s4iHD/LzMj1IeKzCi5QD9CvY5M7ba40HoAu4ljNpfT3mUt/9M+3arfLzt/LqQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzN5wQBTeHhN8u4RI7c5QmRdpK5liAcZ2GfrwKXrMQmLT0WeEUN Vd5/V6GeZ9HzzI+XbmtNq037+Uxp0EB+0u24d4zeG0N6N5h5KzLjimhLfGEcoGs00cRb1EGohkU HiNS4ZXvwhws/HJ/pYBn7wUnYf3zZ1QmGx/iXjSOxjqB/dGwwu/iiH86DtB4= X-Gm-Gg: ATEYQzy8+Xp4LTwJUXRnLlhZfqPDuaOhTkI+/87q64IYABCFDkbrSBF+7DiApVEQUL1 U+GaEs8k8gVsmggaZPHw/YvQM9aCIaZ3LQAgc4zbF/jRyxue/tU5UNX6p+x4N8qTw+ge5rc7T6I PFq7r5EGwyDCnl11z4UEmhwI95shJhKHEjLi8BAztl6y38v11hfqetXJlJGsSUKrY0lv/JwHjSF NzEfEZ/GJ/YI/oUSOSyDBIAudUMbtxnpEGrCe2HM74fNI73vY/wUtViOZgNqwh+UH6XQXkg9qdA 4kLu31hmsyVZIsRxRpiYWAhcqgknE0sD8F2G0CHTmkdVRdgGl6K0QCIEZADFZeQl4R8c5seJeOo Cuu61Qaj8jYB29zXmfqUSB9W9Xu6Rrs5qeFvCHcaxqodTDQbmGQ== X-Received: by 2002:a05:620a:1728:b0:8cd:8e8c:2076 with SMTP id af79cd13be357-8cd8e8c242dmr439788685a.77.1773097554722; Mon, 09 Mar 2026 16:05:54 -0700 (PDT) X-Received: by 2002:a05:620a:1728:b0:8cd:8e8c:2076 with SMTP id af79cd13be357-8cd8e8c242dmr439783485a.77.1773097554104; Mon, 09 Mar 2026 16:05:54 -0700 (PDT) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:ae20:597c:99b8:d161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae3d98asm33898478f8f.30.2026.03.09.16.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 16:05:53 -0700 (PDT) From: Daniel Lezcano To: konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org Subject: [PATCH v1 5/8] slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of defining it locally Date: Tue, 10 Mar 2026 00:03:34 +0100 Message-ID: <20260309230346.3584252-6-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=SvmdKfO0 c=1 sm=1 tr=0 ts=69af5253 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=PhtMypRRY1SmXJO8NnMA:9 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: kB2KpyrkICm0249ovs-MwH4dohmslUTR X-Proofpoint-ORIG-GUID: kB2KpyrkICm0249ovs-MwH4dohmslUTR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDIwNCBTYWx0ZWRfX1EitL+wC9xZH TP8H6iSLR02ldYxW4rNk9Xm8DvrQ2RL3EUIyersRRTtZVkbBVzsrdN8gqQCaZu7PcjwppceuioK DdhASYcu+cOIZCinjQkHm9zzAuvNADtG5GU45L58yvi4XXVrxek3CH73Yhh1LhJkWQGoW0b459Y 8J1XSkfWRabhOBqHG65384pF9rDYr9nPjqWduBtWzN/bAgBgWL9EZOVpb+cr4pHxCPswwQ+MH39 Y6VSbRjxuOU2+gzOJ7Wyy2QdAcn8XO4RounB/uiiFNAEE7lhcpOKvT6I26rJCLZIUXx9l+21/U6 s4xcSFixz5kCQE5G4PKNnwWZiVZR1CWTIwESfAGIr1b+6imVsD2JufD/jZLoczG8Lq1Qb8GNZGm iF6hMhJVq8Q8REn4Mqi9IidjqRxvfFJZNn8fhqRPSAsOaKXUUy0oBdUTGJJrqd7Yv6XhOCMSqxm hhiMd5l0ZtvdvW2iOGg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_06,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 spamscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 adultscore=0 bulkscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090204 Instead of defining a local macro with a custom name for the QMI service identifier, use the one provided in qmi.h and remove the locally defined macro. Signed-off-by: Daniel Lezcano --- drivers/slimbus/qcom-ngd-ctrl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index 9aa7218b4e8d..0b88b8577bdb 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -48,7 +48,6 @@ NGD_INT_RX_MSG_RCVD) /* Slimbus QMI service */ -#define SLIMBUS_QMI_SVC_ID 0x0301 #define SLIMBUS_QMI_SVC_V1 1 #define SLIMBUS_QMI_INS_ID 0 #define SLIMBUS_QMI_SELECT_INSTANCE_REQ_V01 0x0020 @@ -1408,8 +1407,8 @@ static int qcom_slim_ngd_qmi_svc_event_init(struct qcom_slim_ngd_ctrl *ctrl) return ret; } - ret = qmi_add_lookup(&qmi->svc_event_hdl, SLIMBUS_QMI_SVC_ID, - SLIMBUS_QMI_SVC_V1, SLIMBUS_QMI_INS_ID); + ret = qmi_add_lookup(&qmi->svc_event_hdl, QMI_SERVICE_ID_SLIMBUS, + SLIMBUS_QMI_SVC_V1, SLIMBUS_QMI_INS_ID); if (ret < 0) { dev_err(ctrl->dev, "qmi_add_lookup failed: %d\n", ret); qmi_handle_release(&qmi->svc_event_hdl); -- 2.43.0