From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 337CF3D171F; Tue, 10 Mar 2026 17:19:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773163182; cv=none; b=RHTjX0n0bpFzgJ0sRzQam7o1fv7Z60v8ro23VMGuU1DDMF0gRd82B8zIsOn3Omny1lEA0pP0ZSvcN7aeriiaN0okXgKO8CPQ2ZnKOkFYOBqLDKgFKnwsU+GC5AbK84boVC5Vn6WT6DHdTqDD98VlOZpqsZ7/KXB7Yj2p7ur/noE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773163182; c=relaxed/simple; bh=9DLc73kRovjX7PmKOfMC6v7DvLF8VkwF6ivlc5RlT3Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Tsdb0Phr0XLdrY/ZSTcFt06ipBCG2cb1uOLhDbVdbtuwE9pzjyZOv5DhTtaBizZ+YlxyTwH8er8iTZ8kO639L86n/mg0nPJz5vYBJT1qKguM+GZyKhYxNWudc6vkiY5KwirwhlIjsPrX67r+q09B63hay5d6IXa4INYEDlofRRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LtNAAwQZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LtNAAwQZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C550FC19425; Tue, 10 Mar 2026 17:19:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773163182; bh=9DLc73kRovjX7PmKOfMC6v7DvLF8VkwF6ivlc5RlT3Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LtNAAwQZEWoDaAVsZHl1xlcSy7lWlO+9QwLPUxI/j1WH8mjZNBBiXqbvRWc+1cTl0 yf65f6i5wm4OoeL6y/p7qP4wgiXmpU++qxFmuroYpxz092UuB4XGlAwW5KM3rKiFJ4 1wnQugkZyQkkK5FWVkpLlQiGsdtX8pgqRw2qwH7SjuevLgVdgKfTwNlw5jATGRqL7b UQAe/oUSFq51MMTusYKQem69YHjxqI7CAWL4y7n4b3VhCdPVRIpndKratErDEhT8C0 ibf6dXW320EKvo/40yN6YK3lOxWzCuuxhdaTHHPC4jEbfxeclrF1tkokWvTVUshSWJ 6LDCnONlQA/3Q== From: Conor Dooley To: netdev@vger.kernel.org Cc: conor@kernel.org, Conor Dooley , Valentina.FernandezAlanis@microchip.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daire McNamara , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Nicolas Ferre , Claudiu Beznea , Richard Cochran , Samuel Holland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Dave Stevenson , Sean Anderson , Vineeth Karumanchi , Abin Joseph , =?UTF-8?q?Th=C3=A9o=20Lebrun?= , Ryan.Wanner@microchip.com Subject: [PATCH net-next v3 10/10] net: macb: timer adjust mode is not supported Date: Tue, 10 Mar 2026 17:17:17 +0000 Message-ID: <20260310-faceplate-ashy-ca696dd4433d@spud> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260310-moneyless-dispense-7bce14b16388@spud> References: <20260310-moneyless-dispense-7bce14b16388@spud> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1214; i=conor.dooley@microchip.com; h=from:subject:message-id; bh=OqQujPb90kYRx/KgLbRe0CGbTbZ7JG8YWaMugKJ3peY=; b=owGbwMvMwCVWscWwfUFT0iXG02pJDJkbgvSn2dU3zSp7xibx5n+F55T0t6LBly+n+V/a6rj7U lmTilJERykLgxgXg6yYIkvi7b4WqfV/XHY497yFmcPKBDKEgYtTACZyfC8jw2O2H3Vyrcb5uad6 n3RGHli0cf8a9U3LEm57c8XU/td7FcrIsCJOWXFGy4Ub+RpM+n//zbhYe6LqV3jzjIUrZN/d01q mwQ4A X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C Content-Transfer-Encoding: 8bit From: Conor Dooley The ptp portion of this driver controls the tsu's timer using the controls for "increment mode", which is not compatible with the hardware trying to control it via the gem_tsu_inc_ctrl and gem_tsu_ms inputs in "timer adjust mode". Abort probe if the property signalling that the relevant signals have been wired up is present. Signed-off-by: Conor Dooley --- drivers/net/ethernet/cadence/macb_main.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 38e75c2e097bf..3e0ab23e9b9b0 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -5577,6 +5577,13 @@ static int macb_probe(struct platform_device *pdev) bp->usrio = macb_config->usrio; + if (of_property_read_bool(bp->pdev->dev.of_node, "cdns,timer-adjust") && + IS_ENABLED(CONFIG_MACB_USE_HWSTAMP)) { + dev_err(&pdev->dev, "Timer adjust mode is not supported\n"); + err = -EINVAL; + goto err_out_free_netdev; + } + /* By default we set to partial store and forward mode for zynqmp. * Disable if not set in devicetree. */ -- 2.51.0