From: Vladimir Oltean <olteanv@gmail.com>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: mxl862xx: don't set user_mii_bus
Date: Tue, 10 Mar 2026 11:11:15 +0200 [thread overview]
Message-ID: <20260310091115.j2aqdk3ikodffoei@skbuf> (raw)
In-Reply-To: <0f0df310fd8cab57e0e5e3d0831dd057fd05bcd5.1773103271.git.daniel@makrotopia.org>
On Tue, Mar 10, 2026 at 12:41:56AM +0000, Daniel Golle wrote:
> The PHY addresses in the MII bus are not equal to the port addresses,
> so the bus cannot be assigned as user_mii_bus. Falling back on the
> user_mii_bus in case a PHY isn't declared in device tree will result in
> using the wrong (in this case: off-by-+1) PHY.
> Remove the wrong assignment.
>
> Fixes: 23794bec1cb60 ("net: dsa: add basic initial driver for MxL862xx switches")
> Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
next prev parent reply other threads:[~2026-03-10 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 0:41 [PATCH net] net: dsa: mxl862xx: don't set user_mii_bus Daniel Golle
2026-03-10 9:11 ` Vladimir Oltean [this message]
2026-03-11 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310091115.j2aqdk3ikodffoei@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox