From: Simon Horman <horms@kernel.org>
To: Atharva Tiwari <atharvatiwarilinuxdev@gmail.com>
Cc: Vincent MORVAN <vinc@42.fr>, Paul SAGE <paul.sage@42.fr>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tg3: replace placeholder MAC address with device property
Date: Tue, 10 Mar 2026 16:16:52 +0000 [thread overview]
Message-ID: <20260310161652.GJ461701@kernel.org> (raw)
In-Reply-To: <20260306170657.39384-1-atharvatiwarilinuxdev@gmail.com>
On Fri, Mar 06, 2026 at 10:36:55PM +0530, Atharva Tiwari wrote:
...
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index 75f66587983d..b9950651b20c 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -17030,6 +17030,14 @@ static int tg3_get_invariants(struct tg3 *tp, const struct pci_device_id *ent)
> return err;
> }
>
> +static int tg3_is_default_mac_address(u8 *addr)
> +{
> + u32 addr_high = (addr[0] << 16) | (addr[1] << 8) | addr[2];
> + u32 addr_low = (addr[3] << 16) | (addr[4] << 8) | addr[5];
> +
> + return addr_high == 0x00001018 && addr_low == 0;
Hi Paul and Atharva,
I think you can use ether_addr_equal(), or some variant of it, here.
> +}
...
prev parent reply other threads:[~2026-03-10 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 17:06 [PATCH v2] tg3: replace placeholder MAC address with device property Atharva Tiwari
2026-03-10 16:16 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310161652.GJ461701@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=atharvatiwarilinuxdev@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.sage@42.fr \
--cc=pavan.chebbi@broadcom.com \
--cc=vinc@42.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox