From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F7D33DFC9F;
	Wed, 11 Mar 2026 16:47:00 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1773247620; cv=none; b=NUXhbzwq1YtX9ur7VbhbdP7Lg+TA/AU2PVTCYMCP5yeuKPNxlExLOEAvI+rivf3kEalNiPcga3DlgkR2OpTpLiD1IlApOSz/8VRUJBGd5EZ1AjgzXK1IBI4BlBjIT41QoDgv+dOXEx0dHKOCV+1B/etpZpSk1PqZheml9wvK4Zw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1773247620; c=relaxed/simple;
	bh=V+csIuFPiZnGbvUKN3wg+wCohRFfe/drD2mEXp8Rcck=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=nvNllmwCTVAShIjmuezvmq/jD4WjFh4pbAtF+TB7F+rzJv4fOQx06Lahy2gpkPMfbK9BuTmUiMUJ4GQ+AyavVt5FHFPILM79MbpvCdCI9rcspDWEEfl9/T2bkbfia4fNaBhLqwgmjnwRiYfDUIHrQJ8IXi5crsQdDIzK9drLOFA=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZehxxsSB; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZehxxsSB"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DBE0C4CEF7;
	Wed, 11 Mar 2026 16:46:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1773247620;
	bh=V+csIuFPiZnGbvUKN3wg+wCohRFfe/drD2mEXp8Rcck=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=ZehxxsSBqg+PjVX4E0wThvLzSFr1QBAENhA6oI8QhEnsFcl9kzAq3IN0UGFdRPmb+
	 /t1kNA5/p8vSF149L1u70QxmSzYQrN9up6kBiTxLjd5sCT7ZjIkQGpDnggU1xjyTxG
	 WHUN4WuydbXM+AivHKWOM8Hpj+GyCQmflAdI/6fdgUZjhfrdyh0ye4Zs37xx5RmMRl
	 fyHCn/qIxFALdeS6bnTGAIlWF5OsWknK9OxScxG8R00dsiZ73lszUXEkb9zn/B5Y9b
	 R0Vg+FjSqXcWJ1ZN0jT01IgC+gp+RkbMVJvQJIH+djCuUSJGgnNkNLYNX0iBbL3OEn
	 ZWiDgMdfus7eQ==
Date: Wed, 11 Mar 2026 16:46:53 +0000
From: Simon Horman <horms@kernel.org>
To: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
	decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, kotaranov@microsoft.com,
	shradhagupta@linux.microsoft.com, dipayanroy@linux.microsoft.com,
	yury.norov@gmail.com, kees@kernel.org, shirazsaleem@microsoft.com,
	linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: mana: Expose hardware diagnostic info
 via debugfs
Message-ID: <20260311164653.GS461701@kernel.org>
References: <20260309143840.675606-1-ernis@linux.microsoft.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260309143840.675606-1-ernis@linux.microsoft.com>

On Mon, Mar 09, 2026 at 07:38:28AM -0700, Erni Sri Satya Vennela wrote:

...

> diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c b/drivers/net/ethernet/microsoft/mana/gdma_main.c

...

> @@ -2128,6 +2140,9 @@ int mana_gd_suspend(struct pci_dev *pdev, pm_message_t state)
>  
>  	mana_gd_cleanup(pdev);
>  
> +	debugfs_remove_recursive(gc->mana_pci_debugfs);
> +	gc->mana_pci_debugfs = NULL;

Hi Erni,

The same cleanup of mana_pci_debugfs already appears in a couple of other
places. It seems that all such cleanup is now paired with a call to
mana_gd_cleanup().

So could you consider performing the mana_pci_debugfs cleanup in
mana_gd_cleanup()? Possibly also renaming that function?

> +
>  	return 0;
>  }
>  
> @@ -2140,6 +2155,12 @@ int mana_gd_resume(struct pci_dev *pdev)
>  	struct gdma_context *gc = pci_get_drvdata(pdev);
>  	int err;
>  
> +	if (gc->is_pf)
> +		gc->mana_pci_debugfs = debugfs_create_dir("0", mana_debugfs_root);
> +	else
> +		gc->mana_pci_debugfs = debugfs_create_dir(pci_slot_name(pdev->slot),
> +							  mana_debugfs_root);

Likewise the setup of mana_pci_debugfs seems to now always be paired
with a call to mana_gd_setup().

> +
>  	err = mana_gd_setup(pdev);
>  	if (err)
>  		return err;

...