From: Jakub Kicinski <kuba@kernel.org>
To: tobgaertner <tob.gaertner@me.com>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
gregkh@linuxfoundation.org, oneukum@suse.com, bjorn@mork.no
Subject: Re: [PATCH v2 1/2] net: usb: cdc_ncm: add ndpoffset to NDP16 nframes bounds check
Date: Wed, 11 Mar 2026 18:53:20 -0700 [thread overview]
Message-ID: <20260311185320.29e5aa7d@kernel.org> (raw)
In-Reply-To: <20260309203449.2594858-2-tob.gaertner@me.com>
On Mon, 9 Mar 2026 13:34:48 -0700 tobgaertner wrote:
> From: tobgaertner <tob.gaertner@me.com>
the From line should match your SoB tag
You probably need to commit --amend --reset-author
> - if ((sizeof(struct usb_cdc_ncm_ndp16) +
> - ret * (sizeof(struct usb_cdc_ncm_dpe16))) > skb_in->len) {
> + if (ndpoffset + struct_size_t(struct usb_cdc_ncm_ndp16,
> + dpe16, ret) > skb_in->len) {
> netif_dbg(dev, rx_err, dev->net, "Invalid nframes = %d\n", ret);
nit: maybe save the size of the struct to a temp variable?
To avoid the awkward line wrap
next prev parent reply other threads:[~2026-03-12 1:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 20:34 [PATCH v2 0/2] net: usb: cdc_ncm: fix NDP nframes bounds check tobgaertner
2026-03-09 20:34 ` [PATCH v2 1/2] net: usb: cdc_ncm: add ndpoffset to NDP16 " tobgaertner
2026-03-12 1:53 ` Jakub Kicinski [this message]
2026-03-09 20:34 ` [PATCH v2 2/2] net: usb: cdc_ncm: add ndpoffset to NDP32 " tobgaertner
2026-03-12 1:53 ` Jakub Kicinski
2026-03-11 17:17 ` [PATCH v2 0/2] net: usb: cdc_ncm: fix NDP " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260311185320.29e5aa7d@kernel.org \
--to=kuba@kernel.org \
--cc=bjorn@mork.no \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=tob.gaertner@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox