From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A027232B98A; Thu, 12 Mar 2026 03:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773286630; cv=none; b=QQMgDThQd2TTGFyWnUqQTwh4IBjs6mwXYVRQ22bd39v7lAbGjWTfFJ0cNKnLw27EgpXa06v9IlS/LRBJ1hFptrhcPsMXpnpNVlMUASRW6aOJ7/d5cJSBf+II0OqmpzxwU/gk3hbM/Hgx1XZzSB4/RuQmfl0nFrW58VFFiuiwPOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773286630; c=relaxed/simple; bh=sJfbpv0cFhrG9HZt+fsACC7pn1MLtg8z11mYBSar9xA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Co4lNEZnsbX9s+aLYlrRtq3XKJ47y720/b9NqzLHgLM/dIlTW54cENqQawEspay6WMLbCkeMuaqNMFChRqP8T3nCyspu3q6MOXNluIkacOlTKn0bo1nDl7x/4x6s3cRMp6mE+6ZdrQb7spqq5E/rrExoQGnhPLmrEXjXvoHK+QU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IGbGB67m; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IGbGB67m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B1EEC4CEF7; Thu, 12 Mar 2026 03:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773286630; bh=sJfbpv0cFhrG9HZt+fsACC7pn1MLtg8z11mYBSar9xA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IGbGB67mDMMpmHF3SDOFpmf4xmV/KbBqkj15/sPwkFU6+Y6Wto1mBwMUZfmyotisi /Dt5PDTFZaWT5uY7EZ1/64o4LRAfDhmtyahZ+opdXN3Ys+g/X6vYnUP2Jn6LhKPPqv XtssRw1xT31UjSTPLJF5L1Hl3h0Uud/SYmeNGiusUNtgquVoVaGq2K5Nhn90yHtuaI 84lC+XW1hSNT4lBa8e3r5Vm+GMT+Rh8m3IRItGYnl/QA/nthOaRTAzpMWpqZErd4P6 zEAS/1wYIxtS5puOktW6fz6FzOtOoJSp9ttNjmCCbru8Lx2Dp+c0Rp6RMuVmgczAF9 odhbJxVnfPxKA== Date: Wed, 11 Mar 2026 20:37:07 -0700 From: Jakub Kicinski To: Jan Petrous via B4 Relay Cc: jan.petrous@oss.nxp.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , NXP S32 Linux Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, rmk+kernel@armlinux.org.uk, vladimir.oltean@nxp.com, boon.khai.ng@altera.com Subject: Re: [PATCH v8 1/5] net: stmmac: Use helper macro for loop over queue-based arrays Message-ID: <20260311203707.1d5ba94c@kernel.org> In-Reply-To: <20260309-dwmac_multi_irq-v8-1-f0cc5bc811a7@oss.nxp.com> References: <20260309-dwmac_multi_irq-v8-0-f0cc5bc811a7@oss.nxp.com> <20260309-dwmac_multi_irq-v8-1-f0cc5bc811a7@oss.nxp.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 09 Mar 2026 18:55:20 +0100 Jan Petrous via B4 Relay wrote: > The stmmac driver contains similar pattern for processing queue-based > arrays, ie. interrupt lines, etc. Factor out the for loop and provide > a macro STMMAC_FOREACH_MTL_QUEUE(var, limit). This is macro is neither shorter nor more readable. I really don't see any benefit here.. -- pw-bot: cr