From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FD0E3BD254 for ; Thu, 12 Mar 2026 10:04:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773309855; cv=none; b=h88zHNcR0wS6bVruRUZU/od2Lbt3eXF72qJuTxW2J30lD4sZ5BBWQYwc3fcgDsykZ23qjc6afgq5tHcffRNsgmWOT3kWpU/ZOupMeu5PWm5VVJAyrfa0XRHpeZMqgWqA+P1iZDcQLgsffxupDMkrCut3ZM1RCdhFtVybHg1Z6DU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773309855; c=relaxed/simple; bh=Vtm80qE6FuR56bwzyqwTxutZyqLSGPZTe2b3PkwM178=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K3StECO5Wj/5QayUUi2W6CiiKZ5ZdChoNcnP7SP8DWVvEcCK07LGd063zLNc4aT41TDfAt1ZU4RROYeuusSv98CCfbTo6Na4Ckz8u9qab1Ezf6aTh/GhJ52f0DpwdFF5jOWQbnyi+ramS4J9YuKdtLx+JimwkAt1+Ih132mYTnY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=UuGFrvqL; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="UuGFrvqL" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-485445e80bdso7044355e9.0 for ; Thu, 12 Mar 2026 03:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1773309853; x=1773914653; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HEWuug6YBMXUGRBONZQ2DbkIBf5q1GxD8BXyAd3vMMw=; b=UuGFrvqLIk2QH17vam2M68KVzf4VxO9Okf4knKwat2Ghw6FJ7A4oAd1vwOtks37Uz/ olYnXO3NIUYECNqFEbMrULA/rKd+DMX+1LM0KJlB/vWO2xlL5UwOsT4CmmVhYfFc90Wd JPtb6eP9wLzHKPOiazn+gr4DCJtiDm2WAyLffki1EwahEsfo20F//LbPU7wWbn5KDSOQ 5smyc+m62FrVpBUl7FbDlCFbDb9tq7/r8oQHID5EPeXhCs0CkEuP+fT/UC3ES07v9unw Edv2a2TzrEOA7CYxIguTkXJAZCjLGXJ6gu8Ez5sQyyQAs5yY0TXKtJoim+m+Juls1B6C ki9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773309853; x=1773914653; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HEWuug6YBMXUGRBONZQ2DbkIBf5q1GxD8BXyAd3vMMw=; b=xRIcG8eAaDV2Y/BUgHXD2HkFOwLFGcT2u9j2yy3AUUqF2aWdCO1HG+cFXHngoC4iMO 3os57/dOSlqy7aERTMpJh+3cCEE+f+1j8obXG6QH8y6Y8E4e25uRtcjGAUxwi1N40SqD xDr1oKiXQo10tWvHd3tWhbc0uZ8zn1LSrNhSND7e0+ZtEVRPFaDlHxGuSYaWHre1CZjd eJ3VgYJPWocywXLzjhIGSsK8x+ds1AI+ftoynG40NcQUl/4Vcef0ccgW7q08ty8WVcAQ xj6H0VQaW0HnJcMgVGwDYgsgzycsyCb6smY49EjPPv8nEgeOxu2k3+w/ZtdLNyAg2hzp 0Asw== X-Gm-Message-State: AOJu0Yy0rM35BipIqECF7D8LkJCR0qxSpiPOmx6nfy+d+7qGXlBRCgco nMw5AR82yKXHsE5J32tHJsceaWkNJIvT7BAX+sU56lvsUwXZCrKUu5NwlExUXC6PVqhLZarfyP6 CIr9GaCCkLg== X-Gm-Gg: ATEYQzyzvAnmPjRDsXqsa4VbhbK4goH1Wd+gnUHUSwB93wWE841EH5UiHE8iJhdeu8d O0bb3od4DBQ6ELWQlmY5JkxCPGeCUBAfxISdIdXTaR85ieaziOzGM0qocx9+L5gLaO5zXY5wIXj CwF3hkzpnFF9WAnqe7VwEmJ0ceWuYzguKs+iNfx2H0QTHMhnP59+ivSZTCOxtT4utwBawGgDs9G E4olLfP9PK+hrVQu/imIQoNhjf6wbV09zqodQ2gm+bZkZdSdkMRSd/tVzSuOUm4y6NSQqN9bATe GWecHMCY0dqtDUCVurA8HtSOaaXbCwmDIJeCco2E5lFN77L3TBgpEaODMbSQGDOGddtdosYu+2I V5ltYJzMEdRktzhpDR3zaQ+O13xMUEF/8xv9PxdQjuN8RNxxW0I9sPmkjApwuu2XgBkN80S6e+0 PKQndvjKjCzIghOA== X-Received: by 2002:a05:600c:458e:b0:477:7ab8:aba with SMTP id 5b1f17b1804b1-4854b0ac93fmr85263525e9.1.1773309852339; Thu, 12 Mar 2026 03:04:12 -0700 (PDT) Received: from localhost ([85.163.81.98]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b5e912fsm304199535e9.2.2026.03.12.03.04.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 03:04:11 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, donald.hunter@gmail.com, corbet@lwn.net, skhan@linuxfoundation.org, saeedm@nvidia.com, leon@kernel.org, tariqt@nvidia.com, mbloch@nvidia.com, przemyslaw.kitszel@intel.com, mschmidt@redhat.com, andrew+netdev@lunn.ch, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, chuck.lever@oracle.com, matttbe@kernel.org, cjubran@nvidia.com, daniel.zahka@gmail.com, linux-doc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH net-next v4 03/13] devlink: avoid extra iterations when found devlink is not registered Date: Thu, 12 Mar 2026 11:03:57 +0100 Message-ID: <20260312100407.551173-4-jiri@resnulli.us> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20260312100407.551173-1-jiri@resnulli.us> References: <20260312100407.551173-1-jiri@resnulli.us> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jiri Pirko Since the one found is not registered, very unlikely another one with the same bus_name/dev_name is going to be found. Stop right away and prepare common "found" path for the follow-up patch. Signed-off-by: Jiri Pirko --- net/devlink/netlink.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/net/devlink/netlink.c b/net/devlink/netlink.c index 56817b85a3f9..7b205f677b7a 100644 --- a/net/devlink/netlink.c +++ b/net/devlink/netlink.c @@ -194,16 +194,20 @@ devlink_get_from_attrs_lock(struct net *net, struct nlattr **attrs, devlinks_xa_for_each_registered_get(net, index, devlink) { if (strcmp(devlink_bus_name(devlink), busname) == 0 && - strcmp(devlink_dev_name(devlink), devname) == 0) { - devl_dev_lock(devlink, dev_lock); - if (devl_is_registered(devlink)) - return devlink; - devl_dev_unlock(devlink, dev_lock); - } + strcmp(devlink_dev_name(devlink), devname) == 0) + goto found; devlink_put(devlink); } return ERR_PTR(-ENODEV); + +found: + devl_dev_lock(devlink, dev_lock); + if (devl_is_registered(devlink)) + return devlink; + devl_dev_unlock(devlink, dev_lock); + devlink_put(devlink); + return ERR_PTR(-ENODEV); } static int __devlink_nl_pre_doit(struct sk_buff *skb, struct genl_info *info, -- 2.51.1