public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: theo.lebrun@bootlin.com
Cc: Ryan.Wanner@microchip.com,
	Valentina.FernandezAlanis@microchip.com, abin.joseph@amd.com,
	alex@ghiti.fr, andrew+netdev@lunn.ch, aou@eecs.berkeley.edu,
	claudiu.beznea@tuxon.dev, conor+dt@kernel.org,
	conor.dooley@microchip.com, conor@kernel.org,
	daire.mcnamara@microchip.com, dave.stevenson@raspberrypi.com,
	davem@davemloft.net, devicetree@vger.kernel.org,
	edumazet@google.com, gregory.clement@bootlin.com,
	krzk+dt@kernel.org, kuba@kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	netdev@vger.kernel.org, nicolas.ferre@microchip.com,
	pabeni@redhat.com, palmer@dabbelt.com, pjw@kernel.org,
	richardcochran@gmail.com, robh@kernel.org,
	samuel.holland@sifive.com, sean.anderson@linux.dev,
	thomas.petazzoni@bootlin.com, vineeth.karumanchi@amd.com
Subject: [PATCH 1/3] net: macb: runtime detect MACB_CAPS_USRIO_DISABLED
Date: Thu, 12 Mar 2026 11:11:36 +0100	[thread overview]
Message-ID: <20260312101138.465482-1-theo.lebrun@bootlin.com> (raw)
In-Reply-To: <DH0PZN0WJZC5.26KLH464PMMTP@bootlin.com>

DCFG1 (design config 1 register) carries a bit indicating whether User
I/O feature has been enabled or not. The MACB/GEM driver has a cap flag
indicating that HW has the feature disabled (default is enabled). Add
the missing connection between DCFG1 bit and MACB_CAPS_USRIO_DISABLED.

Indirect impact: avoid useless writel() on USERIO register; this is not
an important fix because USERIO is anyway read-only when feature is
disabled.

If for some reason a compatible sets USRIO_DISABLED but DCFG1 indicates
it is enabled, we still keep the disabled capability flag. This ensures
we don't break "cdns,np4-macb" that sets the flag from compatible match
data.

Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
---
 drivers/net/ethernet/cadence/macb.h      | 2 ++
 drivers/net/ethernet/cadence/macb_main.c | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
index 8e5305f9a754..16527dbab875 100644
--- a/drivers/net/ethernet/cadence/macb.h
+++ b/drivers/net/ethernet/cadence/macb.h
@@ -524,6 +524,8 @@
 #define GEM_IRQCOR_SIZE				1
 #define GEM_DBWDEF_OFFSET			25
 #define GEM_DBWDEF_SIZE				3
+#define GEM_USERIO_OFFSET			9
+#define GEM_USERIO_SIZE				1
 #define GEM_NO_PCS_OFFSET			0
 #define GEM_NO_PCS_SIZE				1
 
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 6ac68731784f..ecab7fdc962d 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4481,6 +4481,8 @@ static void macb_configure_caps(struct macb *bp,
 			bp->caps |= MACB_CAPS_ISR_CLEAR_ON_WRITE;
 		if (GEM_BFEXT(NO_PCS, dcfg) == 0)
 			bp->caps |= MACB_CAPS_PCS;
+		if (!(dcfg & GEM_BIT(USERIO)))
+			bp->caps |= MACB_CAPS_USRIO_DISABLED;
 		dcfg = gem_readl(bp, DCFG12);
 		if (GEM_BFEXT(HIGH_SPEED, dcfg) == 1)
 			bp->caps |= MACB_CAPS_HIGH_SPEED;
-- 
2.53.0


  reply	other threads:[~2026-03-12 10:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10 17:17 [PATCH net-next v3 00/10] macb usrio/tsu patches Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 01/10] net: macb: rename macb_default_usrio to at91_default_usrio as not all platforms have mii mode control in usrio Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 02/10] net: macb: split USRIO_HAS_CLKEN capability in two Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 03/10] dt-bindings: net: cdns,macb: replace cdns,refclk-ext with cdns,refclk-source Conor Dooley
2026-03-11  7:00   ` Krzysztof Kozlowski
2026-03-11 18:08     ` Conor Dooley
2026-03-11 18:10       ` Krzysztof Kozlowski
2026-03-11 18:23         ` Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 04/10] net: macb: rework usrio refclk selection code Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 05/10] net: macb: np4 doesn't need a usrio pointer Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 06/10] net: macb: add mpfs specific usrio configuration Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 07/10] net: macb: warn on pclk use as a tsu_clk fallback Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 08/10] net: macb: clean up tsu clk rate acquisition Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 09/10] dt-bindings: net: macb: add property indicating timer adjust mode Conor Dooley
2026-03-11  7:02   ` Krzysztof Kozlowski
2026-03-10 17:17 ` [PATCH net-next v3 10/10] net: macb: timer adjust mode is not supported Conor Dooley
2026-03-12 10:09 ` [PATCH net-next v3 00/10] macb usrio/tsu patches Théo Lebrun
2026-03-12 10:11   ` Théo Lebrun [this message]
2026-03-12 10:11     ` [PATCH 2/3] net: macb: set MACB_CAPS_USRIO_DISABLED if no usrio config is provided Théo Lebrun
2026-03-12 10:11     ` [PATCH 3/3] net: macb: drop usrio pointer on EyeQ5 config Théo Lebrun
2026-03-12 10:22   ` [PATCH net-next v3 00/10] macb usrio/tsu patches Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260312101138.465482-1-theo.lebrun@bootlin.com \
    --to=theo.lebrun@bootlin.com \
    --cc=Ryan.Wanner@microchip.com \
    --cc=Valentina.FernandezAlanis@microchip.com \
    --cc=abin.joseph@amd.com \
    --cc=alex@ghiti.fr \
    --cc=andrew+netdev@lunn.ch \
    --cc=aou@eecs.berkeley.edu \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=conor@kernel.org \
    --cc=daire.mcnamara@microchip.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=gregory.clement@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=pabeni@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=samuel.holland@sifive.com \
    --cc=sean.anderson@linux.dev \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vineeth.karumanchi@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox