From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: theo.lebrun@bootlin.com
Cc: Ryan.Wanner@microchip.com,
Valentina.FernandezAlanis@microchip.com, abin.joseph@amd.com,
alex@ghiti.fr, andrew+netdev@lunn.ch, aou@eecs.berkeley.edu,
claudiu.beznea@tuxon.dev, conor+dt@kernel.org,
conor.dooley@microchip.com, conor@kernel.org,
daire.mcnamara@microchip.com, dave.stevenson@raspberrypi.com,
davem@davemloft.net, devicetree@vger.kernel.org,
edumazet@google.com, gregory.clement@bootlin.com,
krzk+dt@kernel.org, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
netdev@vger.kernel.org, nicolas.ferre@microchip.com,
pabeni@redhat.com, palmer@dabbelt.com, pjw@kernel.org,
richardcochran@gmail.com, robh@kernel.org,
samuel.holland@sifive.com, sean.anderson@linux.dev,
thomas.petazzoni@bootlin.com, vineeth.karumanchi@amd.com
Subject: [PATCH 3/3] net: macb: drop usrio pointer on EyeQ5 config
Date: Thu, 12 Mar 2026 11:11:38 +0100 [thread overview]
Message-ID: <20260312101138.465482-3-theo.lebrun@bootlin.com> (raw)
In-Reply-To: <20260312101138.465482-1-theo.lebrun@bootlin.com>
USRIO is disabled on this platform, drop its inherited usrio config.
We will end up with MACB_CAPS_USRIO_DISABLED on this platform:
- We have no config->usrio so macb_configure_caps() deduces that the
feature is disabled.
- Anecdotally, we would also land in the runtime detection codepath
that reads DCFG1.
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
---
drivers/net/ethernet/cadence/macb_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 972499aa4191..0e2200cf4206 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -5592,7 +5592,6 @@ static const struct macb_config eyeq5_config = {
.clk_init = macb_clk_init,
.init = eyeq5_init,
.jumbo_max_len = 10240,
- .usrio = &at91_default_usrio,
};
static const struct macb_config raspberrypi_rp1_config = {
--
2.53.0
next prev parent reply other threads:[~2026-03-12 10:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 17:17 [PATCH net-next v3 00/10] macb usrio/tsu patches Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 01/10] net: macb: rename macb_default_usrio to at91_default_usrio as not all platforms have mii mode control in usrio Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 02/10] net: macb: split USRIO_HAS_CLKEN capability in two Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 03/10] dt-bindings: net: cdns,macb: replace cdns,refclk-ext with cdns,refclk-source Conor Dooley
2026-03-11 7:00 ` Krzysztof Kozlowski
2026-03-11 18:08 ` Conor Dooley
2026-03-11 18:10 ` Krzysztof Kozlowski
2026-03-11 18:23 ` Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 04/10] net: macb: rework usrio refclk selection code Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 05/10] net: macb: np4 doesn't need a usrio pointer Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 06/10] net: macb: add mpfs specific usrio configuration Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 07/10] net: macb: warn on pclk use as a tsu_clk fallback Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 08/10] net: macb: clean up tsu clk rate acquisition Conor Dooley
2026-03-10 17:17 ` [PATCH net-next v3 09/10] dt-bindings: net: macb: add property indicating timer adjust mode Conor Dooley
2026-03-11 7:02 ` Krzysztof Kozlowski
2026-03-10 17:17 ` [PATCH net-next v3 10/10] net: macb: timer adjust mode is not supported Conor Dooley
2026-03-12 10:09 ` [PATCH net-next v3 00/10] macb usrio/tsu patches Théo Lebrun
2026-03-12 10:11 ` [PATCH 1/3] net: macb: runtime detect MACB_CAPS_USRIO_DISABLED Théo Lebrun
2026-03-12 10:11 ` [PATCH 2/3] net: macb: set MACB_CAPS_USRIO_DISABLED if no usrio config is provided Théo Lebrun
2026-03-12 10:11 ` Théo Lebrun [this message]
2026-03-12 10:22 ` [PATCH net-next v3 00/10] macb usrio/tsu patches Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312101138.465482-3-theo.lebrun@bootlin.com \
--to=theo.lebrun@bootlin.com \
--cc=Ryan.Wanner@microchip.com \
--cc=Valentina.FernandezAlanis@microchip.com \
--cc=abin.joseph@amd.com \
--cc=alex@ghiti.fr \
--cc=andrew+netdev@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=daire.mcnamara@microchip.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregory.clement@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=samuel.holland@sifive.com \
--cc=sean.anderson@linux.dev \
--cc=thomas.petazzoni@bootlin.com \
--cc=vineeth.karumanchi@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox