public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Tailu Shi <tailu.shi@samsung.com>
To: Tailu Shi <tailu.shi@samsung.com>, Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	Pauli Virtanen <pav@iki.fi>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: ISO: add timestamp for outgoing HCI ISO packet
Date: Thu, 12 Mar 2026 17:38:49 +0800	[thread overview]
Message-ID: <20260312165734.8ff3927d@samsung.com> (raw)
In-Reply-To: <9199a462-09be-402a-a47a-447e51a2f5a4@molgen.mpg.de>

Hi Paul,

Thank you for the review and the helpful suggestion about my name.

I have updated my Git configuration and amended the commit as you advised:

    git config --global user.name "Tailu Shi"
    git commit --amend -s --author="Tailu Shi <tailu.shi@samsung.com>"


On Wed, 11 Mar 2026 09:54:38 +0100 Paul Menzel wrote:
>> A corresponding userspace change is required for full functionality.
>> A reference implementation is available in PipeWire:
>> https://gitlab.freedesktop.org/shitailu/pipewire/-/commit/5b3bd74e15febb974c8737a64f31fd17e18cd11b
> 
> Is the timestamp correctly visible in the btmon trace?

Yes, it can be seen in the btmon trace. The test was performed on the
kernel 7.0.0‑rc1+, using BlueZ 5.85 and PipeWire 1.5.84 with the
'bluez5.iso-tx-timestamp' configuration option enabled.

But seems the btmon v5.85 and v5.86 fails to parse it directly with
the command. However, the 'ts' field can be seen clearly with Wireshark.

The things are like below:

1) btmon v5.86
 $ btmon -r dump.btsnoop -I |grep -A1 'ISO Data TX: Handle 2563'
 < ISO Data TX: Handle 2563 [5/18] SN 2                 #10999 [hci0] 128.571172
         02 00 3c 00 00 00 00 00 00 00 00 00 00 00 00 00  ..<.............
 --

2) Wireshark
 Frame 19604: 72 bytes on wire (576 bits), 72 bytes captured (576 bits)
 Bluetooth
 Bluetooth Linux Monitor Transport
 Bluetooth HCI ISO Packet
     .... 1010 0000 0011 = Connection Handle: 0xa03
     ..10 .... .... .... = PB Flag: Complete SDU (0x2)
     .1.. .... .... .... = Timestamp present: True
     0... .... .... .... = Reserved: 0x0
     ..00 0000 0100 0100 = Data Length: 68
     Data
     [Connect in frame: 18836]
 Bluetooth ISO Data
     Timestamp: 805103660µs
     Sequence Number: 84
     .... 0000 0011 1100 = SDU Length: 60
     SDU

Raw data:
 0000   03 6a 44 00 2c e8 fc 2f 54 00 3c 00 00 00 00 00   .jD.,../T.<.....
 0010   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00   ................
 0020   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00   ................
 0030   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00   ................
 0040   38 24 f9 4a 0d 00 00 03                           8$.J....


Thanks for your time again!

Best regards,

Tailu Shi

      reply	other threads:[~2026-03-12  9:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260311081515epcas5p44f035a61a5c6738cd6017d961bf68326@epcas5p4.samsung.com>
2026-03-11  8:14 ` [PATCH] Bluetooth: ISO: add timestamp for outgoing HCI ISO packet tailu.shi
2026-03-11  8:54   ` Paul Menzel
2026-03-12  9:38     ` Tailu Shi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260312165734.8ff3927d@samsung.com \
    --to=tailu.shi@samsung.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=johan.hedberg@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pav@iki.fi \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox