From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEAC52853EE for ; Fri, 13 Mar 2026 00:22:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773361369; cv=none; b=g57gGa6jX5btOqMkuhIliVq9OfscR+2YUhz5/LVCyAFasgZ5zqWLLS6QhoBnFGuoZA3i8R5emyUfct7nuW1xmT8bDD4AN4g4IGAJkPl756zp6rngA2MC82j2ys8ctox2Wo0uYFldE9cItblf3arZV2VaEg8OfTRh4bpA9J2LElc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773361369; c=relaxed/simple; bh=wI1M2N3RZJ2ZGEFBVZ0oz+Ohx1k+qHSBfOqMj5JSSV4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mu+Bb+iLqI9m72uWGiqfjK+VfMV2gNSpEt2YmBmzfY+50o178KKaRRFElTp/MeuBOSOrAmKoF810gX257IFjtYoGHZGyuZAmPKZFOnl7WldM4q3ujnKBrqkdiEnM6A50+1OrgOwlZ/Q8Z3/9Z09S/7jMthWGIHj1KQSvwMnzMuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gq9nHXeu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gq9nHXeu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2455FC4CEF7; Fri, 13 Mar 2026 00:22:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773361369; bh=wI1M2N3RZJ2ZGEFBVZ0oz+Ohx1k+qHSBfOqMj5JSSV4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gq9nHXeu+kEHaXkEFRtydIr1EtZQSG7QgbgG215lIgYebbhnpVIuXvY1VhlnK1bDq IzZIR4Poy9LRkeBH7U2Eb6vXo6G6XYXQailY5puZOY9d+Byq07nfffRyh6bLSOaE1D dYHVmdANm2v8xvZQhLo+zOMjQP6u0SXElZcDvyMVZROyKlL808xB1sPvUjHxyszUBY t4bQSmaYWFIdLKiosStIwC+v/s9xbpeAgKayhr7jwPM6CAptO4X3Ljbkhfcg+hvL0E I0EfKtAbFFaCxNK3+gvCbb2NT9LhrpLg4LHmGTtXHuvi35BCOg3J2dyiv89ubWAAhW SoLtBjMKvVM4Q== Date: Thu, 12 Mar 2026 17:22:48 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Cc: Simon Horman , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: airoha: select QDMA block according LAN/WAN configuration Message-ID: <20260312172248.68742f98@kernel.org> In-Reply-To: References: <20260310-airoha-qdma-lan-wan-mode-v1-1-64ec74dea872@kernel.org> <20260312172430.GA1267298@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 12 Mar 2026 22:14:36 +0100 Lorenzo Bianconi wrote: > > Is this a bug fix? > > If so, perhaps it is for net with a fixes tag. > > I guess we do not need to target net tree since airoha_eth driver currently > supports just the LAN interface via the MT7530 DSA switch connected to GDM1 > and there are no WAN interfaces officially supported (PCS/external phy is not > merged mainline yet, it is only available in OpenWrt). > > > > > And at any rate, could you add some description of the before and after > > behaviour? > > Theoretically, before this patch, GDM ports were equally distributed between > QDMA0 and QDMA1 while this patch assigns LAN interfaces to QDMA0 and WAN > interface to QDMA1. However, for the reason explained above, this change is > not currently visible to the user. Please update the commit message. And please try harder to explain the patches, this happens a lot with your submissions..