[PATCH] net: ifb: fix space after comma in for loops

[PATCH] net: ifb: fix space after comma in for loops

[ShravyaPanchagiri]

Add missing space after comma in for loop to fix checkpatch errors.

Signed-off-by: ShravyaPanchagiri <shravy112@gmail.com>
---
 drivers/net/ifb.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c
index 5407d2ed71b3..58a49ed5aabe 100644
--- a/drivers/net/ifb.c
+++ b/drivers/net/ifb.c
@@ -18,12 +18,10 @@
 	You need the tc action  mirror or redirect to feed this device
 	packets.
 
-
 	Authors:	Jamal Hadi Salim (2005)
 
 */
 
-
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/netdevice.h>
@@ -148,7 +146,6 @@ static void ifb_ri_tasklet(struct tasklet_struct *t)
 		txp->tasklet_pending = 1;
 		tasklet_schedule(&txp->ifb_tasklet);
 	}
-
 }
 
 static void ifb_stats64(struct net_device *dev,
@@ -160,7 +157,7 @@ static void ifb_stats64(struct net_device *dev,
 	u64 packets, bytes;
 	int i;
 
-	for (i = 0; i < dev->num_tx_queues; i++,txp++) {
+	for (i = 0; i < dev->num_tx_queues; i++, txp++) {
 		do {
 			start = u64_stats_fetch_begin(&txp->rx_stats.sync);
 			packets = u64_stats_read(&txp->rx_stats.packets);
@@ -191,7 +188,7 @@ static int ifb_dev_init(struct net_device *dev)
 	if (!txp)
 		return -ENOMEM;
 	dp->tx_private = txp;
-	for (i = 0; i < dev->num_tx_queues; i++,txp++) {
+	for (i = 0; i < dev->num_tx_queues; i++, txp++) {
 		txp->txqnum = i;
 		txp->dev = dev;
 		__skb_queue_head_init(&txp->rq);
@@ -299,7 +296,7 @@ static void ifb_dev_free(struct net_device *dev)
 	struct ifb_q_private *txp = dp->tx_private;
 	int i;
 
-	for (i = 0; i < dev->num_tx_queues; i++,txp++) {
+	for (i = 0; i < dev->num_tx_queues; i++, txp++) {
 		tasklet_kill(&txp->ifb_tasklet);
 		__skb_queue_purge(&txp->rq);
 		__skb_queue_purge(&txp->tq);
-- 
2.43.0

Re: [PATCH] net: ifb: fix space after comma in for loops

[Jakub Kicinski]

On Thu, 12 Mar 2026 19:36:51 -0500 ShravyaPanchagiri wrote:
> Add missing space after comma in for loop to fix checkpatch errors.

Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl``, and other trivial coding style warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
  
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
-- 
pw-bot: reject