From: Jakub Kicinski <kuba@kernel.org>
To: Damien Dejean <dam.dejean@gmail.com>
Cc: andrew@lunn.ch, krzk+dt@kernel.org, robh@kernel.org,
maxime.chevallier@bootlin.com, pabeni@redhat.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, edumazet@google.com,
davem@davemloft.net, hkallweit1@gmail.com
Subject: Re: [PATCH net-next v7 4/4] net: phy: realtek: add RTL8224 polarity support
Date: Thu, 12 Mar 2026 18:11:46 -0700 [thread overview]
Message-ID: <20260312181146.266c5205@kernel.org> (raw)
In-Reply-To: <20260310173846.230923-5-dam.dejean@gmail.com>
On Tue, 10 Mar 2026 18:38:46 +0100 Damien Dejean wrote:
> +static int rtl8224_package_modify_mmd(struct phy_device *phydev, int devad,
> + u32 regnum, u16 mask, u16 set)
> +{
> + int val, ret;
> +
> + phy_lock_mdio_bus(phydev);
> +
> + val = __phy_package_read_mmd(phydev, 0, devad, regnum);
> + if (val < 0) {
> + ret = val;
> + goto exit;
> + }
> +
> + val &= ~mask;
> + val |= set;
> +
> + ret = __phy_package_write_mmd(phydev, 0, devad, regnum, val);
> +
> +exit:
> + phy_unlock_mdio_bus(phydev);
> + return ret;
> +}
Can this helper be added in patch 2 so that we don't rewrite the code
we just added? It makes the diff harder to follow.
--
pw-bot: cr
next prev parent reply other threads:[~2026-03-13 1:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 17:38 [PATCH net-next v7 0/4] net: phy: realtek: pair order and polarity Damien Dejean
2026-03-10 17:38 ` [PATCH net-next v7 1/4] dt-bindings: net: ethernet-phy: add property enet-phy-pair-order Damien Dejean
2026-03-10 17:38 ` [PATCH net-next v7 2/4] net: phy: realtek: add RTL8224 pair order support Damien Dejean
2026-03-10 17:38 ` [PATCH net-next v7 3/4] dt-bindings: net: ethernet-phy: add property enet-phy-pair-polarity Damien Dejean
2026-03-10 17:38 ` [PATCH net-next v7 4/4] net: phy: realtek: add RTL8224 polarity support Damien Dejean
2026-03-13 1:11 ` Jakub Kicinski [this message]
2026-03-15 21:59 ` Damien Dejean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312181146.266c5205@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=dam.dejean@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox