From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: airoha: Remove airoha_dev_stop() in airoha_remove()
Date: Thu, 12 Mar 2026 18:21:28 -0700 [thread overview]
Message-ID: <20260312182128.33d2d88c@kernel.org> (raw)
In-Reply-To: <20260311-airoha-remove-ndo_stop-remove-v1-1-596fe853b2e1@kernel.org>
On Wed, 11 Mar 2026 10:54:57 +0100 Lorenzo Bianconi wrote:
> Do not call airoha_dev_stop routine explicitly in airoha_remove()
> since it is already executed by unregister_netdev() if necessary
This one is a fix I think? We underflow the atomic if the port
is already down. Once again, commit message way too terse :(
--
pw-bot: cr
next prev parent reply other threads:[~2026-03-13 1:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 9:54 [PATCH net-next] net: airoha: Remove airoha_dev_stop() in airoha_remove() Lorenzo Bianconi
2026-03-13 1:21 ` Jakub Kicinski [this message]
2026-03-13 11:29 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312182128.33d2d88c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox