* [PATCH net-next] net: airoha: Remove airoha_dev_stop() in airoha_remove()
@ 2026-03-11 9:54 Lorenzo Bianconi
2026-03-13 1:21 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Lorenzo Bianconi @ 2026-03-11 9:54 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: linux-arm-kernel, linux-mediatek, netdev, Lorenzo Bianconi
Do not call airoha_dev_stop routine explicitly in airoha_remove()
since it is already executed by unregister_netdev() if necessary
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
drivers/net/ethernet/airoha/airoha_eth.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c
index 3e9ec5c178f86fdd055e079078a23461edf97951..de5089e7dcd85080188641ae4c976b3d731cc3b4 100644
--- a/drivers/net/ethernet/airoha/airoha_eth.c
+++ b/drivers/net/ethernet/airoha/airoha_eth.c
@@ -3095,7 +3095,6 @@ static void airoha_remove(struct platform_device *pdev)
if (!port)
continue;
- airoha_dev_stop(port->dev);
unregister_netdev(port->dev);
airoha_metadata_dst_free(port);
}
---
base-commit: 482aac8b56ca21d06c588517970579474d56736e
change-id: 20260311-airoha-remove-ndo_stop-remove-1582a74baa33
Best regards,
--
Lorenzo Bianconi <lorenzo@kernel.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: airoha: Remove airoha_dev_stop() in airoha_remove()
2026-03-11 9:54 [PATCH net-next] net: airoha: Remove airoha_dev_stop() in airoha_remove() Lorenzo Bianconi
@ 2026-03-13 1:21 ` Jakub Kicinski
2026-03-13 11:29 ` Lorenzo Bianconi
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2026-03-13 1:21 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni,
linux-arm-kernel, linux-mediatek, netdev
On Wed, 11 Mar 2026 10:54:57 +0100 Lorenzo Bianconi wrote:
> Do not call airoha_dev_stop routine explicitly in airoha_remove()
> since it is already executed by unregister_netdev() if necessary
This one is a fix I think? We underflow the atomic if the port
is already down. Once again, commit message way too terse :(
--
pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: airoha: Remove airoha_dev_stop() in airoha_remove()
2026-03-13 1:21 ` Jakub Kicinski
@ 2026-03-13 11:29 ` Lorenzo Bianconi
0 siblings, 0 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2026-03-13 11:29 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni,
linux-arm-kernel, linux-mediatek, netdev
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
> On Wed, 11 Mar 2026 10:54:57 +0100 Lorenzo Bianconi wrote:
> > Do not call airoha_dev_stop routine explicitly in airoha_remove()
> > since it is already executed by unregister_netdev() if necessary
>
> This one is a fix I think? We underflow the atomic if the port
> is already down. Once again, commit message way too terse :(
Hi Jakub,
ack, I will post v2 targetting net instead of net-next improving the commit
message.
Regards,
Lorenzo
> --
> pw-bot: cr
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-13 11:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-11 9:54 [PATCH net-next] net: airoha: Remove airoha_dev_stop() in airoha_remove() Lorenzo Bianconi
2026-03-13 1:21 ` Jakub Kicinski
2026-03-13 11:29 ` Lorenzo Bianconi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox