From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E424E248166 for ; Fri, 13 Mar 2026 01:21:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773364890; cv=none; b=Fc4FRLQfHEXVnO23bbKMvzWskTlPPq/Awwmgcm0SonQfVz+wwqJ5Lf3BMukWT3yxBR0qvczTYkqNEcS0tFt3G72C8QehQBIRJXZvyB+Gcw+fVSUErVdel4k2nXE38s4fbhbeAo9yhKTf0HqzlUlaKwFyvrZBAxVF5agg5dvRNVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773364890; c=relaxed/simple; bh=RT5cCoFd51XlFsbavm43RBi3zqtF/Bni3O89ezyTihQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UY7Hbh9H5qF9ItYEzg/6YiKpgaPrd4R8erkOuR1dQQ+qACS9GKQVIVY0qIoXGK6Q1rHoHm82bfWaj3dBdzhD+GMEOFsureTS9XI/GpFgH8Km3rR6upHk1UUZbpfk+aFzC3iwRNfzUEi+pV0rK9I426lUX8TDcR82vjc+/moLyBU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lKrIEJvi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lKrIEJvi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31556C4CEF7; Fri, 13 Mar 2026 01:21:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773364889; bh=RT5cCoFd51XlFsbavm43RBi3zqtF/Bni3O89ezyTihQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lKrIEJvi88ynMx73j9D6v1S2E/u0ZviHUojbpcdcohUAxa2J6HsjbBv5IzZ4Sivbe quWYsKvkiatSCzdjRsht3U5CsSpu8huhGkl9jwjdhYL1L24uI05irsbEz/AcmKJgdQ XvHigJGItZOyb0TCkmI7qVMKh0unkdPu1+0Gtl8z7sQYDw24+9EEs4jjBARFoBAoIc nfxqxA/XKs7V5GNkHLk+P69jGQpRhnTE2sbrY0JHhBcasCsX4k1xTmuXxFBIOakVtO 8PyL2QvmusaSNiXHDaE1Ti1Ks/i9wSYMDAkHJ0v6An4cNtZUeGYjDzfgniFNptYGES tKrIBzyC5F/RA== Date: Thu, 12 Mar 2026 18:21:28 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: airoha: Remove airoha_dev_stop() in airoha_remove() Message-ID: <20260312182128.33d2d88c@kernel.org> In-Reply-To: <20260311-airoha-remove-ndo_stop-remove-v1-1-596fe853b2e1@kernel.org> References: <20260311-airoha-remove-ndo_stop-remove-v1-1-596fe853b2e1@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 11 Mar 2026 10:54:57 +0100 Lorenzo Bianconi wrote: > Do not call airoha_dev_stop routine explicitly in airoha_remove() > since it is already executed by unregister_netdev() if necessary This one is a fix I think? We underflow the atomic if the port is already down. Once again, commit message way too terse :( -- pw-bot: cr