From: Christophe Roullier <christophe.roullier@foss.st.com>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Russell King <rmk+kernel@armlinux.org.uk>, <linusw@kernel.org>,
<antonio.borneo@foss.st.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Christophe Roullier <christophe.roullier@foss.st.com>
Cc: <netdev@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 1/2] net: stmmac: fix pinctrl management during suspend/resume
Date: Fri, 13 Mar 2026 11:57:16 +0100 [thread overview]
Message-ID: <20260313105718.359614-2-christophe.roullier@foss.st.com> (raw)
In-Reply-To: <20260313105718.359614-1-christophe.roullier@foss.st.com>
In the deepest low-power modes, the pinctrl configuration is lost
and is never restored if the interface is down.
This commit ensures that the pinctrl state is set in all cases.
Signed-off-by: Christophe Roullier <christophe.roullier@foss.st.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 11150bddd8726..26ac1cdc561c2 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -8150,8 +8150,11 @@ int stmmac_suspend(struct device *dev)
struct stmmac_priv *priv = netdev_priv(ndev);
u8 chan;
- if (!ndev || !netif_running(ndev))
+ if (!ndev || !netif_running(ndev)) {
+ /* Select sleep pin state */
+ pinctrl_pm_select_sleep_state(dev);
goto suspend_bsp;
+ }
mutex_lock(&priv->lock);
@@ -8252,8 +8255,11 @@ int stmmac_resume(struct device *dev)
return ret;
}
- if (!netif_running(ndev))
+ if (!netif_running(ndev)) {
+ /* Select default pin state */
+ pinctrl_pm_select_default_state(priv->device);
return 0;
+ }
/* Power Down bit, into the PM register, is cleared
* automatically as soon as a magic packet or a Wake-up frame
--
2.43.0
next prev parent reply other threads:[~2026-03-13 10:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 10:57 [PATCH v2 0/2] Fixes for stmmac driver Christophe Roullier
2026-03-13 10:57 ` Christophe Roullier [this message]
2026-03-13 11:08 ` [PATCH v2 1/2] net: stmmac: fix pinctrl management during suspend/resume Russell King (Oracle)
2026-03-13 23:44 ` Linus Walleij
2026-03-14 0:37 ` Russell King (Oracle)
2026-03-16 9:03 ` Russell King (Oracle)
2026-03-16 10:06 ` Christophe ROULLIER
[not found] ` <4de50fb9-35e6-48e7-8111-c5a94099d4f7@foss.st.com>
2026-03-16 13:14 ` Russell King (Oracle)
2026-03-17 0:13 ` Linus Walleij
2026-03-17 13:11 ` Russell King (Oracle)
2026-03-19 9:43 ` Linus Walleij
2026-03-25 9:55 ` Russell King (Oracle)
2026-03-13 10:57 ` [PATCH v2 2/2] net: stmmac: manage error case during stmmac_dvr_probe Christophe Roullier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260313105718.359614-2-christophe.roullier@foss.st.com \
--to=christophe.roullier@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=antonio.borneo@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox