From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Joe Damato <joe@dama.to>, Wei Fang <wei.fang@nxp.com>,
claudiu.manoil@nxp.com, xiaoning.wang@nxp.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH net-next] net: enetc: remove stray semicolon
Date: Sat, 14 Mar 2026 02:24:13 +0200 [thread overview]
Message-ID: <20260314002413.i36jrsuih6j2lmtc@skbuf> (raw)
In-Reply-To: <abSnSjp7cIj/qWGG@devvm20253.cco0.facebook.com>
On Fri, Mar 13, 2026 at 05:09:46PM -0700, Joe Damato wrote:
> On Fri, Mar 13, 2026 at 07:24:54PM +0800, Wei Fang wrote:
> > Remove stray semicolon from ntmp_table_name().
> >
> > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > ---
> > drivers/net/ethernet/freescale/enetc/ntmp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Hm, I'm not sure, but I suspect this might be rejected due to the note about
> cleanup in the docs, which generally seems to discourage this sort of thing:
>
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
"simple clean-ups, which are not in the context of other work"
The ENETC NTMP code is under active development, and Wei is developing it.
The semicolon was added in May last year and was found as part of other
review touching that area.
next prev parent reply other threads:[~2026-03-14 0:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 11:24 [PATCH net-next] net: enetc: remove stray semicolon Wei Fang
2026-03-14 0:09 ` Joe Damato
2026-03-14 0:24 ` Vladimir Oltean [this message]
2026-03-14 1:28 ` Wei Fang
2026-03-14 16:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260314002413.i36jrsuih6j2lmtc@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=joe@dama.to \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox