public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: tobgaertner <tob.gaertner@me.com>
To: netdev@vger.kernel.org, linux-usb@vger.kernel.org
Cc: kuba@kernel.org, gregkh@linuxfoundation.org, oneukum@suse.com,
	bjorn@mork.no, tobgaertner <tob.gaertner@me.com>
Subject: [PATCH v3 0/2] net: usb: cdc_ncm: add ndpoffset to NDP nframes bounds check
Date: Fri, 13 Mar 2026 22:46:38 -0700	[thread overview]
Message-ID: <20260314054640.2895026-1-tob.gaertner@me.com> (raw)

The nframes bounds check in cdc_ncm_rx_verify_ndp16() and
cdc_ncm_rx_verify_ndp32() does not account for ndpoffset,
allowing out-of-bounds reads when the NDP is placed near the
end of the NTB.

Changes since v2:
- Save struct_size_t() result to a temp variable to avoid
  awkward line wrapping (Jakub)
- Fix From/Signed-off-by mismatch
- Move "Compile-tested only" out of the Signed-off-by line
  into the commit message body

Tobi Gaertner (2):
  net: usb: cdc_ncm: add ndpoffset to NDP16 nframes bounds check
  net: usb: cdc_ncm: add ndpoffset to NDP32 nframes bounds check

 drivers/net/usb/cdc_ncm.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-03-14  5:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-14  5:46 tobgaertner [this message]
2026-03-14  5:46 ` [PATCH v3 1/2] net: usb: cdc_ncm: add ndpoffset to NDP16 nframes bounds check tobgaertner
2026-03-14  5:46 ` [PATCH v3 2/2] net: usb: cdc_ncm: add ndpoffset to NDP32 " tobgaertner
2026-03-17  4:00 ` [PATCH v3 0/2] net: usb: cdc_ncm: add ndpoffset to NDP " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260314054640.2895026-1-tob.gaertner@me.com \
    --to=tob.gaertner@me.com \
    --cc=bjorn@mork.no \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox