From: Jakub Kicinski <kuba@kernel.org>
To: netdev@vger.kernel.org
Cc: "Björn Töpel" <bjorn@kernel.org>,
"Michael Chan" <michael.chan@broadcom.com>,
"Pavan Chebbi" <pavan.chebbi@broadcom.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
linux-kselftest@vger.kernel.org,
"Willem de Bruijn" <willemb@google.com>,
"Shuah Khan" <shuah@kernel.org>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Andrew Lunn" <andrew@lunn.ch>,
intel-wired-lan@lists.osuosl.org,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH net-next v4 0/3] ethtool: Dynamic RSS context indirection table resizing
Date: Sat, 14 Mar 2026 09:35:18 -0700 [thread overview]
Message-ID: <20260314093518.43b820b7@kernel.org> (raw)
In-Reply-To: <20260313071322.3489243-1-bjorn@kernel.org>
On Fri, 13 Mar 2026 08:13:12 +0100 Björn Töpel wrote:
> Some NICs (e.g. bnxt) change their RSS indirection table size based on
> the queue count, because the hardware table is a shared resource. The
> ethtool core locks ctx->indir_size at context creation, so drivers
> have to reject channel changes when RSS contexts exist.
>
> This series adds resize helpers and wires them up in bnxt.
Sorry Bjorn, I was typing the explanation below and I realized that
we may be violating user intent. We should already record the user_size
from rss_set_prep_indir() as part of the context (and presumably some
netdev state for the main context?) and don't allow shrinking the
context below that mark..
Now for the broader audience - my understanding is that the RSS table
is a precious resource for most if not all drivers.
The direction of this work is to allow user to explicitly specify what
RSS table size they want. The Netlink API for RSS already allows users
to send tables smaller than what the device reports (Netlink code just
"replicates" the table). So if the user asks for X entries the driver
should be able to allocate a table of any size as long as its a
multiple of X. This series only support "global" resizing but it
should be simple to add the state for the driver to mark in the context
what table size it actually allocated. The only reason we haven't added
the support for that is that it's quite hard to know how to implement
it without docs for the FW/HW.. fbnic has fixed table sizes so we can't
even prototype there :S
Please reply if you'd like to collaborate on adding support for the
user-defined RSS context sizing.
next prev parent reply other threads:[~2026-03-14 16:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 7:13 [PATCH net-next v4 0/3] ethtool: Dynamic RSS context indirection table resizing Björn Töpel
2026-03-13 7:13 ` [PATCH net-next v4 1/3] ethtool: Add RSS indirection table resize helpers Björn Töpel
2026-03-13 7:13 ` [PATCH net-next v4 2/3] bnxt_en: Resize RSS contexts on channel count change Björn Töpel
2026-03-13 7:13 ` [PATCH net-next v4 3/3] selftests: rss_drv: Add RSS indirection table resize tests Björn Töpel
2026-03-14 16:35 ` Jakub Kicinski [this message]
2026-03-15 12:30 ` [PATCH net-next v4 0/3] ethtool: Dynamic RSS context indirection table resizing Björn Töpel
2026-03-16 23:31 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260314093518.43b820b7@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=bjorn@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox