From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH v2 net-next] tcp: add cwnd_event_tx_start to tcp_congestion_ops
Date: Sat, 14 Mar 2026 14:52:02 -0700 [thread overview]
Message-ID: <20260314145202.778a8535@kernel.org> (raw)
In-Reply-To: <20260314180802.50222-1-edumazet@google.com>
On Sat, 14 Mar 2026 18:08:02 +0000 Eric Dumazet wrote:
> (tcp_congestion_ops)->cwnd_event() is called very often, with
> @event oscillating between CA_EVENT_TX_START and other values.
>
> This is not branch prediction friendly.
>
> Provide a new cwnd_event_tx_start pointer dedicated for CA_EVENT_TX_START.
>
> Both BBR and CUBIC benefit from this change, since they only care
> about CA_EVENT_TX_START.
BPF still not building :(
progs/tcp_ca_kfunc.c:121:33: error: use of undeclared identifier 'cwnd_event_tx_start'
121 | .cwnd_event_tx_start = (void *)cwnd_event_tx_start,
| ^~~~~~~~~~~~~~~~~~~
https://github.com/kernel-patches/bpf/actions/runs/23096281431/job/67089276918
--
pw-bot: cr
next prev parent reply other threads:[~2026-03-14 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 18:08 [PATCH v2 net-next] tcp: add cwnd_event_tx_start to tcp_congestion_ops Eric Dumazet
2026-03-14 21:52 ` Jakub Kicinski [this message]
2026-03-14 22:27 ` Eric Dumazet
2026-03-14 22:35 ` Eric Dumazet
2026-03-14 22:42 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260314145202.778a8535@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox