From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DD7C30BBBC for ; Mon, 16 Mar 2026 02:10:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773627034; cv=none; b=Y/HqmgTnhxfm3pB/wikV1KPDzdUn4NdTvZVKdEiRRJ3CqKaMo6Xkq3pK2bY6qKjx5XkfYISHhzbg0PtGXCazV9/3Pg/Rkgiey32YZb21t3e/YnKtO7DdFzBNm3ZC8EjAXakpZl6HBrqo2oMkFa1t4qMwiJaVSx6o4uOZuUMKkNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773627034; c=relaxed/simple; bh=NA2WPiExcFM1F1Er32slS17NHJTG/FN7y2tKTlUTUQY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TvEeKzet3JDTMhR00kjx51YAIksfktFJ7DuPWwJ6xa5zXgVYSiXcyHhkNLtFnKBxR4ek6i1w+Lym2s3y9GB/xRVb43cn9rjKMyh1h3feV4+blbeo1opKukQ/Hhd65niQWMZ3aQdvPj1dc1ye58nz+3M/ZjehSYIIaWp7gv7vZIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z2H5CHbS; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z2H5CHbS" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-35ba2ae4df3so153763a91.2 for ; Sun, 15 Mar 2026 19:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773627032; x=1774231832; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MWF2mf3kVPfppDp36uMCmkCxPdxULYmBpYhT7oMPfhU=; b=Z2H5CHbSvuUUU83B+YJHt2zwIY6rc1/234OnVbjP4bZmN++uY4F82faoDfiHw2BcX9 AVdmjS+TlE53AJywca+pJvv7dXH1SDsN/IDr3LX3ax1SOEf/jgI6nmy17x0s512qiviG dcTAp2Cb32xQiPrq6A35/Me+BPZBOwIV4oRNfkpSPtV56+02IuJ7M7JpClv1IKs/yQWB 8xwC+qP+CGbJjHvxmfrzIzzKYzecIp3DztuBxfubrxvlb8B4qgbx9KCHURhdnkSnQU1X LuUzWezNF2UN3U+nLUAyoB8E6ZH67IK1MPCh1Q8H0xPXSf8r+vf+DvYI+IiHDoYNlIAQ 5pjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773627032; x=1774231832; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MWF2mf3kVPfppDp36uMCmkCxPdxULYmBpYhT7oMPfhU=; b=QPBXrrQw4TYZSoRiRu+OR/EEoKNfFgB8G2NstDSr1pnbQdKiajJT7khwdu593HrWvK StoN8Qgnw1YMb0AmBe4QRXkFvUZG9PCcuNN8oJI8/U872H6fs/FevSBRP6yMlVSckLtU 65OvEG/fPYH0xhMkuOKep3wM3LQoBUegueNCH1sfy58JtdGP+pfX7Qqh80o2YD/UbyN6 vK+8AcQZu1DR0AJzQNPmVUh4jAyjP3AbI5xVPdpEb/W7xCv1yjPSkJRNbEo7XHzqXbsT koWk8LkwNHIJwXQt3rwzrkqzFFSfTVp+/Oc4ATWl8z3mLEvGp7mxYcxgsWI+XYEPEuWz iLKg== X-Forwarded-Encrypted: i=1; AJvYcCVfT7g/uuNE2fBjGWH8QqohZxFminK/xytxvOLU0Er3ASBHs/16XR/oBhzMUrdZfegiG1neP0c=@vger.kernel.org X-Gm-Message-State: AOJu0YxNWzo1RWX/bUe71gAo1J1RZ16rCOsubJKMdoOikne80kZ4Jntu M7Hnb+wWSSCRlfgZHgR1Z+i0vPVd8lR+X1ncY/0La7XI6pmVqQ/OQsbs X-Gm-Gg: ATEYQzyK/GnxatlF9xhc89U4RJqi6B0MysgHKFQVqfz129TwySibgd3qGrHNVJZYGwQ yQQKBTerog2LRUuZbrymj6JD72hbkJ4cGR27qCHdflfozXFe/QbBmyg+5nkRCzhNlW/SDwCt92c 8S9JEtOD9DESGw/4epo6ln9jZyrO2GIYcEYxph/tC8z/l9aMhBAGMy5J2KxA+Wj//nHWFTaW5c3 rwFp8l8lMc5uvA62T46VIIFQ1Xo9E5IKWV0Skx9pNdx9SXDUQCAxEyg9onLZJLUuAyWE7ETKpv6 GhmYnps5n3Srl4V1XnU/Lqm3WH8Ssf4iZDSujw8Xyngwj7zsy/5P/z8FBxPbs+5cPHBH08hf+aj 8fOhMmDZl0enrgJ1/y8nUEAb10gp1aeSSg8j20B2Y1kNgvUy3CIIhS1PbNKls2obcAzRVQwBQxv +sREH6J1FS3eSTDoYQcdTYN0iwRvE23zL6U2aj0wEw4y6rHiFhVhJC10zQ4KfAAo4P X-Received: by 2002:a17:90b:3501:b0:359:fa1e:2bc3 with SMTP id 98e67ed59e1d1-35a21ea5dbfmr10103044a91.6.1773627031911; Sun, 15 Mar 2026 19:10:31 -0700 (PDT) Received: from luna.turtle.lan (static-23-234-93-211.cust.tzulo.com. [23.234.93.211]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35a02ffdfb7sm17705805a91.14.2026.03.15.19.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 19:10:31 -0700 (PDT) From: Sam Edwards X-Google-Original-From: Sam Edwards To: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Russell King , Maxime Chevallier , Ovidiu Panait , Vladimir Oltean , Baruch Siach , Serge Semin , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sam Edwards , stable@vger.kernel.org Subject: [PATCH 2/3] net: stmmac: Prevent indefinite RX stall on buffer exhaustion Date: Sun, 15 Mar 2026 19:10:08 -0700 Message-ID: <20260316021009.262358-3-CFSworks@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260316021009.262358-1-CFSworks@gmail.com> References: <20260316021009.262358-1-CFSworks@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The stmmac driver handles interrupts in the usual NAPI way: an interrupt arrives, the NAPI instance is scheduled and interrupts are masked, and the actual work occurs in the NAPI polling function. Once no further work remains, interrupts are unmasked and the NAPI instance is put to sleep to await a future interrupt. In the receive case, the MAC only sends the interrupt when a DMA operation completes; thus the driver must make sure a usable RX DMA descriptor exists before expecting a future interrupt. The main receive loop in stmmac_rx() exits under one of 3 conditions: 1) It encounters a DMA descriptor with OWN=1, indicating that no further pending data exists. The MAC will use this descriptor for the next RX DMA operation, so the driver can expect a future interrupt. 2) It exhausts the NAPI budget. In this case, the driver doesn't know whether the MAC has any usable DMA descriptors. But when the driver consumes its full budget, that signals NAPI to keep polling, so the question is moot. 3) It runs out of (non-dirty) descriptors in the RX ring. In this case, the MAC will only have a usable descriptor if stmmac_rx_refill() succeeds (at least partially). Currently, stmmac_rx() lacks any check against scenario #3 and stmmac_rx_refill() failing: it will stop NAPI polling and unmask interrupts to await an interrupt that will never arrive, stalling the receive pipeline indefinitely. Fix this by checking if stmmac_rx_dirty() returns its maximal value, returning the full budget (which tells NAPI to keep polling) if so. Cc: stable@vger.kernel.org Signed-off-by: Sam Edwards --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index f98b070073c0..d18ee145f5ca 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -5593,6 +5593,7 @@ static int stmmac_rx_zc(struct stmmac_priv *priv, int limit, u32 queue) */ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) { + int budget = limit; u32 rx_errors = 0, rx_dropped = 0, rx_bytes = 0, rx_packets = 0; struct stmmac_rxq_stats *rxq_stats = &priv->xstats.rxq_stats[queue]; struct stmmac_rx_queue *rx_q = &priv->dma_conf.rx_queue[queue]; @@ -5870,6 +5871,12 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) priv->xstats.rx_dropped += rx_dropped; priv->xstats.rx_errors += rx_errors; + /* If the RX queue is completely dirty, we can't expect a future + * interrupt; tell NAPI to keep polling. + */ + if (unlikely(stmmac_rx_dirty(priv, queue) == priv->dma_conf.dma_rx_size - 1)) + return budget; + return count; } -- 2.52.0