[PATCH] net: macvtap: add missing blank lines after declarations

[PATCH] net: macvtap: add missing blank lines after declarations

[Oskar Ray-Frayssinet]

Add missing blank lines after variable and struct declarations
to comply with kernel coding style.

Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
---
 drivers/net/macvtap.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index b391a0f740a3..bfaa80a77876 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -38,6 +38,7 @@ static dev_t macvtap_major;
 static const void *macvtap_net_namespace(const struct device *d)
 {
 	const struct net_device *dev = to_net_dev(d->parent);
+
 	return dev_net(dev);
 }
 
@@ -46,6 +47,7 @@ static struct class macvtap_class = {
 	.ns_type = &net_ns_type_operations,
 	.namespace = macvtap_net_namespace,
 };
+
 static struct cdev macvtap_cdev;
 
 #define TUN_OFFLOADS (NETIF_F_HW_CSUM | NETIF_F_TSO_ECN | NETIF_F_TSO | \
-- 
2.43.0

Re: [PATCH] net: macvtap: add missing blank lines after declarations

[Jakub Kicinski]

On Sun, 15 Mar 2026 21:13:38 +0100 Oskar Ray-Frayssinet wrote:
> Add missing blank lines after variable and struct declarations
> to comply with kernel coding style.

Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl``, and other trivial coding style warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
  
  Conversely, spelling and grammar fixes are not discouraged.
  
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
-- 
pw-bot: reject