From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C552332ED3; Mon, 16 Mar 2026 17:46:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773683208; cv=none; b=hjEpjVlwEhZqcz6jw3xNDd7pWY/Z2KRCCnppkjax4RrmljmCPqfjsidJopN7m5cc/ergVyAu08KHTwcd29AqCJ0XIIxZf3iQqJ+lxLrhhAlIJzYeDlEuoAPm3jKL1BrBS8FU2sWaPnqDThFZr6HUgmz3p1YDpZDwB5u9TU59Jc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773683208; c=relaxed/simple; bh=oUdqkprAKNLqdy+Z9DsSiRaGN2K4IDbzQNUWqrM2lm4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=akt0qKHGAXNRs2jZ93Wf8V9MnWqeXbKX7ZDGy8yqTKzqd1OQEMJd+pJFxrntBRkibhtqFLgJqcSDN7jqLGZ0d7RkeXp7GAd3RjBk1BJMsQgZkSankkExtuIGsMxYN5hzdhB4CjhiJvfma8DJFYNPlXtssHke/XW6SwKj3+/Ghiw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WoqNhiVd; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WoqNhiVd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773683208; x=1805219208; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=oUdqkprAKNLqdy+Z9DsSiRaGN2K4IDbzQNUWqrM2lm4=; b=WoqNhiVdC8/jsazxTgK3nb+8397y/2rvdJ+gJJ71TJlqp16Hnm2i3ToC Xjw8HnkJixIzIMPO1eUvXpxFXjfHsEAVGRqtztoPHriCUBro5dE9hqy9p zJvCJ8G80oVqbZz2pIqNfsVysoF1UGW6b5pVUwIZUlbTc9TdrjKFgPGVo QdxSqFG+a+/a0gVOpkyCPbILiCCzdNyCG8dvjrB/YUhPpgNaLGQkgUGAk H/MNYXj8tJpqJNTYrOsT7LU+ZsZckIALOkJNio2fRjSHpQutjP2nNQ2Y3 tQeEx67it0Py6pxMqtAsFEF0x4ZuY7rckdEPNIH3LMXK+nztd8WiGXsqs A==; X-CSE-ConnectionGUID: NW2cB2yBQYW3cr8iykJI0g== X-CSE-MsgGUID: TG03JD1CT2uhsH9SjYq+Vg== X-IronPort-AV: E=McAfee;i="6800,10657,11731"; a="62275742" X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="62275742" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2026 10:46:47 -0700 X-CSE-ConnectionGUID: TLKOM8CPSlmSJSaVJypwyA== X-CSE-MsgGUID: a72xo32NTpy8WRvQmEsDXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="222075763" Received: from boxer.igk.intel.com ([10.102.20.173]) by orviesa008.jf.intel.com with ESMTP; 16 Mar 2026 10:46:45 -0700 From: Maciej Fijalkowski To: netdev@vger.kernel.org Cc: bpf@vger.kernel.org, magnus.karlsson@intel.com, stfomichev@gmail.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, larysa.zaremba@intel.com, aleksander.lobakin@intel.com, Maciej Fijalkowski Subject: [PATCH net 6/6] selftests: bpf: have a separate variable for drop test Date: Mon, 16 Mar 2026 18:45:50 +0100 Message-Id: <20260316174550.462177-7-maciej.fijalkowski@intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20260316174550.462177-1-maciej.fijalkowski@intel.com> References: <20260316174550.462177-1-maciej.fijalkowski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently two different XDP programs share a static variable for different purposes (picking where to redirect on shared umem test & whether to drop a packet). This can be a problem when running full test suite - idx can be written by shared umem test and this value can cause a false behavior within XDP drop half test. Introduce a dedicated variable for drop half test so that these two don't step on each other toes. Signed-off-by: Maciej Fijalkowski --- tools/testing/selftests/bpf/progs/xsk_xdp_progs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/progs/xsk_xdp_progs.c b/tools/testing/selftests/bpf/progs/xsk_xdp_progs.c index 683306db8594..40609d8c2471 100644 --- a/tools/testing/selftests/bpf/progs/xsk_xdp_progs.c +++ b/tools/testing/selftests/bpf/progs/xsk_xdp_progs.c @@ -15,6 +15,7 @@ struct { __uint(value_size, sizeof(int)); } xsk SEC(".maps"); +static unsigned int drop_idx; static unsigned int idx; int adjust_value = 0; int count = 0; @@ -27,7 +28,7 @@ SEC("xdp.frags") int xsk_def_prog(struct xdp_md *xdp) SEC("xdp.frags") int xsk_xdp_drop(struct xdp_md *xdp) { /* Drop every other packet */ - if (idx++ % 2) + if (drop_idx++ % 2) return XDP_DROP; return bpf_redirect_map(&xsk, 0, XDP_DROP); -- 2.43.0