From: Jakub Kicinski <kuba@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/3] net: dpaa2-mac: extend APIs related to statistics
Date: Mon, 16 Mar 2026 20:39:39 -0700 [thread overview]
Message-ID: <20260316203939.7629aebf@kernel.org> (raw)
In-Reply-To: <20260312142249.297192-2-ioana.ciornei@nxp.com>
On Thu, 12 Mar 2026 16:22:47 +0200 Ioana Ciornei wrote:
> Extend the dpmac_counter_id enum with the newly added counters which can
> be interrogated through the MC firmware. Also add the
> dpmac_get_statistics() API which can be used to retrieve multiple MAC
> counters through a single firmware command.
> #ifndef __FSL_DPMAC_H
> #define __FSL_DPMAC_H
> @@ -170,6 +170,50 @@ int dpmac_set_link_state(struct fsl_mc_io *mc_io,
> * pause frames.
> * @DPMAC_CNT_EGR_GOOD_FRAME: counts frames transmitted without error, including
> * pause frames.
> + * @DPMAC_CNT_EGR_FRAME_64: counts transmitted 64-bytes frames, good or bad.
> + * @DPMAC_CNT_EGR_FRAME_127: counts transmitted 65 to 127-bytes frames, good or bad.
> + * @DPMAC_CNT_EGR_FRAME_255: counts transmitted 128 to 255-bytes frames, good or bad.
> + * @DPMAC_CNT_EGR_FRAME_511: counts transmitted 256 to 511-bytes frames, good or bad.
> + * @DPMAC_CNT_EGR_FRAME_1023: counts transmitted 512 to 1023-bytes frames, good or bad.
> + * @DPMAC_CNT_EGR_FRAME_1518: counts transmitted 1024 to 1518-bytes frames, good or bad.
please try to wrap netdev code at 80 chars, especially if it's just
comments where wrapping doesn't hurt readability.
> + * @DPMAC_CNT_EGR_FRAME_1519_MAX: counts transmitted 1519-bytes frames and
> + * larger (up to max frame length specified), good or bad.
Other entries in this doc prefix the continuation lines..
next prev parent reply other threads:[~2026-03-17 3:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 14:22 [PATCH net-next v2 0/3] net: dpaa2-mac: export standard statistics Ioana Ciornei
2026-03-12 14:22 ` [PATCH net-next v2 1/3] net: dpaa2-mac: extend APIs related to statistics Ioana Ciornei
2026-03-17 3:39 ` Jakub Kicinski [this message]
2026-03-17 8:17 ` Ioana Ciornei
2026-03-12 14:22 ` [PATCH net-next v2 2/3] net: dpaa2-mac: retrieve MAC statistics in one firmware command Ioana Ciornei
2026-03-17 3:41 ` Jakub Kicinski
2026-03-17 8:21 ` Ioana Ciornei
2026-03-12 14:22 ` [PATCH net-next v2 3/3] net: dpaa2-mac: export standard statistics Ioana Ciornei
2026-03-17 3:42 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316203939.7629aebf@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox