public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH iwl-next v1] ice: add ethtool reset support to safe mode ops
@ 2026-03-17  8:44 Aleksandr Loktionov
  2026-03-17 14:11 ` [Intel-wired-lan] " Przemek Kitszel
  0 siblings, 1 reply; 2+ messages in thread
From: Aleksandr Loktionov @ 2026-03-17  8:44 UTC (permalink / raw)
  To: intel-wired-lan, anthony.l.nguyen, aleksandr.loktionov; +Cc: netdev

From: Mateusz Polchlopek <mateusz.polchlopek@intel.com>

Wire up ice_ethtool_reset() into ice_ethtool_safe_mode_ops so that the
.reset ethtool operation is available when the driver is operating in safe
mode, consistent with the behaviour exposed by the full ice_ethtool_ops.

Without this, a user-space call to ethtool --reset while the driver is in
safe mode would return EOPNOTSUPP even though the underlying reset logic
is fully implemented and works correctly.

Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_ethtool.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
index 301947d..bf90bd5 100644
--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
@@ -4917,6 +4917,7 @@ static const struct ethtool_ops ice_ethtool_safe_mode_ops = {
 	.set_ringparam		= ice_set_ringparam,
 	.nway_reset		= ice_nway_reset,
 	.get_channels		= ice_get_channels,
+	.reset			= ice_ethtool_reset,
 };
 
 /**
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: add ethtool reset support to safe mode ops
  2026-03-17  8:44 [PATCH iwl-next v1] ice: add ethtool reset support to safe mode ops Aleksandr Loktionov
@ 2026-03-17 14:11 ` Przemek Kitszel
  0 siblings, 0 replies; 2+ messages in thread
From: Przemek Kitszel @ 2026-03-17 14:11 UTC (permalink / raw)
  To: Aleksandr Loktionov, intel-wired-lan, anthony.l.nguyen; +Cc: netdev

On 3/17/26 09:44, Aleksandr Loktionov wrote:
> From: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
> 
> Wire up ice_ethtool_reset() into ice_ethtool_safe_mode_ops so that the
> .reset ethtool operation is available when the driver is operating in safe
> mode, consistent with the behaviour exposed by the full ice_ethtool_ops.
> 
> Without this, a user-space call to ethtool --reset while the driver is in
> safe mode would return EOPNOTSUPP even though the underlying reset logic
> is fully implemented and works correctly.
> 
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_ethtool.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> index 301947d..bf90bd5 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> @@ -4917,6 +4917,7 @@ static const struct ethtool_ops ice_ethtool_safe_mode_ops = {
>   	.set_ringparam		= ice_set_ringparam,
>   	.nway_reset		= ice_nway_reset,
>   	.get_channels		= ice_get_channels,
> +	.reset			= ice_ethtool_reset,
>   };
>   
>   /**

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-17 14:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-17  8:44 [PATCH iwl-next v1] ice: add ethtool reset support to safe mode ops Aleksandr Loktionov
2026-03-17 14:11 ` [Intel-wired-lan] " Przemek Kitszel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox